about summary refs log tree commit diff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* math: clean up __rem_pio2Szabolcs Nagy2013-11-243-71/+53
| | | | | | | | | | | - remove the HAVE_EFFICIENT_IRINT case: fn is an exact integer, so it can be converted to int32_t a bit more efficiently than with a cast (the rounding mode change can be avoided), but musl does not support this case on any arch. - __rem_pio2: use double_t where possible - __rem_pio2f: use less assignments to avoid stores on i386 - use unsigned int bit manipulation (and union instead of macros) - use hexfloat literals instead of named constants
* Fix dn_expand pointer followingMichael Forney2013-11-231-1/+1
|
* putgrent: Add missing newlineMichael Forney2013-11-231-0/+1
|
* putgrent: Stop writing output on first failureMichael Forney2013-11-231-2/+3
| | | | | This way, if an fprintf fails, we get an incomplete group entry rather than a corrupted one.
* strcmp: Remove unnecessary check for *rMichael Forney2013-11-231-1/+1
| | | | If *l == *r && *l, then by transitivity, *r.
* fix and refactor child reaping logic in wordexpRich Felker2013-11-221-6/+16
| | | | | | loop condition was incorrect and confusing and caused an infinite loop when (broken) applications reaped the pid from a signal handler or another thread before wordexp's call to waitpid could do so.
* fix fd leak and case where fd 1 is already closed in wordexpRich Felker2013-11-221-4/+4
|
* fix resource exhaustion and zero-word cases in wordexpRich Felker2013-11-221-8/+18
| | | | | | | | | | | | | when WRDE_NOSPACE is returned, the we_wordv and we_wordc members must be valid, because the interface contract allows them to return partial results. in the case of zero results (due either to resource exhaustion or a zero-word input) the we_wordv array still should contain a terminating null pointer and the initial we_offs null pointers. this is impossible on resource exhaustion, so a correct application must presumably check for a null pointer in we_wordv; POSIX however seems to ignore the issue. the previous code may have crashed under this situation.
* improve robustness of wordexp and fix handling of 0-word caseRich Felker2013-11-221-11/+16
| | | | | | | | | | | | | | | | | | | | avoid using exit status to determine if a shell error occurred, since broken programs may install SIGCHLD handlers which reap all zombies, including ones that don't belong to them. using clone and __WCLONE does not seem to work for avoiding this problem since exec resets the exit signal to SIGCHLD. instead, the new code uses a dummy word at the beginning of the shell's output, which is ignored, to determine whether the command was executed successfully. this also fixes a corner case where a word string containing zero words was interpreted as a single zero-length word rather than no words at all. POSIX does not seem to require this case to be supported anyway, though. in addition, the new code uses the correct retry idiom for waitpid to ensure that spurious STOP/CONT signals in the child and/or EINTR in the parent do not prevent successful wait for the child, and blocks signals in the child.
* add legacy getloadavg apiSzabolcs Nagy2013-11-211-0/+18
|
* fix fd leak (missing close-on-exec) in getifaddrsRich Felker2013-11-201-1/+1
|
* math: add (obsolete) bsd drem and finite functionsSzabolcs Nagy2013-11-214-0/+20
|
* math: lgamma cleanup (simpler sin(pi*x) for the negative case)Szabolcs Nagy2013-11-214-202/+110
| | | | | | | | | * simplify sin_pi(x) (don't care about inexact here, the result is inexact anyway, and x is not so small to underflow) * in lgammal add the previously removed special case for x==1 and x==2 (to fix the sign of zero in downward rounding mode) * only define lgammal on supported long double platforms * change tgamma so the generated code is a bit smaller
* iswspace: fix handling of 0rofl0r2013-11-111-2/+1
|
* fix harmless inconsistency in semtimedopRich Felker2013-11-091-1/+1
| | | | | | | this should not matter since the reality is that either all the sysv sem syscalls are individual syscalls, or all of them are multiplexed on the SYS_ipc syscall (depending on arch). but best to be consistent anyway.
* implement semtimedopRich Felker2013-11-092-0/+14
| | | | this is a Linux-specific extension to the sysv semaphore api.
* remove O_NOFOLLOW from __map_file used for time zone file loadingRich Felker2013-11-081-1/+1
| | | | | | | | | | | | | it's not clear why I originally wrote O_NOFOLLOW into this; I suspect the reason was with an aim of making the function more general for mapping partially or fully untrusted files provided by the user. however, the timezone code already precludes use of absolute or relative pathnames in suid/sgid programs, and disallows .. in pathnames which are relative to one of the system timezone locations, so there is no threat of opening a symlink which is not trusted by appropriate user. since some users may wish to put symbolic links in the zoneinfo directories to alias timezones, it seems preferable to allow this.
* fix handling of overly-long TZ environment variable valuesRich Felker2013-11-081-1/+1
| | | | | | the rest of the code is not prepared to handle an empty TZ string, so falling back to __gmt ("GMT"), just as if TZ had been blank or unset, is the preferable action.
* timezone parser: fix iteration over search dir pathsrofl0r2013-11-041-1/+1
| | | | try+l points to \0, so only one iteration was ever tried.
* timezone parser: fix offset to transition table in 64bit code pathrofl0r2013-11-041-1/+1
| | | | | | we need to skip to the second TZif header, which starts at skip+44, and then skip another header (20 bytes) plus the following 6 32bit values.
* fix timezone parser code crashing on 64bit sysrofl0r2013-11-041-1/+1
| | | | | | | if sizeof(time_t) == 8, this code path was missing the correct offset into the zoneinfo file, using the header magic to do offset calculations. the 6 32bit fields to be read start at offset 20.
* fix regression in inet_aton due to misinterpretation of __ipparse returnRich Felker2013-11-022-3/+3
| | | | | | | inet_aton returns a boolean success value, whereas __ipparse returns 0 on success and -1 on failure. also change the conditional in inet_addr to be consistent with other uses of __ipparse where only negative values are treated as failure.
* simplify faccessat AT_EACCESS path and eliminate resource dependenceRich Felker2013-11-011-14/+21
| | | | | | | now that we're waiting for the exit status of the child process, the result can be conveyed in the exit status rather than via a pipe. since the error value might not fit in 7 bits, a table is used to translate possible meaningful error values to small integers.
* fix faccessat AT_EACCESS path not to leave zombie processesRich Felker2013-11-011-2/+6
| | | | | | I mistakenly assumed that clone without a signal produced processes that would not become zombies; however, waitpid with __WCLONE is required to release their pids.
* POSIX conformance fix: define struct entry in search.hSzabolcs Nagy2013-10-291-8/+8
|
* fenv: fix i386 fesetround for sseSzabolcs Nagy2013-10-281-1/+1
| | | | | | i386 fenv code checks __hwcap for sse support, but in fesetround the sse code was unconditionally jumped over after the test so the sse rounding mode was never set.
* math: extensive log*.c cleanupSzabolcs Nagy2013-10-2814-583/+369
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The log, log2 and log10 functions share a lot of code and to a lesser extent log1p too. A small part of the code was kept separately in __log1p.h, but since it did not capture much of the common code and it was inlined anyway, it did not solve the issue properly. Now the log functions have significant code duplication, which may be resolved later, until then they need to be modified together. logl, log10l, log2l, log1pl: * Fix the sign when the return value should be -inf. * Remove the volatile hack from log10l (seems unnecessary) log1p, log1pf: * Change the handling of small inputs: only |x|<2^-53 is special (then it is enough to return x with the usual subnormal handling) this fixes the sign of log1p(0) in downward rounding. * Do not handle the k==0 case specially (other than skipping the elaborate argument reduction) * Do not handle 1+x close to power-of-two specially (this code was used rarely, did not give much speed up and the precision wasn't better than the general) * Fix the correction term formula (c=1-(u-x) was used incorrectly when x<1 but (double)(x+1)==2, this was not a critical issue) * Use the exact same method for calculating log(1+f) as in log (except in log1p the c correction term is added to the result). log, logf, log10, log10f, log2, log2f: * Use double_t and float_t consistently. * Now the first part of log10 and log2 is identical to log (until the return statement, hopefully this makes maintainence easier). * Most special case formulas were removed (close to power-of-two and k==0 cases), they increase the code size without providing precision or performance benefits (and obfuscate the code). Only x==1 is handled specially so in downward rounding mode the sign of zero is correct (the general formula happens to give -0). * For x==0 instead of -1/0.0 or -two54/0.0, return -1/(x*x) to force raising the exception at runtime. * Arg reduction code is changed (slightly simplified) * The thresholds for arg reduction to [sqrt(2)/2,sqrt(2)] are now consistently the [0x3fe6a09e00000000,0x3ff6a09dffffffff] and the [0x3f3504f3,0x3fb504f2] intervals for double and float reductions respectively (the exact threshold values are not critical) * Remove the obsolete comment for the FLT_EVAL_METHOD!=0 case in log2f (The same code is used for all eval methods now, on i386 slightly simpler code could be used, but we have asm there anyway) all: * Fix signed int arithmetics (using unsigned for bitmanipulation) * Fix various comments
* add legacy ftime function and sys/timeb.hRich Felker2013-10-251-0/+12
| | | | | | despite being marked legacy, this was specified by SUSv3 as part of the XSI option; only the most recent version of the standard dropped it. reportedly there's actual code using it.
* fix inet_ptonSzabolcs Nagy2013-10-231-26/+19
| | | | | | | | * parse IPv4 dotted-decimal correctly (without strtoul, no leading zeros) * disallow single leading ':' in IPv6 address * allow at most 4 hex digits in IPv6 address (according to RFC 2373) * have enough hex fields in IPv4 mapped IPv6 address * disallow leading zeros in IPv4 mapped IPv6 address
* fix __ipparse to parse the generic numbers-and-dots IPv4 format correctlySzabolcs Nagy2013-10-221-5/+12
| | | | | | | * allow at most 4 parts * bounds check the parts correctly * disallow leading whitespace and sign * check the address family before falling back to IPv6
* fix inet_aton to accept the generic "numbers-and-dots" IPv4 address formatSzabolcs Nagy2013-10-221-1/+4
|
* split inet_addr and inet_ntoa back into their own filesRich Felker2013-10-213-16/+21
| | | | | | | despite being practically deprecated, these functions are still part of the standard and thus cannot reside in a file that also contains namespace pollution. this reverts some of the changes made in commit e40f48a421a9176e3e298b5bac75f0355b219e58.
* fix return value for inet_pton in ipv6 failure casesRich Felker2013-10-191-6/+6
| | | | | in the case of input that does not match the expected form, the correct return value is 0, not -1.
* in faccessat slow path, add close-on-exec to pipe fdsRich Felker2013-10-181-1/+1
| | | | | as usual, this is needed to avoid fd leaks. as a better solution, the use of fds could possibly be replaced with mmap and a futex.
* fix uid/gid-setting error in faccessat with AT_EACCESS flagRich Felker2013-10-121-2/+2
| | | | | | | | | | | | | | | | this fixes an issue reported by Daniel Thau whereby faccessat with the AT_EACCESS flag did not work in cases where the process is running suid or sgid but without root privileges. per POSIX, when the process does not have "appropriate privileges", setuid changes the euid, not the real uid, and the target uid must be equal to the current real or saved uid; if this condition is not met, EPERM results. this caused the faccessat child process to fail. using the setreuid syscall rather than setuid works. POSIX leaves it unspecified whether setreuid can set the real user id to the effective user id on processes without "appropriate privileges", but Linux allows this; if it's not allowed, there would be no way for this function to work.
* fix errno value for getcwd when size argument is zeroRich Felker2013-10-081-1/+7
| | | | | | | | | based on patch by Michael Forney. at the same time, I've changed the if branch to be more clear, avoiding the comma operator. the underlying issue is that Linux always returns ERANGE when size is too short, even when it's zero, rather than returning EINVAL for the special case of zero as required by POSIX.
* math: fix rare underflow issue in fmaSzabolcs Nagy2013-10-073-13/+55
| | | | | the issue is described in commits 1e5eb73545ca6cfe8b918798835aaf6e07af5beb and ffd8ac2dd50f99c3c83d7d9d845df9874ec3e7d5
* math: use sqrtl if FLT_EVAL_METHOD==2 in acosh and acoshfSzabolcs Nagy2013-10-072-0/+13
| | | | this makes acosh slightly more precise around 1.0 on i386
* remove errno setting from setenv, malloc sets it correctly on oomSzabolcs Nagy2013-10-071-1/+0
|
* fix allocation sizes in regcompSzabolcs Nagy2013-10-071-4/+4
| | | | | sizeof had incorrect argument in a few places, the size was always large enough so the issue was not critical.
* add missing va_end in execl* for correcness and static code analyzersSzabolcs Nagy2013-10-073-0/+3
|
* minor vfprintf and vfwprintf changes to please static code analyzersSzabolcs Nagy2013-10-072-6/+11
| | | | add missing va_end and remove some unnecessary code.
* math: remove an unused variable from modflSzabolcs Nagy2013-10-061-1/+0
|
* slightly optimize __brk for sizeRich Felker2013-10-051-1/+1
| | | | | | | | | | there is no reason to check the return value for setting errno, since brk never returns errors, only the new value of the brk (which may be the same as the old, or otherwise differ from the requested brk, on failure). it may be beneficial to eventually just eliminate this file and make the syscalls inline in malloc.c.
* fix failure of malloc to set errno on heap (brk) exhaustionRich Felker2013-10-051-0/+1
| | | | | I wrongly assumed the brk syscall would set errno, but on failure it returns the old value of the brk rather than an error code.
* fix failure to check malloc result in setenvRich Felker2013-10-041-9/+9
|
* math: remove code duplication in erfl found by clang analyzerSzabolcs Nagy2013-10-041-13/+2
| | | | | erfl had some superflous code left around after the last erf cleanup. the issue was reported by Alexander Monakov
* math: remove a useless assignment in lgammal found by clang analyzerSzabolcs Nagy2013-10-041-2/+2
| | | | the issue was reported by Alexander Monakov
* fix invalid implicit pointer conversion in pthread_key_createRich Felker2013-10-041-1/+1
|
* fix uninitialized variable in dladdrRich Felker2013-10-041-1/+1
| | | | | the affected branch only applies for DSOs that lack standard hash table and only have the GNU hash table present.