about summary refs log tree commit diff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* optimize out useless default-attribute object in pthread_createRich Felker2011-05-071-7/+7
|
* optimize compound-literal sigset_t's not to contain useless hurd bitsRich Felker2011-05-073-5/+7
|
* overhaul implementation-internal signal protectionsRich Felker2011-05-0712-49/+31
| | | | | | | | | | | | | | | | | | | the new approach relies on the fact that the only ways to create sigset_t objects without invoking UB are to use the sig*set() functions, or from the masks returned by sigprocmask, sigaction, etc. or in the ucontext_t argument to a signal handler. thus, as long as sigfillset and sigaddset avoid adding the "protected" signals, there is no way the application will ever obtain a sigset_t including these bits, and thus no need to add the overhead of checking/clearing them when sigprocmask or sigaction is called. note that the old code actually *failed* to remove the bits from sa_mask when sigaction was called. the new implementations are also significantly smaller, simpler, and faster due to ignoring the useless "GNU HURD signals" 65-1024, which are not used and, if there's any sanity in the world, never will be used.
* reduce some ridiculously large spin countsRich Felker2011-05-062-2/+2
| | | | | | these should be tweaked according to testing. offhand i know 1000 is too low and 5000 is likely to be sufficiently high. consider trying to add futexes to file locking, too...
* remove debug code that was missed in barrier commitRich Felker2011-05-061-1/+0
|
* completely new barrier implementation, addressing major correctness issuesRich Felker2011-05-062-20/+48
| | | | | | | | | | | | | | | | | | | | the previous implementation had at least 2 problems: 1. the case where additional threads reached the barrier before the first wave was finished leaving the barrier was untested and seemed not to be working. 2. threads leaving the barrier continued to access memory within the barrier object after other threads had successfully returned from pthread_barrier_wait. this could lead to memory corruption or crashes if the barrier object had automatic storage in one of the waiting threads and went out of scope before all threads finished returning, or if one thread unmapped the memory in which the barrier object lived. the new implementation avoids both problems by making the barrier state essentially local to the first thread which enters the barrier wait, and forces that thread to be the last to return.
* fix fclose return status logic, againRich Felker2011-05-021-1/+2
| | | | | | | | the previous fix was incorrect, as it would prevent f->close(f) from being called if fflush(f) failed. i believe this was the original motivation for using | rather than ||. so now let's just use a second statement to constrain the order of function calls, and to back to using |.
* fix undefined call order in fclose, possible lost output depending on compilerRich Felker2011-05-011-1/+1
| | | | | pcc turned up this bug by calling f->close(f) before fflush(f), resulting in lost output and error on flush.
* workaround for preprocessor bug in pccRich Felker2011-05-011-7/+7
| | | | | | | with this patch, musl compiles and mostly works with pcc 1.0.0. a few tests are still failing and i'm uncertain whether they are due to portability problems in musl, or bugs in pcc, but i suspect the latter.
* minor optimization in puts: use inline putc_unlocked macro for newlineRich Felker2011-05-011-1/+1
|
* avoid crashing when nel==0 is passed to qsortRich Felker2011-04-291-2/+6
|
* correct variadic prototypes for execl* familyRich Felker2011-04-273-15/+18
| | | | | the old versions worked, but conflicted with programs which declared their own prototypes and generated warnings with some versions of gcc.
* replace heap sort with smoothsort implementation by Valentin OchsRich Felker2011-04-271-32/+193
| | | | | | | | | | | | | | Smoothsort is an adaptive variant of heapsort. This version was written by Valentin Ochs (apo) specifically for inclusion in musl. I worked with him to get it working in O(1) memory usage even with giant array element widths, and to optimize it heavily for size and speed. It's still roughly 4 times as large as the old heap sort implementation, but roughly 20 times faster given an almost-sorted array of 1M elements (20 being the base-2 log of 1M), i.e. it really does reduce O(n log n) to O(n) in the mostly-sorted case. It's still somewhat slower than glibc's Introsort for random input, but now considerably faster than glibc when the input is already sorted, or mostly sorted.
* function signature fix: add const qualifier to mempcpy src argRich Felker2011-04-261-1/+1
|
* fix bug in ipv6 parsing that prevented parsing a lone "::"Rich Felker2011-04-251-4/+1
|
* ipv6 parsing code (formerly dummied-out)Rich Felker2011-04-252-8/+62
|
* fix 2 eof-related bugs in scanfRich Felker2011-04-251-3/+4
| | | | | | | | | 1. failed match of literal chars from the format string would always return matching failure rather than input failure at eof, leading to infinite loops in some programs. 2. unread of eof would wrongly adjust the character counts reported by %n, yielding an off-by-one error.
* fix initial stack alignment in new threads on x86_64Rich Felker2011-04-221-1/+1
|
* omit errno update path for syscalls that cannot failRich Felker2011-04-217-7/+7
|
* fix bogus return values for inet_ptonRich Felker2011-04-211-2/+2
|
* fix minor bugs due to incorrect threaded-predicate semanticsRich Felker2011-04-204-6/+6
| | | | | | | | | | | | some functions that should have been testing whether pthread_self() had been called and initialized the thread pointer were instead testing whether pthread_create() had been called and actually made the program "threaded". while it's unlikely any mismatch would occur in real-world problems, this could have introduced subtle bugs. now, we store the address of the main thread's thread descriptor in the libc structure and use its presence as a flag that the thread register is initialized. note that after fork, the calling thread (not necessarily the original main thread) is the new main thread.
* workaround bug in linux dup2Rich Felker2011-04-201-1/+4
| | | | | | the linux documentation for dup2 says it can fail with EBUSY due to a race condition with open and dup in the kernel. shield applications (and the rest of libc) from this nonsense by looping until it succeeds
* properly create new session/controlling terminal in forkptyRich Felker2011-04-201-1/+4
|
* implement (nonstandard) forkptyRich Felker2011-04-201-0/+22
|
* disallow blank strings as service or host nameRich Felker2011-04-201-0/+3
|
* fix bugs in ipv4 parsingRich Felker2011-04-201-1/+2
|
* fix initgroups (uninitialized count passed to getgrouplist)Rich Felker2011-04-201-1/+1
|
* shadow password fixes: empty fields should read as -1 not 0Rich Felker2011-04-201-7/+13
|
* namespace fixes for sys/mman.hRich Felker2011-04-201-0/+1
|
* fix missing include in posix_madvise.c (compile error)Rich Felker2011-04-201-0/+1
|
* support posix_madvise (previous a stub)Rich Felker2011-04-201-1/+3
| | | | | the check against MADV_DONTNEED to because linux MADV_DONTNEED semantics conflict dangerously with the POSIX semantics
* add syscall wrappers for posix_fadvise, posix_fallocateRich Felker2011-04-202-0/+16
|
* block cancellation in wordexp, handle more errorsRich Felker2011-04-191-2/+17
|
* avoid malloc of potentially-large string in wordexpRich Felker2011-04-191-10/+28
|
* move some more code out of pthread_create.cRich Felker2011-04-192-7/+4
| | | | this also de-uglifies the dummy function aliasing a bit.
* fix uninitialized waiters field in semaphoresRich Felker2011-04-191-0/+1
|
* dns lookups: protect against cancellation and fix incorrect error codesRich Felker2011-04-181-4/+10
|
* avoid fd leak if opendir is cancelled when calloc has failedRich Felker2011-04-181-1/+2
|
* protect ftw and nftw against cancellationRich Felker2011-04-181-1/+6
|
* protect syslog against cancellationRich Felker2011-04-181-5/+19
| | | | | | these functions are allowed to be cancellation points, but then we would have to install cleanup handlers to avoid termination with locks held.
* recheck cancellation disabled flag after syscall returns EINTRRich Felker2011-04-181-1/+1
| | | | | | | we already checked before making the syscall, but it's possible that a signal handler interrupted the blocking syscall and disabled cancellation, and that this is the cause of EINTR. in this case, the old behavior was testably wrong.
* remove bogus extra logic for close cancellabilityRich Felker2011-04-181-3/+1
| | | | | | like all other syscalls, close should return to the caller if and only if it successfully performed its action. it is necessary that the application be able to determine whether the close succeeded.
* fix typo in x86_64 cancellable syscall asmRich Felker2011-04-171-1/+1
|
* minimal realpath implementation using /procRich Felker2011-04-171-0/+43
| | | | | | | clean and simple, but fails when the caller does not have permissions to open the file for reading or when /proc is not available. i may replace this with a full implementation later, possibly leaving this version as an optimization to use when it works.
* pthread_exit is not supposed to affect cancellabilityRich Felker2011-04-171-2/+0
| | | | | if the exit was caused by cancellation, __cancel has already set these flags anyway.
* fix pthread_exit from cancellation handlerRich Felker2011-04-171-5/+5
| | | | | cancellation frames were not correctly popped, so this usage would not only loop, but also reuse discarded and invalid parts of the stack.
* clean up handling of thread/nothread mode, lockingRich Felker2011-04-178-27/+16
|
* debloat: use __syscall instead of syscall where possibleRich Felker2011-04-177-8/+8
| | | | | | don't waste time (and significant code size due to function call overhead!) setting errno when the result of a syscall does not matter or when it can't fail.
* fix bugs in cancellable syscall asmRich Felker2011-04-173-11/+12
| | | | | | | | | | | | | | | | x86_64 was just plain wrong in the cancel-flag-already-set path, and crashing. the more subtle error was not clearing the saved stack pointer before returning to c code. this could result in the signal handler misidentifying c code as the pre-syscall part of the asm, and acting on cancellation at the wrong time, and thus resource leak race conditions. also, now __cancel (in the c code) is responsible for clearing the saved sp in the already-cancelled branch. this means we have to use call rather than jmp to ensure the stack pointer in the c will never match what the asm saved.
* optimize cancellation enable/disable codeRich Felker2011-04-174-4/+11
| | | | | | | | | | | | | | | | | | the goal is to be able to use pthread_setcancelstate internally in the implementation, whenever a function might want to use functions which are cancellation points but avoid becoming a cancellation point itself. i could have just used a separate internal function for temporarily inhibiting cancellation, but the solution in this commit is better because (1) it's one less implementation-specific detail in functions that need to use it, and (2) application code can also get the same benefit. previously, pthread_setcancelstate dependend on pthread_self, which would pull in unwanted thread setup overhead for non-threaded programs. now, it temporarily stores the state in the global libc struct if threads have not been initialized, and later moves it if needed. this way we can instead use __pthread_self, which has no dependencies and assumes that the thread register is already valid.