about summary refs log tree commit diff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* fix minor bugs due to incorrect threaded-predicate semanticsRich Felker2011-04-204-6/+6
| | | | | | | | | | | | some functions that should have been testing whether pthread_self() had been called and initialized the thread pointer were instead testing whether pthread_create() had been called and actually made the program "threaded". while it's unlikely any mismatch would occur in real-world problems, this could have introduced subtle bugs. now, we store the address of the main thread's thread descriptor in the libc structure and use its presence as a flag that the thread register is initialized. note that after fork, the calling thread (not necessarily the original main thread) is the new main thread.
* workaround bug in linux dup2Rich Felker2011-04-201-1/+4
| | | | | | the linux documentation for dup2 says it can fail with EBUSY due to a race condition with open and dup in the kernel. shield applications (and the rest of libc) from this nonsense by looping until it succeeds
* properly create new session/controlling terminal in forkptyRich Felker2011-04-201-1/+4
|
* implement (nonstandard) forkptyRich Felker2011-04-201-0/+22
|
* disallow blank strings as service or host nameRich Felker2011-04-201-0/+3
|
* fix bugs in ipv4 parsingRich Felker2011-04-201-1/+2
|
* fix initgroups (uninitialized count passed to getgrouplist)Rich Felker2011-04-201-1/+1
|
* shadow password fixes: empty fields should read as -1 not 0Rich Felker2011-04-201-7/+13
|
* namespace fixes for sys/mman.hRich Felker2011-04-201-0/+1
|
* fix missing include in posix_madvise.c (compile error)Rich Felker2011-04-201-0/+1
|
* support posix_madvise (previous a stub)Rich Felker2011-04-201-1/+3
| | | | | the check against MADV_DONTNEED to because linux MADV_DONTNEED semantics conflict dangerously with the POSIX semantics
* add syscall wrappers for posix_fadvise, posix_fallocateRich Felker2011-04-202-0/+16
|
* block cancellation in wordexp, handle more errorsRich Felker2011-04-191-2/+17
|
* avoid malloc of potentially-large string in wordexpRich Felker2011-04-191-10/+28
|
* move some more code out of pthread_create.cRich Felker2011-04-192-7/+4
| | | | this also de-uglifies the dummy function aliasing a bit.
* fix uninitialized waiters field in semaphoresRich Felker2011-04-191-0/+1
|
* dns lookups: protect against cancellation and fix incorrect error codesRich Felker2011-04-181-4/+10
|
* avoid fd leak if opendir is cancelled when calloc has failedRich Felker2011-04-181-1/+2
|
* protect ftw and nftw against cancellationRich Felker2011-04-181-1/+6
|
* protect syslog against cancellationRich Felker2011-04-181-5/+19
| | | | | | these functions are allowed to be cancellation points, but then we would have to install cleanup handlers to avoid termination with locks held.
* recheck cancellation disabled flag after syscall returns EINTRRich Felker2011-04-181-1/+1
| | | | | | | we already checked before making the syscall, but it's possible that a signal handler interrupted the blocking syscall and disabled cancellation, and that this is the cause of EINTR. in this case, the old behavior was testably wrong.
* remove bogus extra logic for close cancellabilityRich Felker2011-04-181-3/+1
| | | | | | like all other syscalls, close should return to the caller if and only if it successfully performed its action. it is necessary that the application be able to determine whether the close succeeded.
* fix typo in x86_64 cancellable syscall asmRich Felker2011-04-171-1/+1
|
* minimal realpath implementation using /procRich Felker2011-04-171-0/+43
| | | | | | | clean and simple, but fails when the caller does not have permissions to open the file for reading or when /proc is not available. i may replace this with a full implementation later, possibly leaving this version as an optimization to use when it works.
* pthread_exit is not supposed to affect cancellabilityRich Felker2011-04-171-2/+0
| | | | | if the exit was caused by cancellation, __cancel has already set these flags anyway.
* fix pthread_exit from cancellation handlerRich Felker2011-04-171-5/+5
| | | | | cancellation frames were not correctly popped, so this usage would not only loop, but also reuse discarded and invalid parts of the stack.
* clean up handling of thread/nothread mode, lockingRich Felker2011-04-178-27/+16
|
* debloat: use __syscall instead of syscall where possibleRich Felker2011-04-177-8/+8
| | | | | | don't waste time (and significant code size due to function call overhead!) setting errno when the result of a syscall does not matter or when it can't fail.
* fix bugs in cancellable syscall asmRich Felker2011-04-173-11/+12
| | | | | | | | | | | | | | | | x86_64 was just plain wrong in the cancel-flag-already-set path, and crashing. the more subtle error was not clearing the saved stack pointer before returning to c code. this could result in the signal handler misidentifying c code as the pre-syscall part of the asm, and acting on cancellation at the wrong time, and thus resource leak race conditions. also, now __cancel (in the c code) is responsible for clearing the saved sp in the already-cancelled branch. this means we have to use call rather than jmp to ensure the stack pointer in the c will never match what the asm saved.
* optimize cancellation enable/disable codeRich Felker2011-04-174-4/+11
| | | | | | | | | | | | | | | | | | the goal is to be able to use pthread_setcancelstate internally in the implementation, whenever a function might want to use functions which are cancellation points but avoid becoming a cancellation point itself. i could have just used a separate internal function for temporarily inhibiting cancellation, but the solution in this commit is better because (1) it's one less implementation-specific detail in functions that need to use it, and (2) application code can also get the same benefit. previously, pthread_setcancelstate dependend on pthread_self, which would pull in unwanted thread setup overhead for non-threaded programs. now, it temporarily stores the state in the global libc struct if threads have not been initialized, and later moves it if needed. this way we can instead use __pthread_self, which has no dependencies and assumes that the thread register is already valid.
* don't use pthread_once when there is no danger in raceRich Felker2011-04-171-2/+5
|
* fix some minor issues in cancellation handling patchRich Felker2011-04-173-11/+19
| | | | | signals were wrongly left masked, and cancellability state was not switched to disabled, during the execution of cleanup handlers.
* overhaul pthread cancellationRich Felker2011-04-1745-218/+235
| | | | | | | | | | | | | | | | | | | | | | this patch improves the correctness, simplicity, and size of cancellation-related code. modulo any small errors, it should now be completely conformant, safe, and resource-leak free. the notion of entering and exiting cancellation-point context has been completely eliminated and replaced with alternative syscall assembly code for cancellable syscalls. the assembly is responsible for setting up execution context information (stack pointer and address of the syscall instruction) which the cancellation signal handler can use to determine whether the interrupted code was in a cancellable state. these changes eliminate race conditions in the previous generation of cancellation handling code (whereby a cancellation request received just prior to the syscall would not be processed, leaving the syscall to block, potentially indefinitely), and remedy an issue where non-cancellable syscalls made from signal handlers became cancellable if the signal handler interrupted a cancellation point. x86_64 asm is untested and may need a second try to get it right.
* remove stupid debug code in wordexpRich Felker2011-04-151-1/+0
|
* implement wordexp. first try, may be buggy. intended to be safe.Rich Felker2011-04-151-0/+128
|
* avoid setting errno when checking for ttyRich Felker2011-04-152-2/+2
| | | | | | | setting errno here is completely valid, but some programs, notably busybox printf, assume that errno will not be set during output and treat this as an error condition. in any case, skipping it slightly reduces code size and saves time.
* make tmpfile slightly more efficient (use unlink syscall instead of remove)Rich Felker2011-04-141-1/+1
|
* change sem_trywait algorithm so it never has to call __wakeRich Felker2011-04-141-3/+2
|
* cheap trick to further optimize locking normal mutexesRich Felker2011-04-142-2/+2
|
* use a separate signal from SIGCANCEL for SIGEV_THREAD timersRich Felker2011-04-146-11/+29
| | | | | | otherwise we cannot support an application's desire to use asynchronous cancellation within the callback function. this change also slightly debloats pthread_create.c.
* simplify cancellation point handlingRich Felker2011-04-132-16/+5
| | | | | | we take advantage of the fact that unless self->cancelpt is 1, cancellation cannot happen. so just increment it by 2 to temporarily block cancellation. this drops pthread_create.o well under 1k.
* simplify syslog, add vsyslog interface (nonstandard)Rich Felker2011-04-131-31/+36
| | | | | | | | with datagram sockets, depending on fprintf not to flush the output early was very fragile; the new version simply uses a small fixed-size buffer. it could be updated to dynamic-allocate large buffers if needed, but i can't envision any admin being happy about finding 64kb-long lines in their syslog...
* remove useless SIGPIPE protection from syslogRich Felker2011-04-131-9/+0
| | | | per the standard, SIGPIPE is not generated for SOCK_DGRAM.
* fix syslog (corrected SIGPIPE blocking, and using dgram instead of stream)Rich Felker2011-04-131-10/+8
| | | | | | it actually appears the hacks to block SIGPIPE are probably not necessary, and potentially harmful. if i can confirm this, i'll remove them.
* numerous fixes to sysv ipcRich Felker2011-04-133-5/+5
| | | | | | | | | | some of these definitions were just plain wrong, others based on outdated ancient "non-64" versions of the kernel interface. as much as possible has now been moved out of bits/* these changes break abi (the old abi for these functions was wrong), but since they were not working anyway it can hardly matter.
* add syscall wrapper for flockRich Felker2011-04-131-0/+7
| | | | | | | | it should be noted that flock does not mix well with standard fcntl locking, but nonetheless some applications will attempt to use flock instead of fcntl if both exist. options to configure or small patches may be needed. debian maintainers have plenty of experience with this unfortunate situation...
* fix bug whereby getopt_long allowed mismatch in last char of option nameRich Felker2011-04-131-1/+1
|
* implement getgrouplist (for initgroups), formerly dummied-out v0.7.8Rich Felker2011-04-131-4/+16
|
* fix prototypes/signature for setgroups, etc.Rich Felker2011-04-131-1/+1
|
* implement memrchr (nonstandard) and optimize strrchr in terms of itRich Felker2011-04-132-4/+15
|