about summary refs log tree commit diff
path: root/src/stdio
Commit message (Collapse)AuthorAgeFilesLines
* fix %ls breakage in last printf fixRich Felker2012-06-081-2/+2
| | | | signedness issue kept %ls with no precision from working at all
* fix printf %ls with precision limit over-read issueRich Felker2012-06-081-2/+2
| | | | | | | printf was not printing too many characters, but it was reading one too many wchar_t elements from the input. this could lead to crashes if running off the page, or spurious failure if the conversion of the extra wchar_t resulted in EILSEQ.
* fix scanf bug reading literals after width-limited fieldRich Felker2012-06-071-0/+1
| | | | | | the field width limit was not being cleared before reading the literal, causing spurious failures in scanf in cases like "%2d:" scanning "00:".
* add some ugly aliases for LSB ABI compatibilityRich Felker2012-06-027-0/+8
| | | | | | for some nonsensical reason, glibc's headers use inline functions that redirect some of the standard functions to ugly nonstandard names (and likewise for some of their nonstandard functions).
* avoid using pthread cleanup push/pop in stdio when not neededRich Felker2012-05-252-6/+14
| | | | | | | | | | | | unfortunately in dynamic-linked programs, these macros cause pthread_self to be initialized, which costs a couple syscalls, and (much worse) would necessarily fail, crash, and burn on ancient (2.4 and earlier) kernels where setting up a thread pointer does not work. i'd like to do this in a more generic way that avoids all use of cleanup push/pop before pthread_self has been successfully called and avoids ugly if/else constructs like the one in this commit, but for now, this will suffice.
* fix uninitialized var in vfwprintf printing 0-prec stringRich Felker2012-05-041-1/+1
| | | | this could lead to spurious failures of wide printf functions
* fix really bad breakage in strtol, etc.: failure to accept leading spacesRich Felker2012-04-191-1/+1
|
* fix wide scanf's handling of input failure on %c, and simplify %[Rich Felker2012-04-171-5/+6
|
* fix failure to distinguish input/match failure in wide %[ scanfRich Felker2012-04-172-2/+4
| | | | | this also includes a related fix for vswscanf's read function, which was returning a spurious (uninitialized) character for empty strings.
* fix over-read in %ls with non-wide scanfRich Felker2012-04-171-0/+1
|
* fix broken %s and %[ with no width specifier in wide scanfRich Felker2012-04-171-3/+7
|
* make wide scanf %[ respect widthRich Felker2012-04-171-2/+3
|
* fix wide scanf to respect field width for stringsRich Felker2012-04-171-4/+7
|
* fix some bugs in scanf %[ handling detected while writing the wide versionRich Felker2012-04-171-4/+4
|
* introduce new wide scanf code and remove the last remnants of old scanfRich Felker2012-04-174-524/+312
| | | | | | | | | at this point, strto* and all scanf family functions are using the new unified integer and floating point parser/converter code. the wide scanf is largely a wrapper for ordinary byte-based scanf; since numbers can only contain ascii characters, only strings need to be handled specially.
* avoid depending on POSIX symbol in code used from plain C functionsRich Felker2012-04-171-1/+3
|
* avoid null pointer dereference on %*p fields in scanfRich Felker2012-04-171-1/+1
|
* also ensure that write buffer is bounded when __stdio_write returnsRich Felker2012-04-171-0/+1
| | | | | assuming other code is correct, this should be a no-op, but better to be safe...
* fix buffer overflow in vfprintf on long writes to unbuffered filesRich Felker2012-04-171-1/+2
| | | | | | | | | | | | | | | | | | vfprintf temporarily swaps in a local buffer (for the duration of the operation) when the target stream is unbuffered; this both simplifies the implementation of functions like dprintf (they don't need their own buffers) and eliminates the pathologically bad performance of writing the formatted output with one or more write syscalls per formatting field. in cases like dprintf where we are dealing with a virgin FILE structure, everything worked correctly. however for long-lived files (like stderr), it's possible that the buffer bounds were already set for the internal zero-size buffer. on the next write, __stdio_write would pick up and use the new buffer provided by vfprintf, but the bound (wend) field was still pointing at the internal zero-size buffer's end. this in turn allowed unbounded writes to the temporary buffer.
* fix %lf, etc. with printfRich Felker2012-04-161-0/+2
| | | | | | the l prefix is redundant/no-op with printf, since default promotions always promote floats to double; however, it is valid, and printf was wrongly rejecting it.
* new scanf implementation and corresponding integer parser/converterRich Felker2012-04-163-30/+343
| | | | | | | | | | | | | | | advantages over the old code: - correct results for floating point (old code was bogus) - wide/regular scanf separated so scanf does not pull in wide code - well-defined behavior on integers that overflow dest type - support for %[a-b] ranges with %[ (impl-defined by widely used) - no intermediate conversion of fmt string to wide string - cleaner, easier to share code with strto* functions - better standards conformance for corner cases the old code remains in the source tree, as the wide versions of the scanf-family functions are still using it. it will be removed when no longer needed.
* fix scanf handling of "0" (followed by immediate EOF) with "%x"Rich Felker2012-03-131-11/+6
| | | | | | | | other cases with %x were probably broken too. I would actually like to go ahead and replace this code in scanf with calls to the new __intparse framework, but for now this calls for a quick and unobtrusive fix without the risk of breaking other things.
* make stdio open, read, and write operations cancellation pointsRich Felker2012-02-023-5/+28
| | | | | | | | | | it should be noted that only the actual underlying buffer flush and fill operations are cancellable, not reads from or writes to the buffer. this behavior is compatible with POSIX, which makes all cancellation points in stdio optional, and it achieves the goal of allowing cancellation of a thread that's "stuck" on IO (due to a non-responsive socket/pipe peer, slow/stuck hardware, etc.) without imposing any measurable performance cost.
* simplify atexit and fflush-on-exit handlingRich Felker2011-10-141-1/+4
|
* don't crash on null strings in printfRich Felker2011-09-281-1/+1
| | | | passing null pointer for %s is UB but lots of broken programs do it anyway
* avoid setting FILE lock count when not using flockfileRich Felker2011-09-211-1/+1
| | | | | | | for now this is just a tiny optimization, but later if we support cancellation from __stdio_read and __stdio_write, it will be necessary for the recusrive lock count to be zero in order for these functions to know they are responsible for unlocking the FILE on cancellation.
* more fmemopen null termination fixesRich Felker2011-09-041-2/+3
| | | | | | | | null termination is only added when current size grows. in update modes, null termination is not added if it does not fit (i.e. it is not allowed to clobber data). these rules make very little sense, but that's how it goes..
* fix some fmemopen behaviorsRich Felker2011-09-041-4/+7
| | | | | | read should not be allowed past "current size". append mode should write at "current size", not buffer size. null termination should not be written except when "current size" grows.
* fmemopen: fix eof handling, hopefully right this timeRich Felker2011-09-041-3/+4
|
* fmemopen fixesRich Felker2011-09-041-1/+3
| | | | | | disallow seek past end of buffer (per posix) fix position accounting to include data buffered for read don't set eof flag when no data was requested
* memstreams: fix incorrect handling of file pos > current sizeRich Felker2011-09-042-4/+4
| | | | | the addition is safe and cannot overflow because both operands are positive when considered as signed quantities.
* optimize seek function for memory streamsRich Felker2011-09-042-24/+6
|
* fix twos complement overflow bug in mem streams boundary checkRich Felker2011-09-042-2/+2
| | | | | | the expression -off is not safe in case off is the most-negative value. instead apply - to base which is known to be non-negative and bounded within sanity.
* implement fmemopenRich Felker2011-09-031-18/+66
| | | | testing so far has been minimal. may need further work.
* fix some length calculations in memory streamsRich Felker2011-09-032-3/+3
|
* implement open_wmemstreamRich Felker2011-09-031-0/+95
| | | | | | not heavily tested, but it seems to be correct, including the odd behavior that seeking is in terms of wide character count. this precludes any simple buffering, so we just make the stream unbuffered.
* implement open_memstreamRich Felker2011-09-031-0/+94
| | | | | this is the first attempt, and may have bugs. only minimal testing has been performed.
* fix crash in dns code with new stdio locking codeRich Felker2011-08-011-0/+1
|
* add proper fuxed-based locking for stdioRich Felker2011-07-3014-39/+44
| | | | | | | | | | | | | | | | | | | | | | previously, stdio used spinlocks, which would be unacceptable if we ever add support for thread priorities, and which yielded pathologically bad performance if an application attempted to use flockfile on a key file as a major/primary locking mechanism. i had held off on making this change for fear that it would hurt performance in the non-threaded case, but actually support for recursive locking had already inflicted that cost. by having the internal locking functions store a flag indicating whether they need to perform unlocking, rather than using the actual recursive lock counter, i was able to combine the conditionals at unlock time, eliminating any additional cost, and also avoid a nasty corner case where a huge number of calls to ftrylockfile could cause deadlock later at the point of internal locking. this commit also fixes some issues with usage of pthread_self conflicting with __attribute__((const)) which resulted in crashes with some compiler versions/optimizations, mainly in flockfile prior to pthread_create.
* eliminate dependence of perror on printfRich Felker2011-07-301-10/+5
|
* fix logic error in freadRich Felker2011-07-161-6/+1
| | | | | | | | fread was calling f->read without checking that the file was in reading mode. this could: 1. crash, if f->read was a null pointer 2. cause unwanted blocking on a terminal already at eof 3. allow reading on a write-only file
* printf: "if a precision is specified, the '0' flag shall be ignored."Rich Felker2011-07-041-1/+1
|
* zero precision with zero value should not inhibit prefix/width printingRich Felker2011-07-041-1/+4
|
* printf("%#x",0) should print 0 not 0x0Rich Felker2011-07-041-1/+1
|
* fix logic in __fwritingRich Felker2011-06-301-1/+1
|
* add and consolidate nasty stdio_ext junkRich Felker2011-06-303-17/+57
| | | | | hopefully this resolves the rest of the issues with hideously nonportable hacks in programs that use gnulib.
* implement the nonstandard GNU function fpurgeRich Felker2011-06-301-0/+11
| | | | | | this is a really ugly and backwards function, but its presence will prevent lots of broken gnulib software from trying to define its own version of fpurge and thereby failing to build or worse.
* avoid 64bit warnings when using pointers as entropy for temp namesRich Felker2011-06-132-2/+4
|
* fix the last known rounding bug in floating point printingRich Felker2011-05-111-3/+4
| | | | | | | | | the observed symptom was that the code was incorrectly rounding up 1.0625 to 1.063 despite the rounding mode being round-to-nearest with ties broken by rounding to even last place. however, the code was just not right in many respects, and i'm surprised it worked as well as it did. this time i tested the values that end up in the variables round, small, and the expression round+small, and all look good.
* reduce some ridiculously large spin countsRich Felker2011-05-061-1/+1
| | | | | | these should be tweaked according to testing. offhand i know 1000 is too low and 5000 is likely to be sufficiently high. consider trying to add futexes to file locking, too...