about summary refs log tree commit diff
path: root/src/stdio
Commit message (Collapse)AuthorAgeFilesLines
* introduce new wide scanf code and remove the last remnants of old scanfRich Felker2012-04-174-524/+312
| | | | | | | | | at this point, strto* and all scanf family functions are using the new unified integer and floating point parser/converter code. the wide scanf is largely a wrapper for ordinary byte-based scanf; since numbers can only contain ascii characters, only strings need to be handled specially.
* avoid depending on POSIX symbol in code used from plain C functionsRich Felker2012-04-171-1/+3
|
* avoid null pointer dereference on %*p fields in scanfRich Felker2012-04-171-1/+1
|
* also ensure that write buffer is bounded when __stdio_write returnsRich Felker2012-04-171-0/+1
| | | | | assuming other code is correct, this should be a no-op, but better to be safe...
* fix buffer overflow in vfprintf on long writes to unbuffered filesRich Felker2012-04-171-1/+2
| | | | | | | | | | | | | | | | | | vfprintf temporarily swaps in a local buffer (for the duration of the operation) when the target stream is unbuffered; this both simplifies the implementation of functions like dprintf (they don't need their own buffers) and eliminates the pathologically bad performance of writing the formatted output with one or more write syscalls per formatting field. in cases like dprintf where we are dealing with a virgin FILE structure, everything worked correctly. however for long-lived files (like stderr), it's possible that the buffer bounds were already set for the internal zero-size buffer. on the next write, __stdio_write would pick up and use the new buffer provided by vfprintf, but the bound (wend) field was still pointing at the internal zero-size buffer's end. this in turn allowed unbounded writes to the temporary buffer.
* fix %lf, etc. with printfRich Felker2012-04-161-0/+2
| | | | | | the l prefix is redundant/no-op with printf, since default promotions always promote floats to double; however, it is valid, and printf was wrongly rejecting it.
* new scanf implementation and corresponding integer parser/converterRich Felker2012-04-163-30/+343
| | | | | | | | | | | | | | | advantages over the old code: - correct results for floating point (old code was bogus) - wide/regular scanf separated so scanf does not pull in wide code - well-defined behavior on integers that overflow dest type - support for %[a-b] ranges with %[ (impl-defined by widely used) - no intermediate conversion of fmt string to wide string - cleaner, easier to share code with strto* functions - better standards conformance for corner cases the old code remains in the source tree, as the wide versions of the scanf-family functions are still using it. it will be removed when no longer needed.
* fix scanf handling of "0" (followed by immediate EOF) with "%x"Rich Felker2012-03-131-11/+6
| | | | | | | | other cases with %x were probably broken too. I would actually like to go ahead and replace this code in scanf with calls to the new __intparse framework, but for now this calls for a quick and unobtrusive fix without the risk of breaking other things.
* make stdio open, read, and write operations cancellation pointsRich Felker2012-02-023-5/+28
| | | | | | | | | | it should be noted that only the actual underlying buffer flush and fill operations are cancellable, not reads from or writes to the buffer. this behavior is compatible with POSIX, which makes all cancellation points in stdio optional, and it achieves the goal of allowing cancellation of a thread that's "stuck" on IO (due to a non-responsive socket/pipe peer, slow/stuck hardware, etc.) without imposing any measurable performance cost.
* simplify atexit and fflush-on-exit handlingRich Felker2011-10-141-1/+4
|
* don't crash on null strings in printfRich Felker2011-09-281-1/+1
| | | | passing null pointer for %s is UB but lots of broken programs do it anyway
* avoid setting FILE lock count when not using flockfileRich Felker2011-09-211-1/+1
| | | | | | | for now this is just a tiny optimization, but later if we support cancellation from __stdio_read and __stdio_write, it will be necessary for the recusrive lock count to be zero in order for these functions to know they are responsible for unlocking the FILE on cancellation.
* more fmemopen null termination fixesRich Felker2011-09-041-2/+3
| | | | | | | | null termination is only added when current size grows. in update modes, null termination is not added if it does not fit (i.e. it is not allowed to clobber data). these rules make very little sense, but that's how it goes..
* fix some fmemopen behaviorsRich Felker2011-09-041-4/+7
| | | | | | read should not be allowed past "current size". append mode should write at "current size", not buffer size. null termination should not be written except when "current size" grows.
* fmemopen: fix eof handling, hopefully right this timeRich Felker2011-09-041-3/+4
|
* fmemopen fixesRich Felker2011-09-041-1/+3
| | | | | | disallow seek past end of buffer (per posix) fix position accounting to include data buffered for read don't set eof flag when no data was requested
* memstreams: fix incorrect handling of file pos > current sizeRich Felker2011-09-042-4/+4
| | | | | the addition is safe and cannot overflow because both operands are positive when considered as signed quantities.
* optimize seek function for memory streamsRich Felker2011-09-042-24/+6
|
* fix twos complement overflow bug in mem streams boundary checkRich Felker2011-09-042-2/+2
| | | | | | the expression -off is not safe in case off is the most-negative value. instead apply - to base which is known to be non-negative and bounded within sanity.
* implement fmemopenRich Felker2011-09-031-18/+66
| | | | testing so far has been minimal. may need further work.
* fix some length calculations in memory streamsRich Felker2011-09-032-3/+3
|
* implement open_wmemstreamRich Felker2011-09-031-0/+95
| | | | | | not heavily tested, but it seems to be correct, including the odd behavior that seeking is in terms of wide character count. this precludes any simple buffering, so we just make the stream unbuffered.
* implement open_memstreamRich Felker2011-09-031-0/+94
| | | | | this is the first attempt, and may have bugs. only minimal testing has been performed.
* fix crash in dns code with new stdio locking codeRich Felker2011-08-011-0/+1
|
* add proper fuxed-based locking for stdioRich Felker2011-07-3014-39/+44
| | | | | | | | | | | | | | | | | | | | | | previously, stdio used spinlocks, which would be unacceptable if we ever add support for thread priorities, and which yielded pathologically bad performance if an application attempted to use flockfile on a key file as a major/primary locking mechanism. i had held off on making this change for fear that it would hurt performance in the non-threaded case, but actually support for recursive locking had already inflicted that cost. by having the internal locking functions store a flag indicating whether they need to perform unlocking, rather than using the actual recursive lock counter, i was able to combine the conditionals at unlock time, eliminating any additional cost, and also avoid a nasty corner case where a huge number of calls to ftrylockfile could cause deadlock later at the point of internal locking. this commit also fixes some issues with usage of pthread_self conflicting with __attribute__((const)) which resulted in crashes with some compiler versions/optimizations, mainly in flockfile prior to pthread_create.
* eliminate dependence of perror on printfRich Felker2011-07-301-10/+5
|
* fix logic error in freadRich Felker2011-07-161-6/+1
| | | | | | | | fread was calling f->read without checking that the file was in reading mode. this could: 1. crash, if f->read was a null pointer 2. cause unwanted blocking on a terminal already at eof 3. allow reading on a write-only file
* printf: "if a precision is specified, the '0' flag shall be ignored."Rich Felker2011-07-041-1/+1
|
* zero precision with zero value should not inhibit prefix/width printingRich Felker2011-07-041-1/+4
|
* printf("%#x",0) should print 0 not 0x0Rich Felker2011-07-041-1/+1
|
* fix logic in __fwritingRich Felker2011-06-301-1/+1
|
* add and consolidate nasty stdio_ext junkRich Felker2011-06-303-17/+57
| | | | | hopefully this resolves the rest of the issues with hideously nonportable hacks in programs that use gnulib.
* implement the nonstandard GNU function fpurgeRich Felker2011-06-301-0/+11
| | | | | | this is a really ugly and backwards function, but its presence will prevent lots of broken gnulib software from trying to define its own version of fpurge and thereby failing to build or worse.
* avoid 64bit warnings when using pointers as entropy for temp namesRich Felker2011-06-132-2/+4
|
* fix the last known rounding bug in floating point printingRich Felker2011-05-111-3/+4
| | | | | | | | | the observed symptom was that the code was incorrectly rounding up 1.0625 to 1.063 despite the rounding mode being round-to-nearest with ties broken by rounding to even last place. however, the code was just not right in many respects, and i'm surprised it worked as well as it did. this time i tested the values that end up in the variables round, small, and the expression round+small, and all look good.
* reduce some ridiculously large spin countsRich Felker2011-05-061-1/+1
| | | | | | these should be tweaked according to testing. offhand i know 1000 is too low and 5000 is likely to be sufficiently high. consider trying to add futexes to file locking, too...
* fix fclose return status logic, againRich Felker2011-05-021-1/+2
| | | | | | | | the previous fix was incorrect, as it would prevent f->close(f) from being called if fflush(f) failed. i believe this was the original motivation for using | rather than ||. so now let's just use a second statement to constrain the order of function calls, and to back to using |.
* fix undefined call order in fclose, possible lost output depending on compilerRich Felker2011-05-011-1/+1
| | | | | pcc turned up this bug by calling f->close(f) before fflush(f), resulting in lost output and error on flush.
* minor optimization in puts: use inline putc_unlocked macro for newlineRich Felker2011-05-011-1/+1
|
* fix 2 eof-related bugs in scanfRich Felker2011-04-251-3/+4
| | | | | | | | | 1. failed match of literal chars from the format string would always return matching failure rather than input failure at eof, leading to infinite loops in some programs. 2. unread of eof would wrongly adjust the character counts reported by %n, yielding an off-by-one error.
* clean up handling of thread/nothread mode, lockingRich Felker2011-04-172-5/+1
|
* debloat: use __syscall instead of syscall where possibleRich Felker2011-04-174-5/+5
| | | | | | don't waste time (and significant code size due to function call overhead!) setting errno when the result of a syscall does not matter or when it can't fail.
* avoid setting errno when checking for ttyRich Felker2011-04-152-2/+2
| | | | | | | setting errno here is completely valid, but some programs, notably busybox printf, assume that errno will not be set during output and treat this as an error condition. in any case, skipping it slightly reduces code size and saves time.
* make tmpfile slightly more efficient (use unlink syscall instead of remove)Rich Felker2011-04-141-1/+1
|
* fix printf("%.9g", 1.1) and similar not dropping trailing zerosRich Felker2011-04-121-1/+3
|
* fix fputwc return valueRich Felker2011-04-111-1/+1
|
* work around a nasty bug in linux readv syscallRich Felker2011-04-091-3/+4
| | | | | | | | | | | | | | | | according to posix, readv "shall be equivalent to read(), except..." that it places the data into the buffers specified by the iov array. however on linux, when reading from a terminal, each iov element behaves almost like a separate read. this means that if the first iov exactly satisfied the request (e.g. a length-one read of '\n') and the second iov is nonzero length, the syscall will block again after getting the blank line from the terminal until another line is read. simply put, entering a single blank line becomes impossible. the solution, fortunately, is simple. whenever the buffer size is nonzero, reduce the length of the requested read by one byte and let the last byte go through the buffer. this way, readv will already be in the second (and last) iov, and won't re-block on the second iov.
* add more legacy functions: setlinebuf and setbufferRich Felker2011-04-053-1/+15
|
* fix overflow in printf %N$ argument handlingRich Felker2011-04-051-2/+2
|
* fix various floating point rounding and formatting errors in *printfRich Felker2011-04-051-17/+25
|