about summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* fix buffer overflow in vfprintf on long writes to unbuffered filesRich Felker2012-04-171-1/+2
| | | | | | | | | | | | | | | | | | vfprintf temporarily swaps in a local buffer (for the duration of the operation) when the target stream is unbuffered; this both simplifies the implementation of functions like dprintf (they don't need their own buffers) and eliminates the pathologically bad performance of writing the formatted output with one or more write syscalls per formatting field. in cases like dprintf where we are dealing with a virgin FILE structure, everything worked correctly. however for long-lived files (like stderr), it's possible that the buffer bounds were already set for the internal zero-size buffer. on the next write, __stdio_write would pick up and use the new buffer provided by vfprintf, but the bound (wend) field was still pointing at the internal zero-size buffer's end. this in turn allowed unbounded writes to the temporary buffer.
* fix %lf, etc. with printfRich Felker2012-04-161-0/+2
| | | | | | the l prefix is redundant/no-op with printf, since default promotions always promote floats to double; however, it is valid, and printf was wrongly rejecting it.
* better description for errno==0Rich Felker2012-04-161-1/+1
|
* implement wcstod and familyRich Felker2012-04-161-0/+61
| | | | not heavily tested but these functions appear to work correctly
* avoid hitting eof in wcstolRich Felker2012-04-161-2/+3
| | | | | | | | | | shunget cannot unget eof status, causing wcstol to leave endptr pointing to the wrong place when scanning, for example, L"0x". cheap fix is to make the read function provide an infinite stream of bogus characters rather than eof. really this is something of a design flaw in how the shgetc system is used for strto* and wcsto*; in the long term, I believe multi-character unget should be scrapped and replaced with a function that can subtract from the f->shcnt counter.
* use the new integer parser (FILE/shgetc based) for strtol, wcstol, etc.Rich Felker2012-04-1614-405/+120
|
* new scanf implementation and corresponding integer parser/converterRich Felker2012-04-166-30/+450
| | | | | | | | | | | | | | | advantages over the old code: - correct results for floating point (old code was bogus) - wide/regular scanf separated so scanf does not pull in wide code - well-defined behavior on integers that overflow dest type - support for %[a-b] ranges with %[ (impl-defined by widely used) - no intermediate conversion of fmt string to wide string - cleaner, easier to share code with strto* functions - better standards conformance for corner cases the old code remains in the source tree, as the wide versions of the scanf-family functions are still using it. it will be removed when no longer needed.
* fix buggy limiter handling in shgetcRich Felker2012-04-161-4/+3
| | | | this is needed for upcoming new scanf
* wordexp must set the we_offs entries of we_wordv to null pointersRich Felker2012-04-161-0/+4
|
* fix crash in wordfree if we_offs is not initialized by the callerRich Felker2012-04-161-0/+2
| | | | | | | I'm not sure if it's legal for wordexp to modify this field, but this is the only easy/straightforward fix, and applications should not care. if it's an issue, i can work out a different (but more complex) solution later.
* fix broken shgetc limiter logic (wasn't working)Rich Felker2012-04-162-2/+5
|
* floatscan: fix incorrect count of leading nonzero digitsRich Felker2012-04-161-1/+1
| | | | | | | this off-by-one error was causing values with just one digit past the decimal point to be treated by the integer case. in many cases it would yield the correct result, but if expressions are evaluated in excess precision, double rounding may occur.
* move F_DUPFD_CLOEXEC out of bitsRich Felker2012-04-154-6/+2
| | | | | | fcntl values 1024 and up are universal, arch-independent. later I'll add some of the other linux-specific ones for notify, leases, pipe size, etc. here too.
* add F_SETSIG and F_GETSIG (linux specific) to fcntl.hRich Felker2012-04-153-0/+6
| | | | F_* is in the reserved namespace so no feature test is needed
* fix signedness error handling invalid multibyte sequences in regexecRich Felker2012-04-141-2/+2
| | | | | | | the "< 0" test was always false due to use of an unsigned type. this resulted in infinite loops on 32-bit machines (adding -1U to a pointer is the same as adding -1) and crashes on 64-bit machines (offsetting the string pointer by 4gb-1b when an illegal sequence was hit).
* rename __sa_restorer to sa_restorer in struct sigactionRich Felker2012-04-131-1/+1
| | | | | | | | | this is legal since sa_* is in the reserved namespace for signal.h, per posix. note that the sa_restorer field is not used anywhere, so programs that are trying to use it may still break, but at least they'll compile. if it turns out such programs actually need to be able to set their own sa_restorer to function properly, i'll add the necessary code to sigaction.c later.
* remove invalid code from TRERich Felker2012-04-131-14/+0
| | | | | | | | | | | TRE wants to treat + and ? after a +, ?, or * as special; ? means ungreedy and + is reserved for future use. however, this is non-conformant. although redundant, these redundant characters have well-defined (no-op) meaning for POSIX ERE, and are actually _literal_ characters (which TRE is wrongly ignoring) in POSIX BRE mode. the simplest fix is to simply remove the unneeded nonstandard functionality. as a plus, this shaves off a small amount of bloat.
* fix broken regerror (typo) and missing messageRich Felker2012-04-131-2/+2
|
* use fast version of the int reading code for the high-order digits tooRich Felker2012-04-131-3/+13
| | | | | this increases code size slightly, but it's considerably faster, especially for power-of-2 bases.
* use macros instead of inline functions in shgetc.hRich Felker2012-04-131-20/+4
| | | | | | at -Os optimization level, gcc refuses to inline these functions even though the inlined code would roughly the same size as the function call, and much faster. the easy solution is to make them into macros.
* fix spurious overflows in strtoull with small basesRich Felker2012-04-131-7/+3
| | | | | | | whenever the base was small enough that more than one digit could still fit after UINTMAX_MAX/36-1 was reached, only the first would be allowed; subsequent digits would trigger spurious overflow, making it impossible to read the largest values in low bases.
* remove magic numbers from floatscanRich Felker2012-04-121-5/+5
|
* optimize more integer cases in floatscan; comment the whole procedureRich Felker2012-04-121-8/+27
|
* revert invalid optimization in floatscanRich Felker2012-04-111-2/+2
|
* fix stupid typo in floatscan that caused excess rounding of some valuesRich Felker2012-04-111-1/+1
|
* add some more useful suggested options to config.mak templateRich Felker2012-04-111-0/+6
|
* Merge remote branch 'nsz/master'Rich Felker2012-04-112-5/+6
|\
| * math: fix x86 asin accuracynsz2012-04-042-5/+6
| | | | | | | | | | use (1-x)*(1+x) instead of (1-x*x) in asin.s the later can be inaccurate with upward rounding when x is close to 1
* | optimize floatscan downscaler to skip results that won't be neededRich Felker2012-04-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | when upscaling, even the very last digit is needed in cases where the input is exact; no digits can be discarded. but when downscaling, any digits less significant than the mantissa bits are destined for the great bitbucket; the only influence they can have is their presence (being nonzero). thus, we simply throw them away early. the result is nearly a 4x performance improvement for processing huge values. the particular threshold LD_B1B_DIG+3 is not chosen sharply; it's simply a "safe" distance past the significant bits. it would be nice to replace it with a sharp bound, but i suspect performance will be comparable (within a few percent) anyway.
* | simplify/debloat radix point alignment code in floatscanRich Felker2012-04-111-9/+4
| | | | | | | | | | | | | | | | | | | | | | | | now that this is the first operation, it can rely on the circular buffer contents not being wrapped when it begins. we limit the number of digits read slightly in the initial parsing loops too so that this code does not have to consider the case where it might cause the circular buffer to wrap; this is perfectly fine because KMAX is chosen as a power of two for circular-buffer purposes and is much larger than it otherwise needs to be, anyway. these changes should not affect performance at all.
* | optimize floatscan: avoid excessive upscalingRich Felker2012-04-111-27/+27
| | | | | | | | | | | | | | | | | | | | upscaling by even one step too much creates 3-29 extra iterations for the next loop. this is still suboptimal since it always goes by 2^29 rather than using a smaller upscale factor when nearing the target, but performance on common, small-magnitude, few-digit values has already more than doubled with this change. more optimizations on the way...
* | fix incorrect initial count in shgetc when data is already bufferedRich Felker2012-04-111-1/+1
| |
* | fix bug parsing lone zero followed by junk, and hex float over-readingRich Felker2012-04-111-6/+5
| |
* | fix float scanning of certain values ending in zerosRich Felker2012-04-101-1/+3
| | | | | | | | | | | | | | for example, "1000000000" was being read as "1" due to this loop exiting early. it's necessary to actually update z and zero the entries so that the subsequent rounding code does not get confused; before i did that, spurious inexact exceptions were being raised.
* | fix potential overflow in exponent readingRich Felker2012-04-101-1/+1
| | | | | | | | | | | | | | note that there's no need for a precise cutoff, because exponents this large will always result in overflow or underflow (it's impossible to read enough digits to compensate for the exponent magnitude; even at a few nanoseconds per digit it would take hundreds of years).
* | set errno properly when parsing floating pointRich Felker2012-04-101-4/+21
| |
* | add "scan helper getc" and rework strtod, etc. to use itRich Felker2012-04-106-75/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the immediate benefit is a significant debloating of the float parsing code by moving the responsibility for keeping track of the number of characters read to a different module. by linking shgetc with the stdio buffer logic, counting logic is defered to buffer refill time, keeping the calls to shgetc fast and light. in the future, shgetc will also be useful for integrating the new float code with scanf, which needs to not only count the characters consumed, but also limit the number of characters read based on field width specifiers. shgetc may also become a useful tool for simplifying the integer parsing code.
* | unify strtof/strtod/strtold wrappers and fix initial whitespace issueRich Felker2012-04-103-34/+21
| |
* | new floating point parser/converterRich Felker2012-04-105-94/+477
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this version is intended to be fully conformant to the ISO C, POSIX, and IEEE standards for conversion of decimal/hex floating point strings to float, double, and long double (ld64 or ld80 only at present) values. in particular, all results are intended to be rounded correctly according to the current rounding mode. further, this implementation aims to set the floating point underflow, overflow, and inexact flags to reflect the conversion performed. a moderate amount of testing has been performed (by nsz and myself) prior to integration of the code in musl, but it still may have bugs. so far, only strto(d|ld|f) use the new code. scanf integration will be done as a separate commit, and i will add implementations of the wide character functions later.
* | fix alloca issue in stdlib.h tooRich Felker2012-04-091-1/+1
| | | | | | | | I forgot _GNU_SOURCE also has it declared here...
* | alloca cannot be a function. #define it to the gcc builtin if possibleRich Felker2012-04-091-0/+4
|/ | | | | | | | gcc makes this mapping by default anyway, but it will be disabled by -fno-builtin (and presumably by -std=c99 or similar). for the main program the error will be reported by the linker, and the issue can easily be fixed, but for dynamic-loaded so files, the error cannot be detected until dlopen time, at which point it has become very obscure.
* work around nasty gcc bug in the i386 syscall asmRich Felker2012-04-041-4/+4
| | | | | | | | | | | | | | | | | | | | | when the "r" (register) constraint is used to let gcc choose a register, gcc will sometimes assign the same register that was used for one of the other fixed-register operands, if it knows the values are the same. one common case is multiple zero arguments to a syscall. this horribly breaks the intended usage, which is swapping the GOT pointer from ebx into the temp register and back to perform the syscall. presumably there is a way to fix this with advanced usage of register constaints on the inline asm, but having bad memories about hellish compatibility issues with different gcc versions, for the time being i'm just going to hard-code specific registers to be used. this may hurt the compiler's ability to optimize, but it will fix serious miscompilation issues. so far the only function i know what compiled incorrectly is getrlimit.c, and naturally the bug only applies to shared (PIC) builds, but it may be more extensive and may have gone undetected..
* remove useless (at best, harmful) feature test checks in aio.hRich Felker2012-04-031-5/+0
|
* improve name lookup performance in corner casesRich Felker2012-04-012-2/+2
| | | | | | | | | | | the buffer in getaddrinfo really only matters when /etc/hosts is huge, but in that case, the huge number of syscalls resulting from a tiny buffer would seriously impact the performance of every name lookup. the buffer in __dns.c has also been enlarged a bit so that typical resolv.conf files will fit fully in the buffer. there's no need to make it so large as to dominate the syscall overhead for large files, because resolv.conf should never be large.
* optimize signbit macroRich Felker2012-03-301-2/+2
|
* make math.h more c++-friendlyRich Felker2012-03-301-2/+5
|
* math: minor cleanups in ceil and floornsz2012-03-295-10/+7
|
* math: remove x86 modf asmnsz2012-03-294-111/+0
| | | | | the int part was wrong when -1 < x <= -0 (+0.0 instead of -0.0) and the size and performace gain of the asm version was negligible
* math: rewrite modf.c and clean up modff.cnsz2012-03-292-72/+45
| | | | cleaner implementation with unions and unsigned arithmetic
* math: fix modfl.c bugnsz2012-03-281-1/+1
| | | | | modfl(+-inf) was wrong on ld80 because the explicit msb was not taken into account during inf vs nan check