about summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* fix return value for fread/fwrite when size argument is 0Rich Felker2016-02-102-0/+2
| | | | | | | when the size argument was zero but nmemb was nonzero, these functions were returning nmemb, despite no data having been written. conceptually this is not wrong, but the standard requires a return value of zero in this case.
* fix line-buffered flush omission for odd usage of putc-family functionsRich Felker2016-02-101-1/+2
| | | | | | | | | as specified, the int argument providing the character to write is converted to type unsigned char. for the actual write to buffer, conversion happened implicitly via the assignment operator; however, the logic to check whether the argument was a newline used the original int value. thus usage such as putchar('\n'+0x100) failed to produce a flush.
* fix failed write reporting by fwrite in line-buffered modeRich Felker2016-02-101-2/+2
| | | | | | | | | | | | when a write error occurred while flushing output due to a newline, fwrite falsely reported all bytes up to and including the newline as successfully written. in general, due to buffering such "spurious success" returns are acceptable for stdio; however for line-buffered mode it was subtly wrong. errors were still visible via ferror() or as a short-write return if there was more data past the newline that should have been written, but since the contract for line-buffered mode is that everything up through the newline be written out immediately, a discrepency was observable in the actual file contents.
* remove workaround for broken mips assemblersRich Felker2016-02-082-9/+2
| | | | | | | | | | | | | | | | | | | | the workaround was for a bug that botched .gpword references to local labels, applying a nonsensical random offset of -0x4000 to them. this reverses commit 5e396fb996a80b035d0f6ecf7fed50f68aa3ebb7 and a removes a similar hack that was added to syscall_cp.s in the later commit 756c8af8589265e99e454fe3adcda1d0bc5e1963. it turns out one additional instance of the same idiom, the GETFUNCSYM macro in arch/mips/reloc.h, was still affected by the assembler bug and does not admit an easy workaround without making assumptions about how the macro is used. the previous workarounds made static linking work but left the early-stage dynamic linker broken and thus had limited usefulness. instead, affected users (using binutils versions older than 2.20) will need to fix the bug on the binutils side; the trivial patch is commit 453f5985b13e35161984bf1bf657bbab11515aa4 in the binutils-gdb repository.
* in mips cancellable syscall asm, don't assume gp register is validRich Felker2016-02-041-2/+13
| | | | | | | | | | the old __cp_cancel code path loaded the address of __cancel from the GOT using the $gp register, which happened to be set to point to the correct GOT by the calling C function, but there is no ABI requirement that this happen. instead, go the roundabout way and compute the address of __cancel via pc-relative and gp-relative addressing starting with a fake return address generated by a bal instruction, which is the same trick crt1 uses to bootstrap.
* avoid using signals when a thread attempts to cancel itselfRich Felker2016-02-041-0/+1
| | | | | not only is pthread_kill expensive in this case; it also breaks testing under qemu app-level emulation.
* make configure accept -h as an alias for --helpRich Felker2016-02-021-1/+1
|
* update INSTALL file with new archs, compiler infoRich Felker2016-02-021-28/+20
| | | | | | | | | | | | add aarch64 and or1k archs, upgrade sh from experimental, and note that sh now supports the FDPIC ABI. the old advice on compiler versions was outdated and more specific than made sense. presence of compiler bugs varies a lot by arch, so it's hard to make any good recommendations beyond "recent". if we want to document specific known-good/bad compiler versions, a much larger section in the documentation than what's appropriate for the INSTALL file would be needed.
* fix malloc_usable_size for NULL inputSzabolcs Nagy2016-01-311-1/+1
| | | | | | the linux man page specifies malloc_usable_size(0) to return 0 and this is the semantics other implementations follow (jemalloc). reported by Alexander Monakov.
* regex: increase the stack tre uses for tnfa creationSzabolcs Nagy2016-01-311-1/+1
| | | | | | | | | | | | | | 10k elements stack is increased to 1000k, otherwise tnfa creation fails for reasonable sized patterns: a single literal char can add 7 elements to this stack, so regcomp of an 1500 char long pattern (with only litral chars) fails with REG_ESPACE. (the new limit allows about < 150k chars, this arbitrary limit allows most command line regex usage.) ideally there would be no upper bound: regcomp dynamically reallocates this buffer, every reallocation checks for allocation failure and at the end this stack is freed so there is no reason for special bound. however that may have unwanted effect on regcomp and regexec runtime so this is a conservative change.
* better a_sc inline asm constraint on aarch64 and armSzabolcs Nagy2016-01-312-3/+3
| | | | | | | | | | "Q" input constraint was used for the written object, instead of "=Q" output constraint. this should not cause problems because "memory" is on the clobber list, but "=Q" better documents the intent and more consistent with the actual asm code. this changes the generated code, because different registers are used, but other than the register names nothing should change.
* don't suppress shared libc when linker lacks -Bsymbolic-functionsRich Felker2016-01-312-11/+5
| | | | | | | | | | | previous work overhauling the dynamic linker made it so that linking libc with -Bsymbolic-functions was no longer mandatory, but the configure logic that forced --disable-shared when ld failed to accept the option was left in place. this commit removes the hard-coded -Bsymbolic-functions from the Makefile and changes the configure test to one that simply adds it to the auto-detected LDFLAGS on success.
* ldso: fix GDB dynamic linker info on MIPSFelix Fietkau2016-01-303-5/+12
| | | | | | | GDB is looking for a pointer to the ldso debug info in the data of the ..rld_map section. Signed-off-by: Felix Fietkau <nbd@openwrt.org>
* regex: simplify the {,} repetition parsing logicSzabolcs Nagy2016-01-301-20/+19
|
* regex: treat \+, \? as repetitions in BRESzabolcs Nagy2016-01-301-1/+5
| | | | | These are undefined escape sequences by the standard, but often used in sed scripts.
* regex: rewrite the repetition parsing codeSzabolcs Nagy2016-01-301-30/+29
| | | | | The goto logic was hard to follow and modify. This is in preparation for the BRE \+ and \? support.
* regex: treat \| in BRE as alternationSzabolcs Nagy2016-01-301-2/+17
| | | | | | | | The standard does not define semantics for \| in BRE, but some code depends on it meaning alternation. Empty alternative expression is allowed to be consistent with ERE. Based on a patch by Rob Landley.
* regex: reject repetitions in some cases with REG_BADRPTSzabolcs Nagy2016-01-301-3/+12
| | | | | | | | | | | | | | | | | | Previously repetitions were accepted after empty expressions like in (*|?)|{2}, but in BRE the handling of * and \{\} were not consistent: they were accepted as literals in some cases and repetitions in others. It is better to treat repetitions after an empty expression as an error (this is allowed by the standard, and glibc mostly does the same). This is hard to do consistently with the current logic so the new rule is: Reject repetitions after empty expressions, except after assertions ^*, $? and empty groups ()+ and never treat them as literals. Empty alternation (|a) is undefined by the standard, but it can be useful so that should be accepted.
* regex: clean up position accounting for literal nodesSzabolcs Nagy2016-01-301-4/+2
| | | | | This should not change the meaning of the code, just make the intent clearer: advancing position is tied to adding a new literal.
* fix misaligned pointer-like objects in arm atomics asm source fileRich Felker2016-01-301-0/+2
| | | | | | | | this file's .data section was not aligned, and just happened to get the correct alignment with past builds. it's likely that the move of atomic.s from arch/arm/src to src/thread/arm caused the change in alignment, which broke the atomic and thread-pointer access fragments on actual armv5 hardware.
* fix regression in dynamic-linked tls when both main app & libs have tlsRich Felker2016-01-301-1/+1
| | | | | | | | | | | | commit d56460c939c94a6c547abe8238f442b8de10bfbd introduced this bug by setting up the tls module chain incorrectly when the main app has tls. the singly-linked list head pointer was setup correctly, but the tail pointer was not, so the first attempt to append to the list (for a shared library with tls) would treat the list as empty and effectively removed the main app from the list. this left all tls module id numbers off-by-one. this bug did not appear in any released versions.
* reuse parsed resolv.conf in dns core to avoid re-reading/re-parsingRich Felker2016-01-282-16/+22
|
* fix uninitialized variable in new resolv.conf parserRich Felker2016-01-281-1/+1
|
* add support for search domains to dns resolverRich Felker2016-01-281-1/+41
| | | | | | | | | | | | | search is only performed if the search or domain keyword is used in resolv.conf and the queried name has fewer than ndots dots. there is no default domain and names with >=ndots dots are never subjected to search; failure in the root scope is final. the (non-POSIX) res_search API presently does not honor search. this may be added at some point in the future if needed. resolv.conf is now parsed twice, at two different layers of the code involved. this will be fixed in a subsequent patch.
* fix handling of dns response codesRich Felker2016-01-281-1/+2
| | | | | | | | | | | | | | | rcode of 3 (NxDomain) was treated as a hard EAI_NONAME failure, but it should instead return 0 (no results) so the caller can continue searching. this will be important for adding search domain support. the top-level caller will automatically return EAI_NONAME if there are zero results at the end. also, the case where rcode is 0 (success) but there are no results was not handled. this happens when the domain exists but there are no A or AAAA records for it. in this case a hard EAI_NONAME should be imposed to inhibit further search, since the name was defined and just does not have any address associated with it. previously a misleading hard failure of EAI_FAIL was reported.
* fix logic for matching search/domain keywords in resolv.confRich Felker2016-01-281-1/+1
|
* factor resolv.conf parsing out of res_msend to its own fileRich Felker2016-01-283-60/+126
| | | | | | | | | | | | this change is made in preparation for adding search domains, for which higher-level code will need to parse resolv.conf. simply parsing it twice for each lookup would be one reasonable option, but the existing parser code was buggy anyway, which suggested to me that it's a bad idea to have two variants of this code in two different places. the old code in res_msend potentially misinterpreted overly long lines in resolv.conf, and stopped parsing after it found 3 nameservers, even if there were relevant options left to be parsed later in the file.
* add errno setting to stub utmpxname functionRich Felker2016-01-281-0/+2
|
* legacy/utmpx: Add utmp{,x}name stubsKylie McClain2016-01-281-0/+7
|
* deduplicate the bulk of the arch bits headersRich Felker2016-01-2792-3194/+0
| | | | | | | | | | | | all bits headers that were identical for a number of 'clean' archs are moved to the new arch/generic tree. in addition, a few headers that differed only cosmetically from the new generic version are removed. additional deduplication may be possible in mman.h and in several headers (limits.h, posix.h, stdint.h) that mostly depend on whether the arch is 32- or 64-bit, but they are left alone for now because greater gains are likely possible with more invasive changes to header logic, which is beyond the scope of this commit.
* add arch/generic include fallback to build rulesRich Felker2016-01-272-4/+9
| | | | | | this sets the stage for the first phase of the bits deduplication. bits headers which are identical for "most" archs will be moved to arch/generic/bits.
* remove unneeded -I options from configure test for may_alias attributeRich Felker2016-01-271-1/+1
| | | | | this test does not include anything, so the -I options are not useful and are just a maintenance burden if paths change.
* mips: add vdso supportHauke Mehrtens2016-01-271-0/+4
| | | | | | | | | | | | vdso support is available on mips starting with kernel 4.4, see kernel commit a7f4df4e21 "MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()" for details. In Linux kernel 4.4.0 the mips code returns -ENOSYS in case it can not handle the vdso call and assumes the libc will call the original syscall in this case. Handle this case in musl. Currently Linux kernel 4.4.0 handles the following types: CLOCK_REALTIME_COARSE, CLOCK_MONOTONIC_COARSE, CLOCK_REALTIME and CLOCK_MONOTONIC.
* improve clock_gettime and adapt it to support slightly-broken vdsoRich Felker2016-01-271-22/+39
| | | | | | | | | | | | | | | | | | | | | | | | | these changes are motivated by a functionally similar patch by Hauke Mehrtens to address the needs of the new mips vdso clock_gettime, which wrongly fails with ENOSYS rather than falling back to making a syscall for clock ids it cannot handle from userspace. in the process of preparing to handle that case, it was noticed that the old clock_gettime use of the vdso was actually wrong with respect to error handling -- the tail call to the vdso function failed to set errno and instead returned an error code. since tail calls to vdso are no longer possible and since the plain syscall code is now needed as a fallback path anyway, it does not make sense to use a function pointer to call the plain syscall code path. instead, it's inlined at the end of the main clock_gettime function. the new code also avoids the need to test for initialization of the vdso function pointer by statically initializing it to a self-init function, and eliminates redundant loads from the volatile pointer object. finally, the use of a_cas_p on an object of type other than void *, which is not permitted aliasing, is replaced by using an object with the correct type and casting the value.
* fix siginfo_t for mipsSzabolcs Nagy2016-01-262-0/+13
| | | | | | | | si_errno and si_code are swapped in mips siginfo_t compared to other archs and some si_code values are different. This fix is required for POSIX timers to work. based on patch by Dmitry Ivanov.
* move bits/signal.h include close to the top of signal.hSzabolcs Nagy2016-01-261-6/+12
| | | | | | | | only have code above the bits/signal.h include that is necessary. (some types are used for the ucontext struct and mips has to override a few macro definitions) this way mips bits/signal.h will be able to affect siginfo_t.
* add new PTRACE_SECCOMP_GET_FILTER ptrace commandSzabolcs Nagy2016-01-261-0/+1
| | | | | allows the tracer to dump the bpf seccomp filters of the tracee, new in linux v4.4, commit f8e529ed941ba2bbcbf310b575d968159ce7e895
* add MCL_ONFAULT and MLOCK_ONFAULT mlockall and mlock2 flagsSzabolcs Nagy2016-01-2611-0/+11
| | | | | | | | they lock faulted pages into memory (useful when a small part of a large mapped file needs efficient access), new in linux v4.4, commit b0f205c2a3082dd9081f9a94e50658c5fa906ff1 MLOCK_* is not in the POSIX reserved namespace for sys/mman.h
* add mlock2 syscall number from linux v4.4Szabolcs Nagy2016-01-268-0/+16
| | | | | | | this is mlock with a flags argument, new in linux commit a8ca5d0ecbdde5cc3d7accacbd69968b0c98764e as usual microblaze and sh don't have allocated syscall number yet.
* add new PTRACE_O_SUSPEND_SECCOMP ptrace optionSzabolcs Nagy2016-01-261-1/+2
| | | | | | allows a ptracer process to disable/enable seccomp filters of the traced process, useful for checkpoint/restore, new in v4.3 commit 13c4a90119d28cfcb6b5bdd820c233b86c2b0237
* add new PR_CAP_AMBIENT and related defines to sys/prctl.hSzabolcs Nagy2016-01-261-0/+6
| | | | | ambient capability mask is new in linux v4.3, commit 58319057b7847667f0c9585b9de0e8932b0fdb08
* update netpacket/packet.h to linux v4.3Szabolcs Nagy2016-01-261-0/+17
|
* add new membarrier, userfaultfd and switch_endian syscallsSzabolcs Nagy2016-01-268-0/+34
| | | | | | | | | | | | | | | new in linux v4.3 added for aarch64, arm, i386, mips, or1k, powerpc, x32 and x86_64. membarrier is a system wide memory barrier, moves most of the synchronization cost to one side, new in kernel commit 5b25b13ab08f616efd566347d809b4ece54570d1 userfaultfd is useful for qemu and is new in kernel commit 8d2afd96c20316d112e04d935d9e09150e988397 switch_endian is powerpc only for switching endianness, new in commit 529d235a0e190ded1d21ccc80a73e625ebcad09b
* add new i386 socket syscall numbersSzabolcs Nagy2016-01-261-0/+30
| | | | | | | | new in linux v4.3 commit 9dea5dc921b5f4045a18c63eb92e84dc274d17eb direct calls instead of socketcall allow better seccomp filtering. musl continues to use socketcalls internally on i386. (older kernels would need a fallback mechanism if the direct calls were used.)
* change the internal socketcall selection logicSzabolcs Nagy2016-01-262-1/+3
| | | | | | | | only use SYS_socketcall if SYSCALL_USE_SOCKETCALL is defined internally, otherwise use direct syscalls. this commit does not change the current behaviour, it is preparation for adding direct syscall numbers for i386.
* add ssp suppression to some arch-override files that may need itRich Felker2016-01-251-2/+4
| | | | | | | | these were not covered by the parent-level rules with the new build system. in the old build system, the equivalent files were often in arch/$(ARCH)/src and likewise lacked the suppression. this could lead to early crashing (before thread pointer init) when libc itself was built with stack protector enabled.
* use same object files for libc.a and libc.so if compiler produces PICRich Felker2016-01-252-2/+13
| | | | | | | | | | | | | | | | now that .lo and .o files differ only by whether -fPIC is passed (and no longer at the source level based on the SHARED macro), it's possible to use the same object files for both static and shared libc when the compiler would produce PIC for the static files anyway. this happens if the user has included -fPIC in their CFLAGS or if the compiler has been configured to produce PIE by default. we use the .lo files for both, and still append -fPIC to the CFLAGS, rather than using the .o files so that libc.so does not break catastrophically if the user later removes -fPIC from CFLAGS in config.mak or on the make command line. this also ensures that we get full -fPIC in case -fpic, -fPIE, or some other lesser-PIC option was passed in CFLAGS.
* move dynamic linker to its own top-level directory, ldsoRich Felker2016-01-255-19/+11
| | | | | | | | | | | | | | | | this eliminates the last need for the SHARED macro to control how files in the src tree are compiled. the same code is used for both libc.a and libc.so, with additional code for the dynamic linker (from the new ldso tree) being added to libc.so but not libc.a. separate .o and .lo object files still exist for the src tree, but the only difference is that the .lo files are built as PIC. in the future, if/when we add dlopen support for static-linked programs, much of the code in dynlink.c may be moved back into the src tree, but properly factored into separate source files. in that case, the code in the ldso tree will be reduced to just the dynamic linker entry point, self-relocation, and loading of libraries needed by the main application.
* adapt static dl_iterate_phdr not to depend on !defined(SHARED)Rich Felker2016-01-251-4/+3
| | | | | like elsewhere, use a weak alias that the dynamic linker will override with a more complete version capable of handling shared libraries.
* move static-linked stub dlsym out of dynlink.cRich Felker2016-01-252-11/+15
| | | | | | | | the function name is still __-prefixed because it requires an asm wrapper to pass the caller's address in order for RTLD_NEXT to work. since this was the last function in dynlink.c still used for static linking, now the whole file is conditional on SHARED being defined.