about summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* fix return value for inet_pton in ipv6 failure casesRich Felker2013-10-191-6/+6
| | | | | in the case of input that does not match the expected form, the correct return value is 0, not -1.
* use consistent include guard name in arpa/ftp.hSzabolcs Nagy2013-10-181-2/+2
|
* fix typo in socket.h (wrong macro name)Szabolcs Nagy2013-10-181-1/+1
|
* in faccessat slow path, add close-on-exec to pipe fdsRich Felker2013-10-181-1/+1
| | | | | as usual, this is needed to avoid fd leaks. as a better solution, the use of fds could possibly be replaced with mmap and a futex.
* fix uid/gid-setting error in faccessat with AT_EACCESS flagRich Felker2013-10-121-2/+2
| | | | | | | | | | | | | | | | this fixes an issue reported by Daniel Thau whereby faccessat with the AT_EACCESS flag did not work in cases where the process is running suid or sgid but without root privileges. per POSIX, when the process does not have "appropriate privileges", setuid changes the euid, not the real uid, and the target uid must be equal to the current real or saved uid; if this condition is not met, EPERM results. this caused the faccessat child process to fail. using the setreuid syscall rather than setuid works. POSIX leaves it unspecified whether setreuid can set the real user id to the effective user id on processes without "appropriate privileges", but Linux allows this; if it's not allowed, there would be no way for this function to work.
* fix errno value for getcwd when size argument is zeroRich Felker2013-10-081-1/+7
| | | | | | | | | based on patch by Michael Forney. at the same time, I've changed the if branch to be more clear, avoiding the comma operator. the underlying issue is that Linux always returns ERANGE when size is too short, even when it's zero, rather than returning EINVAL for the special case of zero as required by POSIX.
* math: fix rare underflow issue in fmaSzabolcs Nagy2013-10-073-13/+55
| | | | | the issue is described in commits 1e5eb73545ca6cfe8b918798835aaf6e07af5beb and ffd8ac2dd50f99c3c83d7d9d845df9874ec3e7d5
* math: use sqrtl if FLT_EVAL_METHOD==2 in acosh and acoshfSzabolcs Nagy2013-10-072-0/+13
| | | | this makes acosh slightly more precise around 1.0 on i386
* fix clockid macro names in time.h, reported by Paul SchutteSzabolcs Nagy2013-10-071-2/+2
|
* remove errno setting from setenv, malloc sets it correctly on oomSzabolcs Nagy2013-10-071-1/+0
|
* fix allocation sizes in regcompSzabolcs Nagy2013-10-071-4/+4
| | | | | sizeof had incorrect argument in a few places, the size was always large enough so the issue was not critical.
* add missing va_end in execl* for correcness and static code analyzersSzabolcs Nagy2013-10-073-0/+3
|
* minor vfprintf and vfwprintf changes to please static code analyzersSzabolcs Nagy2013-10-072-6/+11
| | | | add missing va_end and remove some unnecessary code.
* math: remove an unused variable from modflSzabolcs Nagy2013-10-061-1/+0
|
* slightly optimize __brk for sizeRich Felker2013-10-051-1/+1
| | | | | | | | | | there is no reason to check the return value for setting errno, since brk never returns errors, only the new value of the brk (which may be the same as the old, or otherwise differ from the requested brk, on failure). it may be beneficial to eventually just eliminate this file and make the syscalls inline in malloc.c.
* fix failure of malloc to set errno on heap (brk) exhaustionRich Felker2013-10-051-0/+1
| | | | | I wrongly assumed the brk syscall would set errno, but on failure it returns the old value of the brk rather than an error code.
* fix failure to check malloc result in setenvRich Felker2013-10-041-9/+9
|
* math: remove code duplication in erfl found by clang analyzerSzabolcs Nagy2013-10-041-13/+2
| | | | | erfl had some superflous code left around after the last erf cleanup. the issue was reported by Alexander Monakov
* math: remove a useless assignment in lgammal found by clang analyzerSzabolcs Nagy2013-10-041-2/+2
| | | | the issue was reported by Alexander Monakov
* fix invalid implicit pointer conversion in pthread_key_createRich Felker2013-10-041-1/+1
|
* fix uninitialized variable in dladdrRich Felker2013-10-041-1/+1
| | | | | the affected branch only applies for DSOs that lack standard hash table and only have the GNU hash table present.
* removed unused variable in vfwprintfRich Felker2013-10-041-2/+1
|
* fix new environment always being null with execleRich Felker2013-10-031-2/+1
| | | | | | | | the va_arg call for the argv[]-terminating null pointer was missing, so this pointer was being wrongly used as the environment pointer. issue reported by Timo Teräs. proposed patch slightly modified to simplify the resulting code.
* fix off-by-one error in getgrnam_r and getgrgid_r, clobbering gr_nameRich Felker2013-09-291-2/+2
| | | | | | | bug report and patch by Michael Forney. the terminating null pointer at the end of the gr_mem array was overwriting the beginning of the string data, causing the gr_name member to always be a zero-length string.
* fix buffer overflow in mbsrtowcsRich Felker2013-09-271-1/+1
| | | | | | | | | | | | | | | | | | | issue reported by Michael Forney: "If wn becomes 0 after processing a chunk of 4, mbsrtowcs currently continues on, wrapping wn around to -1, causing the rest of the string to be processed. This resulted in buffer overruns if there was only space in ws for wn wide characters." the original patch submitted added an additional check for !wn after the loop; to avoid extra branching, I instead just changed the wn>=4 check to wn>=5 to ensure that at least one slot remains after the word-at-a-time loop runs. this should not slow down the tail processing on real-world usage, since an extra slot that can't be processed in the word-at-a-time loop is needed for the null termination anyway.
* math: fix comparision macros (isless etc) when FLT_EVAL_METHOD!=0Szabolcs Nagy2013-09-271-10/+10
| | | | | | | This is a change in ISO C11 annex F (F.10.11p1), comparision macros can't round their arguments to their semantic type when the evaluation format has wider range and precision. (ie. they must be consistent with the builtin relational operators)
* add missing i386 syscall numbersRich Felker2013-09-261-0/+10
| | | | somehow the range 335-339 was missed when updating the file.
* remove duplicate lines from mips bits/syscall.hRich Felker2013-09-261-48/+0
|
* release notes for 0.9.14 v0.9.14Rich Felker2013-09-231-0/+30
|
* fix arm atomic store and generate simpler/less-bloated/faster codeRich Felker2013-09-221-6/+8
| | | | | | | | | | | | | | | | atomic store was lacking a barrier, which was fine for legacy arm with no real smp and kernel-emulated cas, but unsuitable for more modern systems. the kernel provides another "kuser" function, at 0xffff0fa0, which could be used for the barrier, but using that would drop support for kernels 2.6.12 through 2.6.14 unless an extra conditional were added to check for barrier availability. just using the barrier in the kernel cas is easier, and, based on my reading of the assembly code in the kernel, does not appear to be significantly slower. at the same time, other atomic operations are adapted to call the kernel cas function directly rather than using a_cas; due to small differences in their interface contracts, this makes the generated code much simpler.
* fix potential deadlock bug in libc-internal locking logicRich Felker2013-09-203-13/+15
| | | | | | | | | | | | | | | | | | | | if a multithreaded program became non-multithreaded (i.e. all other threads exited) while one thread held an internal lock, the remaining thread would fail to release the lock. the the program then became multithreaded again at a later time, any further attempts to obtain the lock would deadlock permanently. the underlying cause is that the value of libc.threads_minus_1 at unlock time might not match the value at lock time. one solution would be returning a flag to the caller indicating whether the lock was taken and needs to be unlocked, but there is a simpler solution: using the lock itself as such a flag. note that this flag is not needed anyway for correctness; if the lock is not held, the unlock code is harmless. however, the memory synchronization properties associated with a_store are costly on some archs, so it's best to avoid executing the unlock code when it is unnecessary.
* correct the sysconf value for RTSIG_MAXRich Felker2013-09-201-1/+2
| | | | | this is the number of realtime signals available, not the maximum signal number or total number of signals.
* fix sigemptyset and sigfillset for mipsRich Felker2013-09-162-1/+10
| | | | they were leaving junk in the upper bits.
* fix clobbering of caller's stack in mips __clone functionRich Felker2013-09-161-0/+3
| | | | | | | | | this was resulting in crashes in posix_spawn on mips, and would have affected applications calling clone too. since the prototype for __clone has it as a variadic function, it may not assume that 16($sp) is writable for use in making the syscall. instead, it needs to allocate additional stack space, and then adjust the stack pointer back in both of the code paths for the parent process/thread.
* sys/resource.h: add PRIO_MIN and PRIO_MAX for getpriority and setprioritySzabolcs Nagy2013-09-161-0/+3
| | | | | | | These constants are not specified by POSIX, but they are in the reserved namespace, glibc and bsd systems seem to provide them as well. (Note that POSIX specifies -NZERO and NZERO-1 to be the limits, but PRIO_MAX equals NZERO)
* update include/elf.h following glibc changesSzabolcs Nagy2013-09-161-27/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the changes were verified using various sources: linux: include/uapi/linux/elf.h binutils: include/elf/common.h glibc: elf/elf.h sysv gabi: http://www.sco.com/developers/gabi/latest/contents.html sun linker docs: http://docs.oracle.com/cd/E18752_01/pdf/817-1984.pdf and platform specific docs - fixed: EF_MIPS_* E_MIPS_* e_flags: fixed accoding to glibc and binutils - added: ELFOSABI_GNU for EI_OSABI entry: glibc, binutils and sysv gabi EM_* e_machine values: updated according to linux and glibc PN_XNUM e_phnum value: from glibc and linux, see oracle docs NT_* note types: updated according to linux and glibc DF_1_* flags for DT_FLAGS_1 entry: following glibc and oracle docs AT_HWCAP2 auxv entry for more hwcap bits accoding to linux and glibc R_386_SIZE32 relocation according to glibc and binutils EF_ARM_ABI_FLOAT_* e_flags: added following glibc and binutils R_AARCH64_* relocs: added following glibc and aarch64 elf specs R_ARM_* relocs: according to glibc, binutils and arm elf specs R_X86_64_* relocs: added missing relocs following glibc - removed: HWCAP_SPARC_* flags were moved to arch specific header in glibc R_ARM_SWI24 reloc is marked as obsolete in glibc, not present in binutils not specified in arm elf spec, R_ARM_TLS_DESC reused its number see http://www.codesourcery.com/publications/RFC-TLSDESC-ARM.txt - glibc changes not pulled in: ELFOSABI_ARM_AEABI (bare-metal system, binutils and glibc disagrees about the name) R_68K_* relocs for unsupported platform R_SPARC_* ditto EF_SH* ditto (e_flags) EF_S390* ditto (e_flags) R_390* ditto R_MN10300* ditto R_TILE* ditto
* omit CLONE_PARENT flag to clone in pthread_createRich Felker2013-09-161-1/+1
| | | | | | | | CLONE_PARENT is not necessary (CLONE_THREAD provides all the useful parts of it) and Linux treats CLONE_PARENT as an error in certain situations, without noticing that it would be a no-op due to CLONE_THREAD. this error case prevents, for example, use of a multi-threaded init process and certain usages with containers.
* use symbolic names for clone flags in pthread_createRich Felker2013-09-161-2/+5
|
* sys/socket.h: add new SO_BUSY_POLL socket optionSzabolcs Nagy2013-09-151-0/+1
| | | | low latency busy poll sockets are new in linux v3.11
* ptrace.h: add new ptrace requests to get/set sigmaskSzabolcs Nagy2013-09-151-0/+2
| | | | | PTRACE_GETSIGMASK and PTRACE_SETSIGMASK were added in linux v3.11 and used by checkpoint/restore tools
* net/if_arp.h: add missing ARP hardware identifiers from linux uapi headersSzabolcs Nagy2013-09-151-1/+7
| | | | | | the removed ARPHRD_IEEE802154_PHY was only present in the kernel api in v2.6.31 (by accident), but it got into the glibc headers (in 2009) and remained there since this header was not updated since then.
* netinet/in.h: add missing IP protocol numbers from the linux uapi headersSzabolcs Nagy2013-09-151-0/+2
|
* support configurable page size on mips, powerpc and microblazeSzabolcs Nagy2013-09-1519-17/+29
| | | | | | | | | | | | | | | | PAGE_SIZE was hardcoded to 4096, which is historically what most systems use, but on several archs it is a kernel config parameter, user space can only know it at execution time from the aux vector. PAGE_SIZE and PAGESIZE are not defined on archs where page size is a runtime parameter, applications should use sysconf(_SC_PAGE_SIZE) to query it. Internally libc code defines PAGE_SIZE to libc.page_size, which is set to aux[AT_PAGESZ] in __init_libc and early in __dynlink as well. (Note that libc.page_size can be accessed without GOT, ie. before relocations are done) Some fpathconf settings are hardcoded to 4096, these should be actually queried from the filesystem using statfs.
* fix overflow in sysconf for _SC_MQ_PRIO_MAXRich Felker2013-09-141-1/+2
| | | | the value of MQ_PRIO_MAX does not fit, so it needs to use OFLOW.
* fix child stack alignment on mips cloneRich Felker2013-09-141-0/+1
| | | | | | unlike other archs, the mips version of clone was not doing anything to align the stack pointer. this seems to have been the cause for some SIGBUS crashes that were observed in posix_spawn.
* fix mips sysv ipc bits headersRich Felker2013-09-142-3/+9
| | | | | | | msg.h was wrong for big-endian (wrong endiannness padding). shm.h was just plain wrong (mips is not supposed to have padding). both changes were tested using libc-test on qemu-system-mips.
* fix x86_64 lrintl asm, againRich Felker2013-09-131-2/+2
| | | | | | | | the underlying problem was not incorrect sign extension (fixed in the previous commit to this file by nsz) but that code that treats "long" as 32-bit was copied blindly from i386 to x86_64. now lrintl is identical to llrintl on x86_64, as it should be.
* do not use default when dynamic linker fails to open existing path fileRich Felker2013-09-091-0/+2
| | | | | | | | if fopen fails for a reason other than ENOENT, we must assume the intent is that the path file be used. failure may be due to misconfiguration or intentional resource-exhaustion attack (against suid programs), in which case falling back to loading libraries from an unintended path could be dangerous.
* math: remove STRICT_ASSIGN from exp2f (see previous commit)Szabolcs Nagy2013-09-061-1/+1
|
* math: remove STRICT_ASSIGN macroSzabolcs Nagy2013-09-0611-23/+13
| | | | | | | | | | | | | gcc did not always drop excess precision according to c99 at assignments before version 4.5 even if -std=c99 was requested which caused badly broken mathematical functions on i386 when FLT_EVAL_METHOD!=0 but STRICT_ASSIGN was not used consistently and it is worked around for old compilers with -ffloat-store so it is no longer needed the new convention is to get the compiler respect c99 semantics and when excess precision is not harmful use float_t or double_t or to specialize code using FLT_EVAL_METHOD