about summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* report that posix_spawn is supported in unistd.h and sysconfRich Felker2013-07-262-1/+2
|
* add ABI symbols for strtol family functionsRich Felker2013-07-261-0/+8
| | | | | these odd names are actually generated by mess in glibc's stdlib.h, so any glibc-linked program using strtol needs them to run against musl.
* make ldd report the libc/dynamic linker itselfRich Felker2013-07-261-0/+22
|
* fix computation of entry point and main app phdrs when invoking via ldsoRich Felker2013-07-261-3/+1
| | | | | | | | | | | entry point was wrong for PIE. e_entry was being treated as an absolute value, whereas it's actually relative to the load address (which is zero for non-PIE). phdr pointer was wrong for non-PIE. e_phoff was being treated as load-address-relative, whereas it's actually a file offset in the ELF file. in any case, map_library was already computing it correctly, and the incorrect code in __dynlink was overwriting it with junk.
* fix powerpc build breakage from dynamic linker path search changesRich Felker2013-07-261-1/+1
|
* new mostly-C crt1 implementationRich Felker2013-07-269-0/+96
| | | | | | | | | | | | | | | the only immediate effect of this commit is enabling PIE support on some archs that did not previously have any Scrt1.s, since the existing asm files for crt1 override this C code. so some of the crt_arch.h files committed are only there for the sake of documenting what their archs "would do" if they used the new C-based crt1. the expectation is that new archs should use this new system rather than using heavy asm for crt1. aside from being easier and less error-prone, it also ensures that PIE support is available immediately (since Scrt1.o is generated from the same C source, using -fPIC) rather than having to be added as an afterthought in the porting process.
* fix undefined strcpy call in inet_ntopRich Felker2013-07-251-1/+1
| | | | | source and dest arguments for strcpy cannot overlap, so memmove must be used here. the length is already known from the above loop.
* make inet_ntop format v4-mapped ipv6 addresses properlyRich Felker2013-07-251-8/+14
| | | | | | | | | | | | | | based on a patch by orc. POSIX actually fails to specify the format of the ntop conversion; presumably, any output that will correctly round-trip back via the (well-specified) pton operation is acceptable. the new behavior is much more convenient than the old, however. this patch also affects getnameinfo, which is implemented in terms of inet_ntop and which is the preferred interface for performing this conversion. I've also removed some inexplicable cruft (filling the buffer with 'x' before doing anything) whose origin I was unable to track down.
* do not include math modules in the default -O3 optimization setRich Felker2013-07-241-1/+1
| | | | | | it's not clear that -O3 helps them, and gcc seems to have floating point optimization bugs that introduce additional failures when -O3 is used on some of these files.
* fix incorrect type for new si_call_addr in siginfo_tRich Felker2013-07-241-3/+3
| | | | | | | | | | apparently the original kernel commit's i386 version of siginfo.h defined this field as unsigned int, but the asm-generic file always had void *. unsigned int is obviously not a suitable type for an address, in a non-arch-specific file, and glibc also has void * here, so I think void * is the right type for it. also fix redundant type specifiers.
* add protocol families PF_IB and PF_VSOCK to socket.hSzabolcs Nagy2013-07-251-1/+5
| | | | | | | | linux commit 8d36eb01da5d371feffa280e501377b5c450f5a5 (2013-05-29) added PF_IB for InfiniBand linux commit d021c344051af91f42c5ba9fdedc176740cbd238 (2013-02-06) added PF_VSOCK for VMware sockets
* update siginfo according to linux headersSzabolcs Nagy2013-07-241-1/+13
| | | | | | | | linux commit a0727e8ce513fe6890416da960181ceb10fbfae6 (2012-04-12) added siginfo fields for SIGSYS (seccomp uses it) linux commit ad5fa913991e9e0f122b021e882b0d50051fbdbc (2009-09-16) added siginfo field and si_code values for SIGBUS (hwpoison signal)
* rework langinfo code for ABI compat and for use by time codeRich Felker2013-07-244-17/+17
|
* update strxfrm/wcsxfrm for future LC_COLLATE support and ABI compatRich Felker2013-07-244-14/+20
|
* add ABI compat aliases for a number of locale_t functionsRich Felker2013-07-248-0/+24
|
* add PTRACE_PEEKSIGINFO to ptrace.hSzabolcs Nagy2013-07-241-0/+11
| | | | | added in linux-v3.10 commit 84c751bd4aebbaae995fe32279d3dba48327bad4 using stdint.h types for the new ptrace_peeksiginfo_args struct
* add if_ether.h constants ETH_P_802_3_MIN and ETH_P_BATMANSzabolcs Nagy2013-07-241-0/+3
| | | | | see linux commits 4f99ad51292078cc47343c17d3870764588cff73 and e5c5d22e8dcf7c2d430336cbf8e180bd38e8daf1
* add CLOCK_TAI (and CLOCK_SGI_CYCLE) clock ids to time.hSzabolcs Nagy2013-07-241-0/+2
| | | | added in linux-v3.10 commit 1ff3c9677bff7e468e0c487d0ffefe4e901d33f4
* remove TCP_COOKIE_TRANSACTIONS from tcp.hSzabolcs Nagy2013-07-241-1/+0
| | | | removed in linux-v3.10 in commit 1a2c6181c4a1922021b4d7df373bba612c3e5f04
* add SO_SELECT_ERR_QUEUE to socket.hSzabolcs Nagy2013-07-241-0/+1
| | | | introduced in linux-v3.10 commit 7d4c04fc170087119727119074e72445f2bb192b
* prepare strcoll/wcscoll for LC_COLLATE support and add ABI symbolsRich Felker2013-07-244-15/+20
|
* add _l versions of strtod family functions, purely as aliasesRich Felker2013-07-241-0/+8
| | | | | | | | this is a cheat since the _l versions take an extra argument, but since these functions are only here for ABI purposes, it doesn't really matter as long as the ABI matches. if the non-__-prefixed versions are eventually made public, they should proabably be real functions rather than hacks like this.
* add __wcsftime_l symbolRich Felker2013-07-241-3/+9
| | | | | | unlike the strftime commit, this one is purely an ABI compatibility issue. the previous version of the code would have worked just as well with LC_TIME once LC_TIME support is added.
* move strftime_l into strftime.c and add __-prefixed versionRich Felker2013-07-242-8/+10
| | | | | | the latter is both for ABI purposes, and to facilitate eventually adding LC_TIME support. it's also nice to eliminate an extra source file.
* make getaddrinfo with AF_UNSPEC and null host return both IPv4 and v6Rich Felker2013-07-241-14/+23
| | | | | | based on a patch by orc, with indexing and flow control cleaned up a little bit. this code is all going to be replaced at some point in the near future.
* support STB_GNU_UNIQUE symbol bindings in dynamic linkerRich Felker2013-07-241-1/+1
| | | | | | | | | these are needed for some C++ library binaries including most builds of libstdc++. I'm not entirely clear on the rationale. this patch does not implement any special semantics for them, but as far as I can tell, no special treatment is needed in correctly-linked programs; this binding seems to exist only for catching incorrectly-linked programs.
* move the dynamic linker's jmp_buf from static to automatic storageRich Felker2013-07-241-5/+7
| | | | | this more than compensates for the size increase of jmp_buf, and greatly reduces bss/data size on archs with huge jmp_buf.
* change jmp_buf to share an underlying type and struct tag with sigjmp_bufRich Felker2013-07-249-15/+14
| | | | | | | | | | this is necessary to meet the C++ ABI target. alternatives were considered to avoid the size increase for non-sig jmp_buf objects, but they seemed to have worse properties. moreover, the relative size increase is only extreme on x86[_64]; one way of interpreting this is that, if the size increase from this patch makes jmp_buf use too much memory, then the program was already using too much memory when built for non-x86 archs.
* remove redundant check in memalignRich Felker2013-07-231-1/+1
| | | | | the case where mem was already aligned is handled earlier in the function now.
* fix heap corruption bug in memalignRich Felker2013-07-231-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | this bug was caught by the new footer-corruption check in realloc and free. if the block returned by malloc was already aligned to the desired alignment, memalign's logic to split off the misaligned head was incorrect; rather than writing to a point inside the allocated block, it was overwriting the footer of the previous block on the heap with the value 1 (length 0 plus an in-use flag). fortunately, the impact of this bug was fairly low. (this is probably why it was not caught sooner.) due to the way the heap works, malloc will never return a block whose previous block is free. (doing so would be harmful because it would increase fragmentation with no benefit.) the footer is actually not needed for in-use blocks, except that its in-use bit needs to remain set so that it does not get merged with free blocks, so there was no harm in it being set to 1 instead of the correct value. however, there is one case where this bug could have had an impact: in multi-threaded programs, if another thread freed the previous block after memalign's call to malloc returned, but before memalign overwrote the previous block's footer, the resulting block in the free list could be left in a corrupt state. I have not analyzed the impact of this bad state and whether it could lead to more serious malfunction.
* enhance build process to allow selective -O3 optimizationRich Felker2013-07-222-12/+57
| | | | | | | | | | | | | | | | | the motivation for this patch is that the vast majority of libc is code that does not benefit at all from optimizations, but that certain components like string/memory operations can be major performance bottlenecks. at the same time, the old -falign-*=1 options are removed, since they were only beneficial for avoiding bloat when global -O3 was used, and in that case, they may have prevented some of the performance gains. to be the most useful, this patch will need further tuning. in particular, research is needed to determine which components should be built with -O3 by default, and it may be desirable to remove the hard-coded -O3 and instead allow more customization of the optimization level used for selected modules.
* undefine internal-use type macros at the end of alltypes.hRich Felker2013-07-221-0/+4
| | | | | | | | | | | | | | | | | this patch is something of a compromise for a compatibility regression discovered after the header refactoring: libtiff uses _Int64 for its own use. this is absolutely wrong, invalid C, and should not be supported, but it's also frustrating for users when code that used to work suddenly breaks. rather than leave the breakage in place or change musl internals to accommodate broken software, I've found a change that makes the problem go away and improves musl. by undefining these macros at the end of alltypes.h, the temptation to use them in other headers is removed. (for example, I almost used _Int64 in sys/types.h to define u_int64_t rather than adding it back to alltypes.h.) by confining use of these macros to alltypes.h, we keep it easy to go back and change the implementation of alltypes later, if needed.
* remove SIG_ATOMIC_MIN/MAX from stdint bits headersRich Felker2013-07-225-10/+0
| | | | i386 was done with the big commit but I missed the others
* move register_t and u_int64_t (back) to alltypesRich Felker2013-07-222-2/+7
| | | | | | | | during the header refactoring, I had moved u_int64_t out of alltypes under the assumption that we could just use long long everywhere. however, it seems some broken applications make inconsistent mixed use of u_int64_t and uint64_t, resulting in build errors when the underlying type differs.
* fix regression in size of nlink_t (broken stat struct) on x86_64Rich Felker2013-07-227-1/+7
| | | | | | | | rather than moving nlink_t back to the arch-specific file, I've added a macro _Reg defined to the canonical type for register-size values on the arch. this is not the same as _Addr for (not-yet-supported) 32-on-64 pseudo-archs like x32 and mips n32, so a new macro was needed.
* make regoff_t and regex_t match C++ ABIRich Felker2013-07-222-3/+3
| | | | | | for regoff_t, it's impossible to match on 64-bit archs because glibc defined the type in a non-conforming way. however this change makes the type match on 32-bit archs.
* disable legacy init/fini processing on ARMRich Felker2013-07-222-0/+6
| | | | | | | | | | | since the old, poorly-thought-out musl approach to init/fini arrays on ARM (when it was the only arch that needed them) was to put the code in crti/crtn and have the legacy _init/_fini code run the arrays, adding proper init/fini array support caused the arrays to get processed twice on ARM. I'm not sure skipping legacy init/fini processing is the best solution to the problem, but it works, and it shouldn't break anything since the legacy init/fini system was never used for ARM EABI.
* make pthread_key_t unsigned to match ABIRich Felker2013-07-221-1/+1
|
* make pthread attribute types structs, even when they just have one fieldRich Felker2013-07-2212-25/+25
| | | | | this change is to get the right tags for C++ ABI matching. it should have no other effects.
* change wint_t to unsignedRich Felker2013-07-229-10/+10
| | | | | | | | | | | | aside from the obvious C++ ABI purpose for this change, it also brings musl into alignment with the compiler's idea of the definition of wint_t (use in -Wformat), and makes the situation less awkward on ARM, where wchar_t is unsigned. internal code using wint_t and WEOF was checked against this change, and while a few cases of storing WEOF into wchar_t were found, they all seem to operate properly with the natural conversion from unsigned to signed.
* refactor headers, especially alltypes.h, and improve C++ ABI compatRich Felker2013-07-2241-907/+335
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the arch-specific bits/alltypes.h.sh has been replaced with a generic alltypes.h.in and minimal arch-specific bits/alltypes.h.in. this commit is intended to have no functional changes except: - exposing additional symbols that POSIX allows but does not require - changing the C++ name mangling for some types - fixing the signedness of blksize_t on powerpc (POSIX requires signed) - fixing the limit macros for sig_atomic_t on x86_64 - making dev_t an unsigned type (ABI matching goal, and more logical) in addition, some types that were wrongly defined with long on 32-bit archs were changed to int, and vice versa; this change is non-functional except for the possibility of making pointer types mismatch, and only affects programs that were using them incorrectly, and only at build-time, not runtime. the following changes were made in the interest of moving non-arch-specific types out of the alltypes system and into the headers they're associated with, and also will tend to improve application compatibility: - netdb.h now includes netinet/in.h (for socklen_t and uint32_t) - netinet/in.h now includes sys/socket.h and inttypes.h - sys/resource.h now includes sys/time.h (for struct timeval) - sys/wait.h now includes signal.h (for siginfo_t) - langinfo.h now includes nl_types.h (for nl_item) for the types in stdint.h: - types which are of no interest to other headers were moved out of the alltypes system. - fast types for 8- and 64-bit are hard-coded (at least for now); only the 16- and 32-bit ones have reason to vary by arch. and the following types have been changed for C++ ABI purposes; - mbstate_t now has a struct tag, __mbstate_t - FILE's struct tag has been changed to _IO_FILE - DIR's struct tag has been changed to __dirstream - locale_t's struct tag has been changed to __locale_struct - pthread_t is defined as unsigned long in C++ mode only - fpos_t now has a struct tag, _G_fpos64_t - fsid_t's struct tag has been changed to __fsid_t - idtype_t has been made an enum type (also required by POSIX) - nl_catd has been changed from long to void * - siginfo_t's struct tag has been removed - sigset_t's has been given a struct tag, __sigset_t - stack_t has been given a struct tag, sigaltstack - suseconds_t has been changed to long on 32-bit archs - [u]intptr_t have been changed from long to int rank on 32-bit archs - dev_t has been made unsigned summary of tests that have been performed against these changes: - nsz's libc-test (diff -u before and after) - C++ ABI check symbol dump (diff -u before, after, glibc) - grepped for __NEED, made sure types needed are still in alltypes - built gcc 3.4.6
* remove init/fini array asm from arm crti/crtn filesRich Felker2013-07-212-44/+4
| | | | | this code has been replaced by portable C code that works on all archs. the old asm needs to be removed or ctors/dtors will run twice.
* remove __libc_csu_* cruftRich Felker2013-07-212-10/+0
| | | | | | | these functions were mistakenly assumed to be needed to match glibc ABI, but glibc has them as part of the non-shared part of libc that's always statically linked into the main program. moreover, the only place they are referenced from is glibc's crt1.o.
* add support for init/fini array in main program, and greatly simplifyRich Felker2013-07-214-26/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | modern (4.7.x and later) gcc uses init/fini arrays, rather than the legacy _init/_fini function pasting and crtbegin/crtend ctors/dtors system, on most or all archs. some archs had already switched a long time ago. without following this change, global ctors/dtors will cease to work under musl when building with new gcc versions. the most surprising part of this patch is that it actually reduces the size of the init code, for both static and shared libc. this is achieved by (1) unifying the handling main program and shared libraries in the dynamic linker, and (2) eliminating the glibc-inspired rube goldberg machine for passing around init and fini function pointers. to clarify, some background: the function signature for __libc_start_main was based on glibc, as part of the original goal of being able to run some glibc-linked binaries. it worked by having the crt1 code, which is linked into every application, static or dynamic, obtain and pass pointers to the init and fini functions, which __libc_start_main is then responsible for using and recording for later use, as necessary. however, in neither the static-linked nor dynamic-linked case do we actually need crt1.o's help. with dynamic linking, all the pointers are available in the _DYNAMIC block. with static linking, it's safe to simply access the _init/_fini and __init_array_start, etc. symbols directly. obviously changing the __libc_start_main function signature in an incompatible way would break both old musl-linked programs and glibc-linked programs, so let's not do that. instead, the function can just ignore the information it doesn't need. new archs need not even provide the useless args in their versions of crt1.o. existing archs should continue to provide it as long as there is an interest in having newly-linked applications be able to run on old versions of musl; at some point in the future, this support can be removed.
* fix order of fini_array execution for shared libsRich Felker2013-07-211-2/+2
|
* add support for init_array/fini_array ctors/dtors to dynamic linkerRich Felker2013-07-201-2/+13
|
* fix shm_open wrongly being cancellableRich Felker2013-07-201-1/+6
|
* fix uninitialized/stale use of alloc (%m modifier) flag in scanfRich Felker2013-07-202-0/+4
| | | | | | | | | for conversion specifiers, alloc is always set when the specifier is parsed. however, if scanf stops due to mismatching literal text, either an uninitialized (if no conversions have been performed yet) or stale (from the previous conversion) of the flag will be used, possibly causing an invalid pointer to be passed to free when the function returns.
* harden realloc/free to detect simple overflowsRich Felker2013-07-191-0/+6
| | | | | | | | | | | the sizes in the header and footer for a chunk should always match. if they don't, the program has definitely invoked undefined behavior, and the most likely cause is a simple overflow, either of a buffer in the block being freed or the one just below it. crashing here should not only improve security of buggy programs, but also aid in debugging, since the crash happens in a context where you have a pointer to the likely-overflowed buffer.
* add UIO_MAXIOV macro in sys/uio.hRich Felker2013-07-191-0/+2
| | | | | | while there's no POSIX namespace provision for UIO_* in uio.h, this exact macro name is reserved in XBD 2.2.2. apparently some glibc-centric software expects it to exist, so let's provide it.