diff options
| author | Rich Felker <dalias@aerifal.cx> | 2012-02-09 02:33:08 -0500 |
|---|---|---|
| committer | Rich Felker <dalias@aerifal.cx> | 2012-02-09 02:33:08 -0500 |
| commit | afc35d5efde48b82a7786d9c89b115965da6b637 (patch) | |
| tree | d71e3007272b5eaa392feb84064459d8de9d82f5 /src/thread/i386/cancellation.s | |
| parent | ed2911a11317729c1a13e779237fed736c676c1b (diff) | |
| download | musl-afc35d5efde48b82a7786d9c89b115965da6b637.tar.gz musl-afc35d5efde48b82a7786d9c89b115965da6b637.tar.xz musl-afc35d5efde48b82a7786d9c89b115965da6b637.zip | |
replace bad cancellation cleanup abi with a sane one
the old abi was intended to duplicate glibc's abi at the expense of being ugly and slow, but it turns out glib was not even using that abi except on non-gcc-compatible compilers (which it doesn't even support) and was instead using an exceptions-in-c/unwind-based approach whose abi we could not duplicate anyway without nasty dwarf2/unwind integration. the new abi is copied from a very old glibc abi, which seems to still be supported/present in current glibc. it avoids all unwinding, whether by sjlj or exceptions, and merely maintains a linked list of cleanup functions to be called from the context of pthread_exit. i've made some care to ensure that longjmp out of a cleanup function should work, even though it is not required to. this change breaks abi compatibility with programs which were using pthread cancellation, which is unfortunate, but that's why i'm making the change now rather than later. considering that most pthread features have not been usable until recently anyway, i don't see it as a major issue at this point.
Diffstat (limited to 'src/thread/i386/cancellation.s')
| -rw-r--r-- | src/thread/i386/cancellation.s | 34 |
1 files changed, 0 insertions, 34 deletions
diff --git a/src/thread/i386/cancellation.s b/src/thread/i386/cancellation.s deleted file mode 100644 index 75dc6091..00000000 --- a/src/thread/i386/cancellation.s +++ /dev/null @@ -1,34 +0,0 @@ -.text -.global __pthread_register_cancel -.type __pthread_register_cancel,@function -__pthread_register_cancel: - pushl %eax - call __pthread_do_register - popl %eax - ret - -.global __pthread_unregister_cancel -.type __pthread_unregister_cancel,@function -__pthread_unregister_cancel: - pushl %eax - call __pthread_do_unregister - popl %eax - ret - -.global __pthread_unwind_next -.type __pthread_unwind_next,@function -__pthread_unwind_next: - pushl %eax - call __pthread_do_unwind - popl %eax -__pthread_do_unwind: -__pthread_do_register: -__pthread_do_unregister: - ret - -.weak __pthread_do_unwind -.weak __pthread_do_register -.weak __pthread_do_unregister -.type __pthread_do_unwind,@function -.type __pthread_do_register,@function -.type __pthread_do_unregister,@function |