about summary refs log tree commit diff
path: root/src/stdlib
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2013-12-19 14:24:55 -0500
committerRich Felker <dalias@aerifal.cx>2013-12-19 14:24:55 -0500
commit65ea604c74f3fecbc61a266a22fdf527764995b6 (patch)
treecf4cfe75094e4301b37d0ab21f21e5c1a6a36473 /src/stdlib
parentf89e29829029c5003450f7b58bd00fe5d1049d09 (diff)
downloadmusl-65ea604c74f3fecbc61a266a22fdf527764995b6.tar.gz
musl-65ea604c74f3fecbc61a266a22fdf527764995b6.tar.xz
musl-65ea604c74f3fecbc61a266a22fdf527764995b6.zip
fix failure of fchmod, fstat, fchdir, and fchown to produce EBADF
the workaround/fallback code for supporting O_PATH file descriptors
when the kernel lacks support for performing these operations on them
caused EBADF to get replaced by ENOENT (due to missing entry in
/proc/self/fd). this is unlikely to affect real-world code (calls that
might yield EBADF are generally unsafe, especially in library code)
but it was breaking some test cases.

the fix I've applied is something of a tradeoff: it adds one syscall
to these operations on kernels where the workaround is needed. the
alternative would be to catch ENOENT from the /proc lookup and
translate it to EBADF, but I want to avoid doing that in the interest
of not touching/depending on /proc at all in these functions as long
as the kernel correctly supports the operations. this is following the
general principle of isolating hacks to code paths that are taken on
broken systems, and keeping the code for correct systems completely
hack-free.
Diffstat (limited to 'src/stdlib')
0 files changed, 0 insertions, 0 deletions