about summary refs log tree commit diff
path: root/src/stdlib/strtod.c
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2012-04-10 21:47:37 -0400
committerRich Felker <dalias@aerifal.cx>2012-04-10 21:47:37 -0400
commit2162541f38d3f642f5a643010548d62220d55a4d (patch)
tree8ea23d95450312e95377b69da9b65baaa5bfdd90 /src/stdlib/strtod.c
parent4fb6aa02c88a6b8b718c0ae982d072aa6ab8559f (diff)
downloadmusl-2162541f38d3f642f5a643010548d62220d55a4d.tar.gz
musl-2162541f38d3f642f5a643010548d62220d55a4d.tar.xz
musl-2162541f38d3f642f5a643010548d62220d55a4d.zip
add "scan helper getc" and rework strtod, etc. to use it
the immediate benefit is a significant debloating of the float parsing
code by moving the responsibility for keeping track of the number of
characters read to a different module.

by linking shgetc with the stdio buffer logic, counting logic is
defered to buffer refill time, keeping the calls to shgetc fast and
light.

in the future, shgetc will also be useful for integrating the new
float code with scanf, which needs to not only count the characters
consumed, but also limit the number of characters read based on field
width specifiers.

shgetc may also become a useful tool for simplifying the integer
parsing code.
Diffstat (limited to 'src/stdlib/strtod.c')
-rw-r--r--src/stdlib/strtod.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/stdlib/strtod.c b/src/stdlib/strtod.c
index b444f530..ecfabdf1 100644
--- a/src/stdlib/strtod.c
+++ b/src/stdlib/strtod.c
@@ -1,4 +1,5 @@
 #include <stdlib.h>
+#include "shgetc.h"
 #include "floatscan.h"
 #include "stdio_impl.h"
 
@@ -10,8 +11,9 @@ static long double strtox(const char *s, char **p, int prec)
 		.buf = (void *)t, .rpos = (void *)t,
 		.rend = (void *)-1, .lock = -1
 	};
-	off_t cnt;
-	long double y = __floatscan(&f, -1, prec, 1, &cnt);
+	shlim(&f, 0);
+	long double y = __floatscan(&f, -1, prec, 1);
+	off_t cnt = shcnt(&f);
 	if (p) *p = cnt ? t + cnt : (char *)s;
 	return y;
 }