diff options
| author | Rich Felker <dalias@aerifal.cx> | 2015-02-05 23:34:27 -0500 |
|---|---|---|
| committer | Rich Felker <dalias@aerifal.cx> | 2015-02-05 23:34:27 -0500 |
| commit | 61b1d102129990f6e903c6ddcf46c7d79d1a1e99 (patch) | |
| tree | 3ee30115dcaa23771352bd0c2bbf8204ee40d4cd /src/stat/fchmodat.c | |
| parent | 2736eb6caa70bb6e909d7d8ebbe145c2071435e0 (diff) | |
| download | musl-61b1d102129990f6e903c6ddcf46c7d79d1a1e99.tar.gz musl-61b1d102129990f6e903c6ddcf46c7d79d1a1e99.tar.xz musl-61b1d102129990f6e903c6ddcf46c7d79d1a1e99.zip | |
fix failure of fchmodat to report EOPNOTSUPP in the race path
in the case where a non-symlink file was replaced by a symlink during the fchmodat operation with AT_SYMLINK_NOFOLLOW, mode change on the new symlink target was successfully suppressed, but the error was not reported. instead, fchmodat simply returned 0.
Diffstat (limited to 'src/stat/fchmodat.c')
| -rw-r--r-- | src/stat/fchmodat.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/stat/fchmodat.c b/src/stat/fchmodat.c index a894cb69..d94667ae 100644 --- a/src/stat/fchmodat.c +++ b/src/stat/fchmodat.c @@ -29,8 +29,10 @@ int fchmodat(int fd, const char *path, mode_t mode, int flag) __procfdname(proc, fd2); ret = __syscall(SYS_fstatat, AT_FDCWD, proc, &st, 0); - if (!ret && !S_ISLNK(st.st_mode)) - ret = __syscall(SYS_fchmodat, AT_FDCWD, proc, mode); + if (!ret) { + if (S_ISLNK(st.st_mode)) ret = -EOPNOTSUPP; + else ret = __syscall(SYS_fchmodat, AT_FDCWD, proc, mode); + } __syscall(SYS_close, fd2); return __syscall_ret(ret); |