diff options
author | Rich Felker <dalias@aerifal.cx> | 2011-05-07 23:23:58 -0400 |
---|---|---|
committer | Rich Felker <dalias@aerifal.cx> | 2011-05-07 23:23:58 -0400 |
commit | 99b8a25e941e54537bf39ca2f265c345f393f112 (patch) | |
tree | 758faba1a20af40b5d09221d008eddbc704636fa /src/signal/sigismember.c | |
parent | 77f15d108ee021d4dfbeebe793661131c4470d4d (diff) | |
download | musl-99b8a25e941e54537bf39ca2f265c345f393f112.tar.gz musl-99b8a25e941e54537bf39ca2f265c345f393f112.tar.xz musl-99b8a25e941e54537bf39ca2f265c345f393f112.zip |
overhaul implementation-internal signal protections
the new approach relies on the fact that the only ways to create sigset_t objects without invoking UB are to use the sig*set() functions, or from the masks returned by sigprocmask, sigaction, etc. or in the ucontext_t argument to a signal handler. thus, as long as sigfillset and sigaddset avoid adding the "protected" signals, there is no way the application will ever obtain a sigset_t including these bits, and thus no need to add the overhead of checking/clearing them when sigprocmask or sigaction is called. note that the old code actually *failed* to remove the bits from sa_mask when sigaction was called. the new implementations are also significantly smaller, simpler, and faster due to ignoring the useless "GNU HURD signals" 65-1024, which are not used and, if there's any sanity in the world, never will be used.
Diffstat (limited to 'src/signal/sigismember.c')
-rw-r--r-- | src/signal/sigismember.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/signal/sigismember.c b/src/signal/sigismember.c index afd29e52..d3de6efb 100644 --- a/src/signal/sigismember.c +++ b/src/signal/sigismember.c @@ -4,7 +4,7 @@ int sigismember(const sigset_t *set, int sig) { unsigned s = sig-1; - if (s >= 8*sizeof(sigset_t)) { + if (s >= 8*sizeof(sigset_t) || s-32U<3) { errno = EINVAL; return -1; } |