diff options
author | Rich Felker <dalias@aerifal.cx> | 2015-04-21 13:50:11 -0400 |
---|---|---|
committer | Rich Felker <dalias@aerifal.cx> | 2015-04-21 13:54:58 -0400 |
commit | 873e0ec7fc4d466cfcdec16a7648cc18609ba702 (patch) | |
tree | 7914da6362c779c2597973a13b03dbd2800932ab /src/locale/codepages.h | |
parent | a6274a1971b7aa1d12fdce3d040f847539a71049 (diff) | |
download | musl-873e0ec7fc4d466cfcdec16a7648cc18609ba702.tar.gz musl-873e0ec7fc4d466cfcdec16a7648cc18609ba702.tar.xz musl-873e0ec7fc4d466cfcdec16a7648cc18609ba702.zip |
fix duplocale clobbering of new locale struct with memcpy of old
when the non-stub duplocale code was added as part of the locale framework in commit 0bc03091bb674ebb9fa6fe69e4aec1da3ac484f2, the old code to memcpy the old locale object to the new one was left behind. the conditional for the memcpy no longer makes sense, because the conditions are now always-true when it's reached, and the memcpy is wrong because it clobbers the new->messages_name pointer setup just above. since the messages_name and ctype_utf8 members have already been copied, all that remains is the cat[] array. these pointers are volatile, so using memcpy to copy them is formally wrong; use a for loop instead.
Diffstat (limited to 'src/locale/codepages.h')
0 files changed, 0 insertions, 0 deletions