diff options
author | Szabolcs Nagy <nsz@port70.net> | 2014-05-30 08:47:35 +0200 |
---|---|---|
committer | Rich Felker <dalias@aerifal.cx> | 2014-06-06 17:57:36 -0400 |
commit | 94100a0115af03d478c93b8875aae0409a62186f (patch) | |
tree | e4b9b62da4a6ba1e0c4b8328c52c7e92eaea458f /src/internal | |
parent | 94a2c04c906188a9ec0e990179a033ec91c1f988 (diff) | |
download | musl-94100a0115af03d478c93b8875aae0409a62186f.tar.gz musl-94100a0115af03d478c93b8875aae0409a62186f.tar.xz musl-94100a0115af03d478c93b8875aae0409a62186f.zip |
fix for broken kernel side RLIM_INFINITY on mips
On 32 bit mips the kernel uses -1UL/2 to mark RLIM_INFINITY (and this is the definition in the userspace api), but since it is in the middle of the valid range of limits and limits are often compared with relational operators, various kernel side logic is broken if larger than -1UL/2 limits are used. So we truncate the limits to -1UL/2 in get/setrlimit and prlimit. Even if the kernel side logic consistently treated -1UL/2 as greater than any other limit value, there wouldn't be any clean workaround that allowed using large limits: * using -1UL/2 as RLIM_INFINITY in userspace would mean different infinity value for get/setrlimt and prlimit (where infinity is always -1ULL) and userspace logic could break easily (just like the kernel is broken now) and more special case code would be needed for mips. * translating -1UL/2 kernel side value to -1ULL in userspace would mean that -1UL/2 limit cannot be set (eg. -1UL/2+1 had to be passed to the kernel instead). (cherry picked from commit 8258014fd1e34e942a549c88c7e022a00445c352)
Diffstat (limited to 'src/internal')
-rw-r--r-- | src/internal/syscall.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/internal/syscall.h b/src/internal/syscall.h index d0fe107e..1c73d0de 100644 --- a/src/internal/syscall.h +++ b/src/internal/syscall.h @@ -4,6 +4,10 @@ #include <sys/syscall.h> #include "syscall_arch.h" +#ifndef SYSCALL_RLIM_INFINITY +#define SYSCALL_RLIM_INFINITY (~0ULL) +#endif + #ifndef __scc #define __scc(X) ((long) (X)) typedef long syscall_arg_t; |