diff options
author | Rich Felker <dalias@aerifal.cx> | 2013-03-04 19:22:14 -0500 |
---|---|---|
committer | Rich Felker <dalias@aerifal.cx> | 2013-03-04 19:22:14 -0500 |
commit | da1442c9a8c58f8ad85a1bd96007f60bc372d157 (patch) | |
tree | 91f94f4aca74c5b625723ba62ef488c0b9fa9982 /arch/mips/bits | |
parent | 8c741783fc96d559cfe79301c924c217b2905c0c (diff) | |
download | musl-da1442c9a8c58f8ad85a1bd96007f60bc372d157.tar.gz musl-da1442c9a8c58f8ad85a1bd96007f60bc372d157.tar.xz musl-da1442c9a8c58f8ad85a1bd96007f60bc372d157.zip |
fix types for wctype_t and wctrans_t
wctype_t was incorrectly "int" rather than "long" on x86_64. not only is this an ABI incompatibility; it's also a major design flaw if we ever wanted wctype_t to be implemented as a pointer, which would be necessary if locales support custom character classes, since int is too small to store a converted pointer. this commit fixes wctype_t to be unsigned long on all archs, matching the LSB ABI; this change does not matter for C code, but for C++ it affects mangling. the same issue applied to wctrans_t. glibc/LSB defines this type as const __int32_t *, but since no such definition is visible, I've just expanded the definition, int, everywhere. it would be nice if these types (which don't vary by arch) could be in wctype.h, but the OB XSI requirement in POSIX that wchar.h expose some types and functions from wctype.h precludes doing so. glibc works around this with some hideous hacks, but trying to duplicate that would go against the intent of musl's headers.
Diffstat (limited to 'arch/mips/bits')
-rwxr-xr-x | arch/mips/bits/alltypes.h.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/mips/bits/alltypes.h.sh b/arch/mips/bits/alltypes.h.sh index c909bc37..2397c6cd 100755 --- a/arch/mips/bits/alltypes.h.sh +++ b/arch/mips/bits/alltypes.h.sh @@ -26,8 +26,8 @@ TYPEDEF __builtin_va_list va_list; TYPEDEF int wchar_t; #endif TYPEDEF int wint_t; -TYPEDEF long wctrans_t; -TYPEDEF long wctype_t; +TYPEDEF const int * wctrans_t; +TYPEDEF unsigned long wctype_t; TYPEDEF signed char int8_t; TYPEDEF short int16_t; |