about summary refs log tree commit diff
diff options
context:
space:
mode:
authorSzabolcs Nagy <nsz@port70.net>2022-02-04 21:04:45 +0100
committerRich Felker <dalias@aerifal.cx>2022-03-08 16:27:15 -0500
commit7c0c7a75ec8ecf3eedefc40bb4dae5aaa76d7108 (patch)
treec787eb03223648195b3b96174cdadc1e0556f382
parentf8bdc3048216f41eaaf655524fa286cfb1184a70 (diff)
downloadmusl-7c0c7a75ec8ecf3eedefc40bb4dae5aaa76d7108.tar.gz
musl-7c0c7a75ec8ecf3eedefc40bb4dae5aaa76d7108.tar.xz
musl-7c0c7a75ec8ecf3eedefc40bb4dae5aaa76d7108.zip
math: avoid runtime conversions of floating-point constants
gcc-12 with -frounding-mode will do inexact constant conversions at
runtime according to the runtime rounding mode.

in the math library we want constants to be rounding mode independent
so this patch fixes cases where new runtime conversions happen with
gcc-12.

fortunately this only affects two minor cases, the fix uses global
initializers where rounding mode does not apply.

after the patch the same amount of conversions happen with gcc-12 as
with gcc-11.
-rw-r--r--src/complex/cacosf.c4
-rw-r--r--src/complex/catanf.c4
2 files changed, 6 insertions, 2 deletions
diff --git a/src/complex/cacosf.c b/src/complex/cacosf.c
index 2e048540..ed8acf0f 100644
--- a/src/complex/cacosf.c
+++ b/src/complex/cacosf.c
@@ -2,8 +2,10 @@
 
 // FIXME
 
+static const float float_pi_2 = M_PI_2;
+
 float complex cacosf(float complex z)
 {
 	z = casinf(z);
-	return CMPLXF((float)M_PI_2 - crealf(z), -cimagf(z));
+	return CMPLXF(float_pi_2 - crealf(z), -cimagf(z));
 }
diff --git a/src/complex/catanf.c b/src/complex/catanf.c
index ef3907a5..1d569f2d 100644
--- a/src/complex/catanf.c
+++ b/src/complex/catanf.c
@@ -61,13 +61,15 @@ static const double DP1 = 3.140625;
 static const double DP2 = 9.67502593994140625E-4;
 static const double DP3 = 1.509957990978376432E-7;
 
+static const float float_pi = M_PI;
+
 static float _redupif(float xx)
 {
 	float x, t;
 	long i;
 
 	x = xx;
-	t = x/(float)M_PI;
+	t = x/float_pi;
 	if (t >= 0.0f)
 		t += 0.5f;
 	else