about summary refs log tree commit diff
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2018-05-04 13:18:51 -0400
committerRich Felker <dalias@aerifal.cx>2018-05-04 13:18:51 -0400
commit4df42163511182bfd6fc55e85250b93786dcce7e (patch)
tree7ba21ccd873265550a2043a5b904cc94e358b179
parent9e2d820a555e150df462f88c901fcbe25d692a8b (diff)
downloadmusl-4df42163511182bfd6fc55e85250b93786dcce7e.tar.gz
musl-4df42163511182bfd6fc55e85250b93786dcce7e.tar.xz
musl-4df42163511182bfd6fc55e85250b93786dcce7e.zip
remove incorrect ESRCH error from pthread_kill
posix documents in the rationale and future directions for
pthread_kill that, since the lifetime of the thread id for a joinable
thread lasts until it is joined, ESRCH is not a correct error for
pthread_kill to produce when the target thread has exited but not yet
been joined, and that conforming applications cannot attempt to detect
this state. future versions of the standard may explicitly require
that ESRCH not be returned for this case.
-rw-r--r--src/thread/pthread_kill.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/thread/pthread_kill.c b/src/thread/pthread_kill.c
index f0903420..0a139231 100644
--- a/src/thread/pthread_kill.c
+++ b/src/thread/pthread_kill.c
@@ -4,7 +4,8 @@ int pthread_kill(pthread_t t, int sig)
 {
 	int r;
 	LOCK(t->killlock);
-	r = t->dead ? ESRCH : -__syscall(SYS_tkill, t->tid, sig);
+	r = t->dead ? (sig+0U >= _NSIG ? EINVAL : 0)
+		: -__syscall(SYS_tkill, t->tid, sig);
 	UNLOCK(t->killlock);
 	return r;
 }