about summary refs log tree commit diff
diff options
context:
space:
mode:
authorrofl0r <retnyg@gmx.net>2013-04-05 22:08:03 +0200
committerrofl0r <retnyg@gmx.net>2013-04-05 22:08:03 +0200
commit69a1983872c819b8c63b9cebfa07fe7d1726e91f (patch)
tree304301466ac35edf8d88185397b3bf64e7c2b961
parentc82f53f67cb256e0096c8649235028b6613b9a22 (diff)
downloadmusl-69a1983872c819b8c63b9cebfa07fe7d1726e91f.tar.gz
musl-69a1983872c819b8c63b9cebfa07fe7d1726e91f.tar.xz
musl-69a1983872c819b8c63b9cebfa07fe7d1726e91f.zip
getifaddrs: one less indent level
-rw-r--r--src/network/getifaddrs.c58
1 files changed, 28 insertions, 30 deletions
diff --git a/src/network/getifaddrs.c b/src/network/getifaddrs.c
index 50eaee80..c7362639 100644
--- a/src/network/getifaddrs.c
+++ b/src/network/getifaddrs.c
@@ -137,39 +137,37 @@ int getifaddrs(struct ifaddrs **ifap)
 	struct ifreq reqs[32]; /* arbitrary chosen boundary */
 	struct ifconf conf = {.ifc_len = sizeof reqs, .ifc_req = reqs};
 	if(-1 == ioctl(sock, SIOCGIFCONF, &conf)) goto err;
-	else {
-		size_t reqitems = conf.ifc_len / sizeof(struct ifreq);
-		for(head = list; head; head = (stor*)head->next) {
-			size_t i;
-			for(i = 0; i < reqitems; i++) {
-				// get SIOCGIFADDR of active interfaces.
-				if(!strcmp(reqs[i].ifr_name, head->name)) {
-					head->addr.v4 = *(struct sockaddr_in*)&reqs[i].ifr_addr;
-					head->ifa.ifa_addr = (struct sockaddr*) &head->addr;
-					break;
-				}
+	size_t reqitems = conf.ifc_len / sizeof(struct ifreq);
+	for(head = list; head; head = (stor*)head->next) {
+		size_t i;
+		for(i = 0; i < reqitems; i++) {
+			// get SIOCGIFADDR of active interfaces.
+			if(!strcmp(reqs[i].ifr_name, head->name)) {
+				head->addr.v4 = *(struct sockaddr_in*)&reqs[i].ifr_addr;
+				head->ifa.ifa_addr = (struct sockaddr*) &head->addr;
+				break;
 			}
-			struct ifreq req;
-			snprintf(req.ifr_name, sizeof req.ifr_name, "%s", head->name);
-			if(-1 == ioctl(sock, SIOCGIFFLAGS, &req)) goto err;
+		}
+		struct ifreq req;
+		snprintf(req.ifr_name, sizeof req.ifr_name, "%s", head->name);
+		if(-1 == ioctl(sock, SIOCGIFFLAGS, &req)) goto err;
 
-			head->ifa.ifa_flags = req.ifr_flags;
-			if(head->ifa.ifa_addr) {
-				/* or'ing flags with IFF_LOWER_UP on active interfaces to mimic glibc */
-				head->ifa.ifa_flags |= IFF_LOWER_UP; 
-				if(-1 == ioctl(sock, SIOCGIFNETMASK, &req)) goto err;
-				head->netmask.v4 = *(struct sockaddr_in*)&req.ifr_netmask;
-				head->ifa.ifa_netmask = (struct sockaddr*) &head->netmask;
-		
-				if(head->ifa.ifa_flags & IFF_POINTOPOINT) {
-					if(-1 == ioctl(sock, SIOCGIFDSTADDR, &req)) goto err;
-					head->dst.v4 = *(struct sockaddr_in*)&req.ifr_dstaddr;
-				} else {
-					if(-1 == ioctl(sock, SIOCGIFBRDADDR, &req)) goto err;
-					head->dst.v4 = *(struct sockaddr_in*)&req.ifr_broadaddr;
-				}
-				head->ifa.ifa_ifu.ifu_dstaddr = (struct sockaddr*) &head->dst;
+		head->ifa.ifa_flags = req.ifr_flags;
+		if(head->ifa.ifa_addr) {
+			/* or'ing flags with IFF_LOWER_UP on active interfaces to mimic glibc */
+			head->ifa.ifa_flags |= IFF_LOWER_UP; 
+			if(-1 == ioctl(sock, SIOCGIFNETMASK, &req)) goto err;
+			head->netmask.v4 = *(struct sockaddr_in*)&req.ifr_netmask;
+			head->ifa.ifa_netmask = (struct sockaddr*) &head->netmask;
+	
+			if(head->ifa.ifa_flags & IFF_POINTOPOINT) {
+				if(-1 == ioctl(sock, SIOCGIFDSTADDR, &req)) goto err;
+				head->dst.v4 = *(struct sockaddr_in*)&req.ifr_dstaddr;
+			} else {
+				if(-1 == ioctl(sock, SIOCGIFBRDADDR, &req)) goto err;
+				head->dst.v4 = *(struct sockaddr_in*)&req.ifr_broadaddr;
 			}
+			head->ifa.ifa_ifu.ifu_dstaddr = (struct sockaddr*) &head->dst;
 		}
 	}
 	close(sock);