From 69beb5cbf85cae1c61fe7432500ac10880dc7b07 Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Mon, 31 Aug 2020 11:53:51 -0300 Subject: string: Fix strerrorname_np return value [BZ #26555] It returns the string of the error constant, not its description (as strerrordesc_np). To handle the Hurd error mapping, the ERR_MAP was removed from errlist.h to errlist.c. Also, the testcase test-strerr (added on 325081b9eb2) was not added on the check build neither it builds correctly. This patch also changed it to decouple from errlist.h, the expected return values are added explicitly for both both strerrorname_np and strerrordesc_np directly. Checked on x86_64-linux-gnu and i686-linux-gnu. I also run a make check for i686-gnu. (cherry picked from commit cef95fdc2e4002ee6357d8d40ef73c8d875720e3) --- sysdeps/gnu/errlist.h | 301 +++++++++++++++++++++++++------------------------- 1 file changed, 149 insertions(+), 152 deletions(-) (limited to 'sysdeps') diff --git a/sysdeps/gnu/errlist.h b/sysdeps/gnu/errlist.h index 5d11ed723d..6329e5f393 100644 --- a/sysdeps/gnu/errlist.h +++ b/sysdeps/gnu/errlist.h @@ -1,24 +1,21 @@ -#ifndef ERR_MAP -#define ERR_MAP(value) value -#endif -_S(ERR_MAP(0), N_("Success")) +_S(0, N_("Success")) #ifdef EPERM /* TRANS Only the owner of the file (or other resource) TRANS or processes with special privileges can perform the operation. */ -_S(ERR_MAP(EPERM), N_("Operation not permitted")) +_S(EPERM, N_("Operation not permitted")) #endif #ifdef ENOENT /* TRANS This is a ``file doesn't exist'' error TRANS for ordinary files that are referenced in contexts where they are TRANS expected to already exist. */ -_S(ERR_MAP(ENOENT), N_("No such file or directory")) +_S(ENOENT, N_("No such file or directory")) #endif #ifdef ESRCH /* TRANS No process matches the specified process ID. */ -_S(ERR_MAP(ESRCH), N_("No such process")) +_S(ESRCH, N_("No such process")) #endif #ifdef EINTR /* @@ -29,12 +26,12 @@ TRANS TRANS You can choose to have functions resume after a signal that is handled, TRANS rather than failing with @code{EINTR}; see @ref{Interrupted TRANS Primitives}. */ -_S(ERR_MAP(EINTR), N_("Interrupted system call")) +_S(EINTR, N_("Interrupted system call")) #endif #ifdef EIO /* TRANS Usually used for physical read or write errors. */ -_S(ERR_MAP(EIO), N_("Input/output error")) +_S(EIO, N_("Input/output error")) #endif #ifdef ENXIO /* @@ -43,7 +40,7 @@ TRANS represented by a file you specified, and it couldn't find the device. TRANS This can mean that the device file was installed incorrectly, or that TRANS the physical device is missing or not correctly attached to the TRANS computer. */ -_S(ERR_MAP(ENXIO), N_("No such device or address")) +_S(ENXIO, N_("No such device or address")) #endif #ifdef E2BIG /* @@ -51,27 +48,27 @@ TRANS Used when the arguments passed to a new program TRANS being executed with one of the @code{exec} functions (@pxref{Executing a TRANS File}) occupy too much memory space. This condition never arises on TRANS @gnuhurdsystems{}. */ -_S(ERR_MAP(E2BIG), N_("Argument list too long")) +_S(E2BIG, N_("Argument list too long")) #endif #ifdef ENOEXEC /* TRANS Invalid executable file format. This condition is detected by the TRANS @code{exec} functions; see @ref{Executing a File}. */ -_S(ERR_MAP(ENOEXEC), N_("Exec format error")) +_S(ENOEXEC, N_("Exec format error")) #endif #ifdef EBADF /* TRANS For example, I/O on a descriptor that has been TRANS closed or reading from a descriptor open only for writing (or vice TRANS versa). */ -_S(ERR_MAP(EBADF), N_("Bad file descriptor")) +_S(EBADF, N_("Bad file descriptor")) #endif #ifdef ECHILD /* TRANS This error happens on operations that are TRANS supposed to manipulate child processes, when there aren't any processes TRANS to manipulate. */ -_S(ERR_MAP(ECHILD), N_("No child processes")) +_S(ECHILD, N_("No child processes")) #endif #ifdef EDEADLK /* @@ -79,74 +76,74 @@ TRANS Allocating a system resource would have resulted in a TRANS deadlock situation. The system does not guarantee that it will notice TRANS all such situations. This error means you got lucky and the system TRANS noticed; it might just hang. @xref{File Locks}, for an example. */ -_S(ERR_MAP(EDEADLK), N_("Resource deadlock avoided")) +_S(EDEADLK, N_("Resource deadlock avoided")) #endif #ifdef ENOMEM /* TRANS The system cannot allocate more virtual memory TRANS because its capacity is full. */ -_S(ERR_MAP(ENOMEM), N_("Cannot allocate memory")) +_S(ENOMEM, N_("Cannot allocate memory")) #endif #ifdef EACCES /* TRANS The file permissions do not allow the attempted operation. */ -_S(ERR_MAP(EACCES), N_("Permission denied")) +_S(EACCES, N_("Permission denied")) #endif #ifdef EFAULT /* TRANS An invalid pointer was detected. TRANS On @gnuhurdsystems{}, this error never happens; you get a signal instead. */ -_S(ERR_MAP(EFAULT), N_("Bad address")) +_S(EFAULT, N_("Bad address")) #endif #ifdef ENOTBLK /* TRANS A file that isn't a block special file was given in a situation that TRANS requires one. For example, trying to mount an ordinary file as a file TRANS system in Unix gives this error. */ -_S(ERR_MAP(ENOTBLK), N_("Block device required")) +_S(ENOTBLK, N_("Block device required")) #endif #ifdef EBUSY /* TRANS A system resource that can't be shared is already in use. TRANS For example, if you try to delete a file that is the root of a currently TRANS mounted filesystem, you get this error. */ -_S(ERR_MAP(EBUSY), N_("Device or resource busy")) +_S(EBUSY, N_("Device or resource busy")) #endif #ifdef EEXIST /* TRANS An existing file was specified in a context where it only TRANS makes sense to specify a new file. */ -_S(ERR_MAP(EEXIST), N_("File exists")) +_S(EEXIST, N_("File exists")) #endif #ifdef EXDEV /* TRANS An attempt to make an improper link across file systems was detected. TRANS This happens not only when you use @code{link} (@pxref{Hard Links}) but TRANS also when you rename a file with @code{rename} (@pxref{Renaming Files}). */ -_S(ERR_MAP(EXDEV), N_("Invalid cross-device link")) +_S(EXDEV, N_("Invalid cross-device link")) #endif #ifdef ENODEV /* TRANS The wrong type of device was given to a function that expects a TRANS particular sort of device. */ -_S(ERR_MAP(ENODEV), N_("No such device")) +_S(ENODEV, N_("No such device")) #endif #ifdef ENOTDIR /* TRANS A file that isn't a directory was specified when a directory is required. */ -_S(ERR_MAP(ENOTDIR), N_("Not a directory")) +_S(ENOTDIR, N_("Not a directory")) #endif #ifdef EISDIR /* TRANS You cannot open a directory for writing, TRANS or create or remove hard links to it. */ -_S(ERR_MAP(EISDIR), N_("Is a directory")) +_S(EISDIR, N_("Is a directory")) #endif #ifdef EINVAL /* TRANS This is used to indicate various kinds of problems TRANS with passing the wrong argument to a library function. */ -_S(ERR_MAP(EINVAL), N_("Invalid argument")) +_S(EINVAL, N_("Invalid argument")) #endif #ifdef EMFILE /* @@ -157,20 +154,20 @@ TRANS In BSD and GNU, the number of open files is controlled by a resource TRANS limit that can usually be increased. If you get this error, you might TRANS want to increase the @code{RLIMIT_NOFILE} limit or make it unlimited; TRANS @pxref{Limits on Resources}. */ -_S(ERR_MAP(EMFILE), N_("Too many open files")) +_S(EMFILE, N_("Too many open files")) #endif #ifdef ENFILE /* TRANS There are too many distinct file openings in the entire system. Note TRANS that any number of linked channels count as just one file opening; see TRANS @ref{Linked Channels}. This error never occurs on @gnuhurdsystems{}. */ -_S(ERR_MAP(ENFILE), N_("Too many open files in system")) +_S(ENFILE, N_("Too many open files in system")) #endif #ifdef ENOTTY /* TRANS Inappropriate I/O control operation, such as trying to set terminal TRANS modes on an ordinary file. */ -_S(ERR_MAP(ENOTTY), N_("Inappropriate ioctl for device")) +_S(ENOTTY, N_("Inappropriate ioctl for device")) #endif #ifdef ETXTBSY /* @@ -179,35 +176,35 @@ TRANS write to a file that is currently being executed. Often using a TRANS debugger to run a program is considered having it open for writing and TRANS will cause this error. (The name stands for ``text file busy''.) This TRANS is not an error on @gnuhurdsystems{}; the text is copied as necessary. */ -_S(ERR_MAP(ETXTBSY), N_("Text file busy")) +_S(ETXTBSY, N_("Text file busy")) #endif #ifdef EFBIG /* TRANS The size of a file would be larger than allowed by the system. */ -_S(ERR_MAP(EFBIG), N_("File too large")) +_S(EFBIG, N_("File too large")) #endif #ifdef ENOSPC /* TRANS Write operation on a file failed because the TRANS disk is full. */ -_S(ERR_MAP(ENOSPC), N_("No space left on device")) +_S(ENOSPC, N_("No space left on device")) #endif #ifdef ESPIPE /* TRANS Invalid seek operation (such as on a pipe). */ -_S(ERR_MAP(ESPIPE), N_("Illegal seek")) +_S(ESPIPE, N_("Illegal seek")) #endif #ifdef EROFS /* TRANS An attempt was made to modify something on a read-only file system. */ -_S(ERR_MAP(EROFS), N_("Read-only file system")) +_S(EROFS, N_("Read-only file system")) #endif #ifdef EMLINK /* TRANS The link count of a single file would become too large. TRANS @code{rename} can cause this error if the file being renamed already has TRANS as many links as it can take (@pxref{Renaming Files}). */ -_S(ERR_MAP(EMLINK), N_("Too many links")) +_S(EMLINK, N_("Too many links")) #endif #ifdef EPIPE /* @@ -216,19 +213,19 @@ TRANS Every library function that returns this error code also generates a TRANS @code{SIGPIPE} signal; this signal terminates the program if not handled TRANS or blocked. Thus, your program will never actually see @code{EPIPE} TRANS unless it has handled or blocked @code{SIGPIPE}. */ -_S(ERR_MAP(EPIPE), N_("Broken pipe")) +_S(EPIPE, N_("Broken pipe")) #endif #ifdef EDOM /* TRANS Used by mathematical functions when an argument value does TRANS not fall into the domain over which the function is defined. */ -_S(ERR_MAP(EDOM), N_("Numerical argument out of domain")) +_S(EDOM, N_("Numerical argument out of domain")) #endif #ifdef ERANGE /* TRANS Used by mathematical functions when the result value is TRANS not representable because of overflow or underflow. */ -_S(ERR_MAP(ERANGE), N_("Numerical result out of range")) +_S(ERANGE, N_("Numerical result out of range")) #endif #ifdef EAGAIN /* @@ -261,7 +258,7 @@ TRANS Such shortages are usually fairly serious and affect the whole system, TRANS so usually an interactive program should report the error to the user TRANS and return to its command loop. TRANS @end itemize */ -_S(ERR_MAP(EAGAIN), N_("Resource temporarily unavailable")) +_S(EAGAIN, N_("Resource temporarily unavailable")) #endif #ifdef EINPROGRESS /* @@ -273,47 +270,47 @@ TRANS the operation has begun and will take some time. Attempts to manipulate TRANS the object before the call completes return @code{EALREADY}. You can TRANS use the @code{select} function to find out when the pending operation TRANS has completed; @pxref{Waiting for I/O}. */ -_S(ERR_MAP(EINPROGRESS), N_("Operation now in progress")) +_S(EINPROGRESS, N_("Operation now in progress")) #endif #ifdef EALREADY /* TRANS An operation is already in progress on an object that has non-blocking TRANS mode selected. */ -_S(ERR_MAP(EALREADY), N_("Operation already in progress")) +_S(EALREADY, N_("Operation already in progress")) #endif #ifdef ENOTSOCK /* TRANS A file that isn't a socket was specified when a socket is required. */ -_S(ERR_MAP(ENOTSOCK), N_("Socket operation on non-socket")) +_S(ENOTSOCK, N_("Socket operation on non-socket")) #endif #ifdef EMSGSIZE /* TRANS The size of a message sent on a socket was larger than the supported TRANS maximum size. */ -_S(ERR_MAP(EMSGSIZE), N_("Message too long")) +_S(EMSGSIZE, N_("Message too long")) #endif #ifdef EPROTOTYPE /* TRANS The socket type does not support the requested communications protocol. */ -_S(ERR_MAP(EPROTOTYPE), N_("Protocol wrong type for socket")) +_S(EPROTOTYPE, N_("Protocol wrong type for socket")) #endif #ifdef ENOPROTOOPT /* TRANS You specified a socket option that doesn't make sense for the TRANS particular protocol being used by the socket. @xref{Socket Options}. */ -_S(ERR_MAP(ENOPROTOOPT), N_("Protocol not available")) +_S(ENOPROTOOPT, N_("Protocol not available")) #endif #ifdef EPROTONOSUPPORT /* TRANS The socket domain does not support the requested communications protocol TRANS (perhaps because the requested protocol is completely invalid). TRANS @xref{Creating a Socket}. */ -_S(ERR_MAP(EPROTONOSUPPORT), N_("Protocol not supported")) +_S(EPROTONOSUPPORT, N_("Protocol not supported")) #endif #ifdef ESOCKTNOSUPPORT /* TRANS The socket type is not supported. */ -_S(ERR_MAP(ESOCKTNOSUPPORT), N_("Socket type not supported")) +_S(ESOCKTNOSUPPORT, N_("Socket type not supported")) #endif #ifdef EOPNOTSUPP /* @@ -323,71 +320,71 @@ TRANS implemented for all communications protocols. On @gnuhurdsystems{}, this TRANS error can happen for many calls when the object does not support the TRANS particular operation; it is a generic indication that the server knows TRANS nothing to do for that call. */ -_S(ERR_MAP(EOPNOTSUPP), N_("Operation not supported")) +_S(EOPNOTSUPP, N_("Operation not supported")) #endif #ifdef EPFNOSUPPORT /* TRANS The socket communications protocol family you requested is not supported. */ -_S(ERR_MAP(EPFNOSUPPORT), N_("Protocol family not supported")) +_S(EPFNOSUPPORT, N_("Protocol family not supported")) #endif #ifdef EAFNOSUPPORT /* TRANS The address family specified for a socket is not supported; it is TRANS inconsistent with the protocol being used on the socket. @xref{Sockets}. */ -_S(ERR_MAP(EAFNOSUPPORT), N_("Address family not supported by protocol")) +_S(EAFNOSUPPORT, N_("Address family not supported by protocol")) #endif #ifdef EADDRINUSE /* TRANS The requested socket address is already in use. @xref{Socket Addresses}. */ -_S(ERR_MAP(EADDRINUSE), N_("Address already in use")) +_S(EADDRINUSE, N_("Address already in use")) #endif #ifdef EADDRNOTAVAIL /* TRANS The requested socket address is not available; for example, you tried TRANS to give a socket a name that doesn't match the local host name. TRANS @xref{Socket Addresses}. */ -_S(ERR_MAP(EADDRNOTAVAIL), N_("Cannot assign requested address")) +_S(EADDRNOTAVAIL, N_("Cannot assign requested address")) #endif #ifdef ENETDOWN /* TRANS A socket operation failed because the network was down. */ -_S(ERR_MAP(ENETDOWN), N_("Network is down")) +_S(ENETDOWN, N_("Network is down")) #endif #ifdef ENETUNREACH /* TRANS A socket operation failed because the subnet containing the remote host TRANS was unreachable. */ -_S(ERR_MAP(ENETUNREACH), N_("Network is unreachable")) +_S(ENETUNREACH, N_("Network is unreachable")) #endif #ifdef ENETRESET /* TRANS A network connection was reset because the remote host crashed. */ -_S(ERR_MAP(ENETRESET), N_("Network dropped connection on reset")) +_S(ENETRESET, N_("Network dropped connection on reset")) #endif #ifdef ECONNABORTED /* TRANS A network connection was aborted locally. */ -_S(ERR_MAP(ECONNABORTED), N_("Software caused connection abort")) +_S(ECONNABORTED, N_("Software caused connection abort")) #endif #ifdef ECONNRESET /* TRANS A network connection was closed for reasons outside the control of the TRANS local host, such as by the remote machine rebooting or an unrecoverable TRANS protocol violation. */ -_S(ERR_MAP(ECONNRESET), N_("Connection reset by peer")) +_S(ECONNRESET, N_("Connection reset by peer")) #endif #ifdef ENOBUFS /* TRANS The kernel's buffers for I/O operations are all in use. In GNU, this TRANS error is always synonymous with @code{ENOMEM}; you may get one or the TRANS other from network operations. */ -_S(ERR_MAP(ENOBUFS), N_("No buffer space available")) +_S(ENOBUFS, N_("No buffer space available")) #endif #ifdef EISCONN /* TRANS You tried to connect a socket that is already connected. TRANS @xref{Connecting}. */ -_S(ERR_MAP(EISCONN), N_("Transport endpoint is already connected")) +_S(EISCONN, N_("Transport endpoint is already connected")) #endif #ifdef ENOTCONN /* @@ -395,74 +392,74 @@ TRANS The socket is not connected to anything. You get this error when you TRANS try to transmit data over a socket, without first specifying a TRANS destination for the data. For a connectionless socket (for datagram TRANS protocols, such as UDP), you get @code{EDESTADDRREQ} instead. */ -_S(ERR_MAP(ENOTCONN), N_("Transport endpoint is not connected")) +_S(ENOTCONN, N_("Transport endpoint is not connected")) #endif #ifdef EDESTADDRREQ /* TRANS No default destination address was set for the socket. You get this TRANS error when you try to transmit data over a connectionless socket, TRANS without first specifying a destination for the data with @code{connect}. */ -_S(ERR_MAP(EDESTADDRREQ), N_("Destination address required")) +_S(EDESTADDRREQ, N_("Destination address required")) #endif #ifdef ESHUTDOWN /* TRANS The socket has already been shut down. */ -_S(ERR_MAP(ESHUTDOWN), N_("Cannot send after transport endpoint shutdown")) +_S(ESHUTDOWN, N_("Cannot send after transport endpoint shutdown")) #endif #ifdef ETOOMANYREFS -_S(ERR_MAP(ETOOMANYREFS), N_("Too many references: cannot splice")) +_S(ETOOMANYREFS, N_("Too many references: cannot splice")) #endif #ifdef ETIMEDOUT /* TRANS A socket operation with a specified timeout received no response during TRANS the timeout period. */ -_S(ERR_MAP(ETIMEDOUT), N_("Connection timed out")) +_S(ETIMEDOUT, N_("Connection timed out")) #endif #ifdef ECONNREFUSED /* TRANS A remote host refused to allow the network connection (typically because TRANS it is not running the requested service). */ -_S(ERR_MAP(ECONNREFUSED), N_("Connection refused")) +_S(ECONNREFUSED, N_("Connection refused")) #endif #ifdef ELOOP /* TRANS Too many levels of symbolic links were encountered in looking up a file name. TRANS This often indicates a cycle of symbolic links. */ -_S(ERR_MAP(ELOOP), N_("Too many levels of symbolic links")) +_S(ELOOP, N_("Too many levels of symbolic links")) #endif #ifdef ENAMETOOLONG /* TRANS Filename too long (longer than @code{PATH_MAX}; @pxref{Limits for TRANS Files}) or host name too long (in @code{gethostname} or TRANS @code{sethostname}; @pxref{Host Identification}). */ -_S(ERR_MAP(ENAMETOOLONG), N_("File name too long")) +_S(ENAMETOOLONG, N_("File name too long")) #endif #ifdef EHOSTDOWN /* TRANS The remote host for a requested network connection is down. */ -_S(ERR_MAP(EHOSTDOWN), N_("Host is down")) +_S(EHOSTDOWN, N_("Host is down")) #endif /* TRANS The remote host for a requested network connection is not reachable. */ #ifdef EHOSTUNREACH -_S(ERR_MAP(EHOSTUNREACH), N_("No route to host")) +_S(EHOSTUNREACH, N_("No route to host")) #endif #ifdef ENOTEMPTY /* TRANS Directory not empty, where an empty directory was expected. Typically, TRANS this error occurs when you are trying to delete a directory. */ -_S(ERR_MAP(ENOTEMPTY), N_("Directory not empty")) +_S(ENOTEMPTY, N_("Directory not empty")) #endif #ifdef EUSERS /* TRANS The file quota system is confused because there are too many users. TRANS @c This can probably happen in a GNU system when using NFS. */ -_S(ERR_MAP(EUSERS), N_("Too many users")) +_S(EUSERS, N_("Too many users")) #endif #ifdef EDQUOT /* TRANS The user's disk quota was exceeded. */ -_S(ERR_MAP(EDQUOT), N_("Disk quota exceeded")) +_S(EDQUOT, N_("Disk quota exceeded")) #endif #ifdef ESTALE /* @@ -471,7 +468,7 @@ TRANS file system which is due to file system rearrangements on the server host TRANS for NFS file systems or corruption in other file systems. TRANS Repairing this condition usually requires unmounting, possibly repairing TRANS and remounting the file system. */ -_S(ERR_MAP(ESTALE), N_("Stale file handle")) +_S(ESTALE, N_("Stale file handle")) #endif #ifdef EREMOTE /* @@ -479,7 +476,7 @@ TRANS An attempt was made to NFS-mount a remote file system with a file name tha TRANS already specifies an NFS-mounted file. TRANS (This is an error on some operating systems, but we expect it to work TRANS properly on @gnuhurdsystems{}, making this error code impossible.) */ -_S(ERR_MAP(EREMOTE), N_("Object is remote")) +_S(EREMOTE, N_("Object is remote")) #endif #ifdef ENOLCK /* @@ -487,7 +484,7 @@ TRANS This is used by the file locking facilities; see TRANS @ref{File Locks}. This error is never generated by @gnuhurdsystems{}, but TRANS it can result from an operation to an NFS server running another TRANS operating system. */ -_S(ERR_MAP(ENOLCK), N_("No locks available")) +_S(ENOLCK, N_("No locks available")) #endif #ifdef ENOSYS /* @@ -496,46 +493,46 @@ TRANS not implemented at all, either in the C library itself or in the TRANS operating system. When you get this error, you can be sure that this TRANS particular function will always fail with @code{ENOSYS} unless you TRANS install a new version of the C library or the operating system. */ -_S(ERR_MAP(ENOSYS), N_("Function not implemented")) +_S(ENOSYS, N_("Function not implemented")) #endif #ifdef EILSEQ /* TRANS While decoding a multibyte character the function came along an invalid TRANS or an incomplete sequence of bytes or the given wide character is invalid. */ -_S(ERR_MAP(EILSEQ), N_("Invalid or incomplete multibyte or wide character")) +_S(EILSEQ, N_("Invalid or incomplete multibyte or wide character")) #endif #ifdef EBADMSG -_S(ERR_MAP(EBADMSG), N_("Bad message")) +_S(EBADMSG, N_("Bad message")) #endif #ifdef EIDRM -_S(ERR_MAP(EIDRM), N_("Identifier removed")) +_S(EIDRM, N_("Identifier removed")) #endif #ifdef EMULTIHOP -_S(ERR_MAP(EMULTIHOP), N_("Multihop attempted")) +_S(EMULTIHOP, N_("Multihop attempted")) #endif #ifdef ENODATA -_S(ERR_MAP(ENODATA), N_("No data available")) +_S(ENODATA, N_("No data available")) #endif #ifdef ENOLINK -_S(ERR_MAP(ENOLINK), N_("Link has been severed")) +_S(ENOLINK, N_("Link has been severed")) #endif #ifdef ENOMSG -_S(ERR_MAP(ENOMSG), N_("No message of desired type")) +_S(ENOMSG, N_("No message of desired type")) #endif #ifdef ENOSR -_S(ERR_MAP(ENOSR), N_("Out of streams resources")) +_S(ENOSR, N_("Out of streams resources")) #endif #ifdef ENOSTR -_S(ERR_MAP(ENOSTR), N_("Device not a stream")) +_S(ENOSTR, N_("Device not a stream")) #endif #ifdef EOVERFLOW -_S(ERR_MAP(EOVERFLOW), N_("Value too large for defined data type")) +_S(EOVERFLOW, N_("Value too large for defined data type")) #endif #ifdef EPROTO -_S(ERR_MAP(EPROTO), N_("Protocol error")) +_S(EPROTO, N_("Protocol error")) #endif #ifdef ETIME -_S(ERR_MAP(ETIME), N_("Timer expired")) +_S(ETIME, N_("Timer expired")) #endif #ifdef ECANCELED /* @@ -543,148 +540,148 @@ TRANS An asynchronous operation was canceled before it TRANS completed. @xref{Asynchronous I/O}. When you call @code{aio_cancel}, TRANS the normal result is for the operations affected to complete with this TRANS error; @pxref{Cancel AIO Operations}. */ -_S(ERR_MAP(ECANCELED), N_("Operation canceled")) +_S(ECANCELED, N_("Operation canceled")) #endif #ifdef EOWNERDEAD -_S(ERR_MAP(EOWNERDEAD), N_("Owner died")) +_S(EOWNERDEAD, N_("Owner died")) #endif #ifdef ENOTRECOVERABLE -_S(ERR_MAP(ENOTRECOVERABLE), N_("State not recoverable")) +_S(ENOTRECOVERABLE, N_("State not recoverable")) #endif #ifdef ERESTART -_S(ERR_MAP(ERESTART), N_("Interrupted system call should be restarted")) +_S(ERESTART, N_("Interrupted system call should be restarted")) #endif #ifdef ECHRNG -_S(ERR_MAP(ECHRNG), N_("Channel number out of range")) +_S(ECHRNG, N_("Channel number out of range")) #endif #ifdef EL2NSYNC -_S(ERR_MAP(EL2NSYNC), N_("Level 2 not synchronized")) +_S(EL2NSYNC, N_("Level 2 not synchronized")) #endif #ifdef EL3HLT -_S(ERR_MAP(EL3HLT), N_("Level 3 halted")) +_S(EL3HLT, N_("Level 3 halted")) #endif #ifdef EL3RST -_S(ERR_MAP(EL3RST), N_("Level 3 reset")) +_S(EL3RST, N_("Level 3 reset")) #endif #ifdef ELNRNG -_S(ERR_MAP(ELNRNG), N_("Link number out of range")) +_S(ELNRNG, N_("Link number out of range")) #endif #ifdef EUNATCH -_S(ERR_MAP(EUNATCH), N_("Protocol driver not attached")) +_S(EUNATCH, N_("Protocol driver not attached")) #endif #ifdef ENOCSI -_S(ERR_MAP(ENOCSI), N_("No CSI structure available")) +_S(ENOCSI, N_("No CSI structure available")) #endif #ifdef EL2HLT -_S(ERR_MAP(EL2HLT), N_("Level 2 halted")) +_S(EL2HLT, N_("Level 2 halted")) #endif #ifdef EBADE -_S(ERR_MAP(EBADE), N_("Invalid exchange")) +_S(EBADE, N_("Invalid exchange")) #endif #ifdef EBADR -_S(ERR_MAP(EBADR), N_("Invalid request descriptor")) +_S(EBADR, N_("Invalid request descriptor")) #endif #ifdef EXFULL -_S(ERR_MAP(EXFULL), N_("Exchange full")) +_S(EXFULL, N_("Exchange full")) #endif #ifdef ENOANO -_S(ERR_MAP(ENOANO), N_("No anode")) +_S(ENOANO, N_("No anode")) #endif #ifdef EBADRQC -_S(ERR_MAP(EBADRQC), N_("Invalid request code")) +_S(EBADRQC, N_("Invalid request code")) #endif #ifdef EBADSLT -_S(ERR_MAP(EBADSLT), N_("Invalid slot")) +_S(EBADSLT, N_("Invalid slot")) #endif #ifdef EBFONT -_S(ERR_MAP(EBFONT), N_("Bad font file format")) +_S(EBFONT, N_("Bad font file format")) #endif #ifdef ENONET -_S(ERR_MAP(ENONET), N_("Machine is not on the network")) +_S(ENONET, N_("Machine is not on the network")) #endif #ifdef ENOPKG -_S(ERR_MAP(ENOPKG), N_("Package not installed")) +_S(ENOPKG, N_("Package not installed")) #endif #ifdef EADV -_S(ERR_MAP(EADV), N_("Advertise error")) +_S(EADV, N_("Advertise error")) #endif #ifdef ESRMNT -_S(ERR_MAP(ESRMNT), N_("Srmount error")) +_S(ESRMNT, N_("Srmount error")) #endif #ifdef ECOMM -_S(ERR_MAP(ECOMM), N_("Communication error on send")) +_S(ECOMM, N_("Communication error on send")) #endif #ifdef EDOTDOT -_S(ERR_MAP(EDOTDOT), N_("RFS specific error")) +_S(EDOTDOT, N_("RFS specific error")) #endif #ifdef ENOTUNIQ -_S(ERR_MAP(ENOTUNIQ), N_("Name not unique on network")) +_S(ENOTUNIQ, N_("Name not unique on network")) #endif #ifdef EBADFD -_S(ERR_MAP(EBADFD), N_("File descriptor in bad state")) +_S(EBADFD, N_("File descriptor in bad state")) #endif #ifdef EREMCHG -_S(ERR_MAP(EREMCHG), N_("Remote address changed")) +_S(EREMCHG, N_("Remote address changed")) #endif #ifdef ELIBACC -_S(ERR_MAP(ELIBACC), N_("Can not access a needed shared library")) +_S(ELIBACC, N_("Can not access a needed shared library")) #endif #ifdef ELIBBAD -_S(ERR_MAP(ELIBBAD), N_("Accessing a corrupted shared library")) +_S(ELIBBAD, N_("Accessing a corrupted shared library")) #endif #ifdef ELIBSCN -_S(ERR_MAP(ELIBSCN), N_(".lib section in a.out corrupted")) +_S(ELIBSCN, N_(".lib section in a.out corrupted")) #endif #ifdef ELIBMAX -_S(ERR_MAP(ELIBMAX), N_("Attempting to link in too many shared libraries")) +_S(ELIBMAX, N_("Attempting to link in too many shared libraries")) #endif #ifdef ELIBEXEC -_S(ERR_MAP(ELIBEXEC), N_("Cannot exec a shared library directly")) +_S(ELIBEXEC, N_("Cannot exec a shared library directly")) #endif #ifdef ESTRPIPE -_S(ERR_MAP(ESTRPIPE), N_("Streams pipe error")) +_S(ESTRPIPE, N_("Streams pipe error")) #endif #ifdef EUCLEAN -_S(ERR_MAP(EUCLEAN), N_("Structure needs cleaning")) +_S(EUCLEAN, N_("Structure needs cleaning")) #endif #ifdef ENOTNAM -_S(ERR_MAP(ENOTNAM), N_("Not a XENIX named type file")) +_S(ENOTNAM, N_("Not a XENIX named type file")) #endif #ifdef ENAVAIL -_S(ERR_MAP(ENAVAIL), N_("No XENIX semaphores available")) +_S(ENAVAIL, N_("No XENIX semaphores available")) #endif #ifdef EISNAM -_S(ERR_MAP(EISNAM), N_("Is a named type file")) +_S(EISNAM, N_("Is a named type file")) #endif #ifdef EREMOTEIO -_S(ERR_MAP(EREMOTEIO), N_("Remote I/O error")) +_S(EREMOTEIO, N_("Remote I/O error")) #endif #ifdef ENOMEDIUM -_S(ERR_MAP(ENOMEDIUM), N_("No medium found")) +_S(ENOMEDIUM, N_("No medium found")) #endif #ifdef EMEDIUMTYPE -_S(ERR_MAP(EMEDIUMTYPE), N_("Wrong medium type")) +_S(EMEDIUMTYPE, N_("Wrong medium type")) #endif #ifdef ENOKEY -_S(ERR_MAP(ENOKEY), N_("Required key not available")) +_S(ENOKEY, N_("Required key not available")) #endif #ifdef EKEYEXPIRED -_S(ERR_MAP(EKEYEXPIRED), N_("Key has expired")) +_S(EKEYEXPIRED, N_("Key has expired")) #endif #ifdef EKEYREVOKED -_S(ERR_MAP(EKEYREVOKED), N_("Key has been revoked")) +_S(EKEYREVOKED, N_("Key has been revoked")) #endif #ifdef EKEYREJECTED -_S(ERR_MAP(EKEYREJECTED), N_("Key was rejected by service")) +_S(EKEYREJECTED, N_("Key was rejected by service")) #endif #ifdef ERFKILL -_S(ERR_MAP(ERFKILL), N_("Operation not possible due to RF-kill")) +_S(ERFKILL, N_("Operation not possible due to RF-kill")) #endif #ifdef EHWPOISON -_S(ERR_MAP(EHWPOISON), N_("Memory page has hardware error")) +_S(EHWPOISON, N_("Memory page has hardware error")) #endif #ifdef EBADRPC -_S(ERR_MAP(EBADRPC), N_("RPC struct is bad")) +_S(EBADRPC, N_("RPC struct is bad")) #endif #ifdef EFTYPE /* @@ -693,40 +690,40 @@ TRANS operation, or a data file had the wrong format. TRANS TRANS On some systems @code{chmod} returns this error if you try to set the TRANS sticky bit on a non-directory file; @pxref{Setting Permissions}. */ -_S(ERR_MAP(EFTYPE), N_("Inappropriate file type or format")) +_S(EFTYPE, N_("Inappropriate file type or format")) #endif #ifdef EPROCUNAVAIL -_S(ERR_MAP(EPROCUNAVAIL), N_("RPC bad procedure for program")) +_S(EPROCUNAVAIL, N_("RPC bad procedure for program")) #endif #ifdef EAUTH -_S(ERR_MAP(EAUTH), N_("Authentication error")) +_S(EAUTH, N_("Authentication error")) #endif #ifdef EDIED /* TRANS On @gnuhurdsystems{}, opening a file returns this error when the file is TRANS translated by a program and the translator program dies while starting TRANS up, before it has connected to the file. */ -_S(ERR_MAP(EDIED), N_("Translator died")) +_S(EDIED, N_("Translator died")) #endif #ifdef ERPCMISMATCH -_S(ERR_MAP(ERPCMISMATCH), N_("RPC version wrong")) +_S(ERPCMISMATCH, N_("RPC version wrong")) #endif #ifdef EGREGIOUS /* TRANS You did @strong{what}? */ -_S(ERR_MAP(EGREGIOUS), N_("You really blew it this time")) +_S(EGREGIOUS, N_("You really blew it this time")) #endif #ifdef EPROCLIM /* TRANS This means that the per-user limit on new process would be exceeded by TRANS an attempted @code{fork}. @xref{Limits on Resources}, for details on TRANS the @code{RLIMIT_NPROC} limit. */ -_S(ERR_MAP(EPROCLIM), N_("Too many processes")) +_S(EPROCLIM, N_("Too many processes")) #endif #ifdef EGRATUITOUS /* TRANS This error code has no purpose. */ -_S(ERR_MAP(EGRATUITOUS), N_("Gratuitous error")) +_S(EGRATUITOUS, N_("Gratuitous error")) #endif #if defined (ENOTSUP) && ENOTSUP != EOPNOTSUPP /* @@ -742,10 +739,10 @@ TRANS values. TRANS TRANS If the entire function is not available at all in the implementation, TRANS it returns @code{ENOSYS} instead. */ -_S(ERR_MAP(ENOTSUP), N_("Not supported")) +_S(ENOTSUP, N_("Not supported")) #endif #ifdef EPROGMISMATCH -_S(ERR_MAP(EPROGMISMATCH), N_("RPC program version wrong")) +_S(EPROGMISMATCH, N_("RPC program version wrong")) #endif #ifdef EBACKGROUND /* @@ -755,7 +752,7 @@ TRANS foreground process group of the terminal. Users do not usually see this TRANS error because functions such as @code{read} and @code{write} translate TRANS it into a @code{SIGTTIN} or @code{SIGTTOU} signal. @xref{Job Control}, TRANS for information on process groups and these signals. */ -_S(ERR_MAP(EBACKGROUND), N_("Inappropriate operation for background process")) +_S(EBACKGROUND, N_("Inappropriate operation for background process")) #endif #ifdef EIEIO /* @@ -773,7 +770,7 @@ TRANS @c "bought the farm" means "died". -jtobey TRANS @c TRANS @c Translators, please do not translate this litteraly, translate it into TRANS @c an idiomatic funny way of saying that the computer died. */ -_S(ERR_MAP(EIEIO), N_("Computer bought the farm")) +_S(EIEIO, N_("Computer bought the farm")) #endif #if defined (EWOULDBLOCK) && EWOULDBLOCK != EAGAIN /* @@ -782,18 +779,18 @@ TRANS The values are always the same, on every operating system. TRANS TRANS C libraries in many older Unix systems have @code{EWOULDBLOCK} as a TRANS separate error code. */ -_S(ERR_MAP(EWOULDBLOCK), N_("Operation would block")) +_S(EWOULDBLOCK, N_("Operation would block")) #endif #ifdef ENEEDAUTH -_S(ERR_MAP(ENEEDAUTH), N_("Need authenticator")) +_S(ENEEDAUTH, N_("Need authenticator")) #endif #ifdef ED /* TRANS The experienced user will know what is wrong. TRANS @c This error code is a joke. Its perror text is part of the joke. TRANS @c Don't change it. */ -_S(ERR_MAP(ED), N_("?")) +_S(ED, N_("?")) #endif #ifdef EPROGUNAVAIL -_S(ERR_MAP(EPROGUNAVAIL), N_("RPC program not available")) +_S(EPROGUNAVAIL, N_("RPC program not available")) #endif -- cgit 1.4.1 From 0f8f0ed25c196cfb93edf461aefdad15314ae05c Mon Sep 17 00:00:00 2001 From: Wilco Dijkstra Date: Fri, 28 Aug 2020 17:51:40 +0100 Subject: AArch64: Improve backwards memmove performance On some microarchitectures performance of the backwards memmove improves if the stores use STR with decreasing addresses. So change the memmove loop in memcpy_advsimd.S to use 2x STR rather than STP. Reviewed-by: Adhemerval Zanella (cherry picked from commit bd394d131c10c9ec22c6424197b79410042eed99) --- sysdeps/aarch64/multiarch/memcpy_advsimd.S | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'sysdeps') diff --git a/sysdeps/aarch64/multiarch/memcpy_advsimd.S b/sysdeps/aarch64/multiarch/memcpy_advsimd.S index d4ba747777..48bb6d7ca4 100644 --- a/sysdeps/aarch64/multiarch/memcpy_advsimd.S +++ b/sysdeps/aarch64/multiarch/memcpy_advsimd.S @@ -223,12 +223,13 @@ L(copy_long_backwards): b.ls L(copy64_from_start) L(loop64_backwards): - stp A_q, B_q, [dstend, -32] + str B_q, [dstend, -16] + str A_q, [dstend, -32] ldp A_q, B_q, [srcend, -96] - stp C_q, D_q, [dstend, -64] + str D_q, [dstend, -48] + str C_q, [dstend, -64]! ldp C_q, D_q, [srcend, -128] sub srcend, srcend, 64 - sub dstend, dstend, 64 subs count, count, 64 b.hi L(loop64_backwards) -- cgit 1.4.1 From 81c5484d93a7768a8acc4cfdc228d925d60cd906 Mon Sep 17 00:00:00 2001 From: Wilco Dijkstra Date: Wed, 14 Oct 2020 13:56:21 +0100 Subject: AArch64: Use __memcpy_simd on Neoverse N2/V1 Add CPU detection of Neoverse N2 and Neoverse V1, and select __memcpy_simd as the memcpy/memmove ifunc. Reviewed-by: Adhemerval Zanella (cherry picked from commit e11ed9d2b4558eeacff81557dc9557001af42a6b) --- sysdeps/aarch64/multiarch/memcpy.c | 3 ++- sysdeps/aarch64/multiarch/memmove.c | 3 ++- sysdeps/unix/sysv/linux/aarch64/cpu-features.h | 4 ++++ 3 files changed, 8 insertions(+), 2 deletions(-) (limited to 'sysdeps') diff --git a/sysdeps/aarch64/multiarch/memcpy.c b/sysdeps/aarch64/multiarch/memcpy.c index 7cf5f033e8..799d60c98c 100644 --- a/sysdeps/aarch64/multiarch/memcpy.c +++ b/sysdeps/aarch64/multiarch/memcpy.c @@ -41,7 +41,8 @@ libc_ifunc (__libc_memcpy, ? __memcpy_falkor : (IS_THUNDERX2 (midr) || IS_THUNDERX2PA (midr) ? __memcpy_thunderx2 - : (IS_NEOVERSE_N1 (midr) + : (IS_NEOVERSE_N1 (midr) || IS_NEOVERSE_N2 (midr) + || IS_NEOVERSE_V1 (midr) ? __memcpy_simd : __memcpy_generic))))); diff --git a/sysdeps/aarch64/multiarch/memmove.c b/sysdeps/aarch64/multiarch/memmove.c index ad10aa8ac6..46a4cb3a54 100644 --- a/sysdeps/aarch64/multiarch/memmove.c +++ b/sysdeps/aarch64/multiarch/memmove.c @@ -41,7 +41,8 @@ libc_ifunc (__libc_memmove, ? __memmove_falkor : (IS_THUNDERX2 (midr) || IS_THUNDERX2PA (midr) ? __memmove_thunderx2 - : (IS_NEOVERSE_N1 (midr) + : (IS_NEOVERSE_N1 (midr) || IS_NEOVERSE_N2 (midr) + || IS_NEOVERSE_V1 (midr) ? __memmove_simd : __memmove_generic))))); diff --git a/sysdeps/unix/sysv/linux/aarch64/cpu-features.h b/sysdeps/unix/sysv/linux/aarch64/cpu-features.h index fc688450ee..00a4d0c8e7 100644 --- a/sysdeps/unix/sysv/linux/aarch64/cpu-features.h +++ b/sysdeps/unix/sysv/linux/aarch64/cpu-features.h @@ -54,6 +54,10 @@ && MIDR_PARTNUM(midr) == 0x000) #define IS_NEOVERSE_N1(midr) (MIDR_IMPLEMENTOR(midr) == 'A' \ && MIDR_PARTNUM(midr) == 0xd0c) +#define IS_NEOVERSE_N2(midr) (MIDR_IMPLEMENTOR(midr) == 'A' \ + && MIDR_PARTNUM(midr) == 0xd49) +#define IS_NEOVERSE_V1(midr) (MIDR_IMPLEMENTOR(midr) == 'A' \ + && MIDR_PARTNUM(midr) == 0xd40) #define IS_EMAG(midr) (MIDR_IMPLEMENTOR(midr) == 'P' \ && MIDR_PARTNUM(midr) == 0x000) -- cgit 1.4.1 From 9b139b6b81a5def91bec01f30301acc95fbf0289 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Tue, 29 Sep 2020 14:10:20 -0300 Subject: sysvipc: Fix SEM_STAT_ANY kernel argument pass [BZ #26637] Handle SEM_STAT_ANY the same way as SEM_STAT so that the buffer argument of SEM_STAT_ANY is properly passed to the kernel and back. The regression testcase checks for Linux specifix SysV ipc message control extension. For IPC_INFO/SEM_INFO it tries to match the values against the tunable /proc values and for SEM_STAT/SEM_STAT_ANY it check if the create message queue is within the global list returned by the kernel. Checked on x86_64-linux-gnu and on i686-linux-gnu (Linux v5.4 and on Linux v4.15). Co-authored-by: Adhemerval Zanella (cherry picked from commit 574500a108be1d2a6a0dc97a075c9e0a98371aba) --- NEWS | 2 + sysdeps/unix/sysv/linux/Makefile | 2 +- sysdeps/unix/sysv/linux/semctl.c | 6 + sysdeps/unix/sysv/linux/tst-sysvsem-linux.c | 184 ++++++++++++++++++++++++++++ sysvipc/test-sysvsem.c | 1 + 5 files changed, 194 insertions(+), 1 deletion(-) create mode 100644 sysdeps/unix/sysv/linux/tst-sysvsem-linux.c (limited to 'sysdeps') diff --git a/NEWS b/NEWS index 3aad30baee..fb3a9e4f7d 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,8 @@ The following bugs are resolved with this release: [26534] libm.so 2.32 SIGILL in pow() due to FMA4 instruction on non-FMA4 system [26555] string: strerrorname_np does not return the documented value + [26637] libc: semctl SEM_STAT_ANY fails to pass the buffer specified + by the caller to the kernel Version 2.32 diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile index 9b2a253032..9b930e7466 100644 --- a/sysdeps/unix/sysv/linux/Makefile +++ b/sysdeps/unix/sysv/linux/Makefile @@ -100,7 +100,7 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \ tst-quota tst-sync_file_range tst-sysconf-iov_max tst-ttyname \ test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \ tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \ - tst-tgkill + tst-tgkill tst-sysvsem-linux tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables diff --git a/sysdeps/unix/sysv/linux/semctl.c b/sysdeps/unix/sysv/linux/semctl.c index f131a26fc7..1cdabde8f2 100644 --- a/sysdeps/unix/sysv/linux/semctl.c +++ b/sysdeps/unix/sysv/linux/semctl.c @@ -102,6 +102,7 @@ semun64_to_ksemun64 (int cmd, union semun64 semun64, r.array = semun64.array; break; case SEM_STAT: + case SEM_STAT_ANY: case IPC_STAT: case IPC_SET: r.buf = buf; @@ -150,6 +151,7 @@ __semctl64 (int semid, int semnum, int cmd, ...) case IPC_STAT: /* arg.buf */ case IPC_SET: case SEM_STAT: + case SEM_STAT_ANY: case IPC_INFO: /* arg.__buf */ case SEM_INFO: va_start (ap, cmd); @@ -238,6 +240,7 @@ semun_to_semun64 (int cmd, union semun semun, struct __semid64_ds *semid64) r.array = semun.array; break; case SEM_STAT: + case SEM_STAT_ANY: case IPC_STAT: case IPC_SET: r.buf = semid64; @@ -267,6 +270,7 @@ __semctl (int semid, int semnum, int cmd, ...) case IPC_STAT: /* arg.buf */ case IPC_SET: case SEM_STAT: + case SEM_STAT_ANY: case IPC_INFO: /* arg.__buf */ case SEM_INFO: va_start (ap, cmd); @@ -321,6 +325,7 @@ __semctl_mode16 (int semid, int semnum, int cmd, ...) case IPC_STAT: /* arg.buf */ case IPC_SET: case SEM_STAT: + case SEM_STAT_ANY: case IPC_INFO: /* arg.__buf */ case SEM_INFO: va_start (ap, cmd); @@ -354,6 +359,7 @@ __old_semctl (int semid, int semnum, int cmd, ...) case IPC_STAT: /* arg.buf */ case IPC_SET: case SEM_STAT: + case SEM_STAT_ANY: case IPC_INFO: /* arg.__buf */ case SEM_INFO: va_start (ap, cmd); diff --git a/sysdeps/unix/sysv/linux/tst-sysvsem-linux.c b/sysdeps/unix/sysv/linux/tst-sysvsem-linux.c new file mode 100644 index 0000000000..45f19e2d37 --- /dev/null +++ b/sysdeps/unix/sysv/linux/tst-sysvsem-linux.c @@ -0,0 +1,184 @@ +/* Basic tests for Linux SYSV semaphore extensions. + Copyright (C) 2020 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include +#include + +#include +#include + +/* These are for the temporary file we generate. */ +static char *name; +static int semid; + +static void +remove_sem (void) +{ + /* Enforce message queue removal in case of early test failure. + Ignore error since the sem may already have being removed. */ + semctl (semid, 0, IPC_RMID, 0); +} + +static void +do_prepare (int argc, char *argv[]) +{ + TEST_VERIFY_EXIT (create_temp_file ("tst-sysvsem.", &name) != -1); +} + +#define PREPARE do_prepare + +#define SEM_MODE 0644 + +union semun +{ + int val; + struct semid_ds *buf; + unsigned short *array; + struct seminfo *__buf; +}; + +struct test_seminfo +{ + int semmsl; + int semmns; + int semopm; + int semmni; +}; + +/* It tries to obtain some system-wide SysV semaphore information from /proc + to check against IPC_INFO/SEM_INFO. The /proc only returns the tunables + value of SEMMSL, SEMMNS, SEMOPM, and SEMMNI. + + The kernel also returns constant value for SEMVMX, SEMMNU, SEMMAP, SEMUME, + and also SEMUSZ and SEMAEM (for IPC_INFO). The issue to check them is they + might change over kernel releases. */ + +static void +read_sem_stat (struct test_seminfo *tseminfo) +{ + FILE *f = fopen ("/proc/sys/kernel/sem", "r"); + if (f == NULL) + FAIL_UNSUPPORTED ("/proc is not mounted or /proc/sys/kernel/sem is not " + "available"); + + int r = fscanf (f, "%d %d %d %d", + &tseminfo->semmsl, &tseminfo->semmns, &tseminfo->semopm, + &tseminfo->semmni); + TEST_VERIFY_EXIT (r == 4); + + fclose (f); +} + + +/* Check if the semaphore with IDX (index into the kernel's internal array) + matches the one with KEY. The CMD is either SEM_STAT or SEM_STAT_ANY. */ + +static bool +check_seminfo (int idx, key_t key, int cmd) +{ + struct semid_ds seminfo; + int sid = semctl (idx, 0, cmd, (union semun) { .buf = &seminfo }); + /* Ignore unused array slot returned by the kernel or information from + unknown semaphores. */ + if ((sid == -1 && errno == EINVAL) || sid != semid) + return false; + + if (sid == -1) + FAIL_EXIT1 ("semctl with SEM_STAT failed (errno=%d)", errno); + + TEST_COMPARE (seminfo.sem_perm.__key, key); + TEST_COMPARE (seminfo.sem_perm.mode, SEM_MODE); + TEST_COMPARE (seminfo.sem_nsems, 1); + + return true; +} + +static int +do_test (void) +{ + atexit (remove_sem); + + key_t key = ftok (name, 'G'); + if (key == -1) + FAIL_EXIT1 ("ftok failed: %m"); + + semid = semget (key, 1, IPC_CREAT | IPC_EXCL | SEM_MODE); + if (semid == -1) + FAIL_EXIT1 ("semget failed: %m"); + + struct test_seminfo tipcinfo; + read_sem_stat (&tipcinfo); + + int semidx; + + { + struct seminfo ipcinfo; + semidx = semctl (semid, 0, IPC_INFO, (union semun) { .__buf = &ipcinfo }); + if (semidx == -1) + FAIL_EXIT1 ("semctl with IPC_INFO failed: %m"); + + TEST_COMPARE (ipcinfo.semmsl, tipcinfo.semmsl); + TEST_COMPARE (ipcinfo.semmns, tipcinfo.semmns); + TEST_COMPARE (ipcinfo.semopm, tipcinfo.semopm); + TEST_COMPARE (ipcinfo.semmni, tipcinfo.semmni); + } + + /* Same as before but with SEM_INFO. */ + { + struct seminfo ipcinfo; + semidx = semctl (semid, 0, SEM_INFO, (union semun) { .__buf = &ipcinfo }); + if (semidx == -1) + FAIL_EXIT1 ("semctl with IPC_INFO failed: %m"); + + TEST_COMPARE (ipcinfo.semmsl, tipcinfo.semmsl); + TEST_COMPARE (ipcinfo.semmns, tipcinfo.semmns); + TEST_COMPARE (ipcinfo.semopm, tipcinfo.semopm); + TEST_COMPARE (ipcinfo.semmni, tipcinfo.semmni); + } + + /* We check if the created semaphore shows in the system-wide status. */ + bool found = false; + for (int i = 0; i <= semidx; i++) + { + /* We can't tell apart if SEM_STAT_ANY is not supported (kernel older + than 4.17) or if the index used is invalid. So it just check if + value returned from a valid call matches the created semaphore. */ + check_seminfo (i, key, SEM_STAT_ANY); + + if (check_seminfo (i, key, SEM_STAT)) + { + found = true; + break; + } + } + + if (!found) + FAIL_EXIT1 ("semctl with SEM_STAT/SEM_STAT_ANY could not find the " + "created semaphore"); + + if (semctl (semid, 0, IPC_RMID, 0) == -1) + FAIL_EXIT1 ("semctl failed: %m"); + + return 0; +} + +#include diff --git a/sysvipc/test-sysvsem.c b/sysvipc/test-sysvsem.c index 01dbff343a..b7284e0b48 100644 --- a/sysvipc/test-sysvsem.c +++ b/sysvipc/test-sysvsem.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include -- cgit 1.4.1 From c4aeedea598a1bd80f52ca9ebd07fe447680d491 Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Tue, 29 Sep 2020 14:39:56 -0300 Subject: sysvipc: Fix IPC_INFO and MSG_INFO handling [BZ #26639] Both commands are Linux extensions where the third argument is a 'struct msginfo' instead of 'struct msqid_ds' and its information does not contain any time related fields (so there is no need to extra conversion for __IPC_TIME64. The regression testcase checks for Linux specifix SysV ipc message control extension. For IPC_INFO/MSG_INFO it tries to match the values against the tunable /proc values and for MSG_STAT/MSG_STAT_ANY it check if the create message queue is within the global list returned by the kernel. Checked on x86_64-linux-gnu and on i686-linux-gnu (Linux v5.4 and on Linux v4.15). (cherry picked from commit 20a00dbefca5695cccaa44846a482db8ccdd85ab) --- NEWS | 1 + sysdeps/unix/sysv/linux/Makefile | 2 +- sysdeps/unix/sysv/linux/msgctl.c | 22 +++- sysdeps/unix/sysv/linux/tst-sysvmsg-linux.c | 177 ++++++++++++++++++++++++++++ 4 files changed, 197 insertions(+), 5 deletions(-) create mode 100644 sysdeps/unix/sysv/linux/tst-sysvmsg-linux.c (limited to 'sysdeps') diff --git a/NEWS b/NEWS index fb3a9e4f7d..15c0299dd0 100644 --- a/NEWS +++ b/NEWS @@ -12,6 +12,7 @@ The following bugs are resolved with this release: [26555] string: strerrorname_np does not return the documented value [26637] libc: semctl SEM_STAT_ANY fails to pass the buffer specified by the caller to the kernel + [26639] libc: msgctl IPC_INFO and MSG_INFO return garbage Version 2.32 diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile index 9b930e7466..6ea615ab00 100644 --- a/sysdeps/unix/sysv/linux/Makefile +++ b/sysdeps/unix/sysv/linux/Makefile @@ -100,7 +100,7 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \ tst-quota tst-sync_file_range tst-sysconf-iov_max tst-ttyname \ test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \ tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \ - tst-tgkill tst-sysvsem-linux + tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables diff --git a/sysdeps/unix/sysv/linux/msgctl.c b/sysdeps/unix/sysv/linux/msgctl.c index 0776472d5e..a1f24ab242 100644 --- a/sysdeps/unix/sysv/linux/msgctl.c +++ b/sysdeps/unix/sysv/linux/msgctl.c @@ -90,8 +90,15 @@ __msgctl64 (int msqid, int cmd, struct __msqid64_ds *buf) struct kernel_msqid64_ds ksemid, *arg = NULL; if (buf != NULL) { - msqid64_to_kmsqid64 (buf, &ksemid); - arg = &ksemid; + /* This is a Linux extension where kernel returns a 'struct msginfo' + instead. */ + if (cmd == IPC_INFO || cmd == MSG_INFO) + arg = (struct kernel_msqid64_ds *) buf; + else + { + msqid64_to_kmsqid64 (buf, &ksemid); + arg = &ksemid; + } } # ifdef __ASSUME_SYSVIPC_BROKEN_MODE_T if (cmd == IPC_SET) @@ -169,8 +176,15 @@ __msgctl (int msqid, int cmd, struct msqid_ds *buf) struct __msqid64_ds msqid64, *buf64 = NULL; if (buf != NULL) { - msqid_to_msqid64 (&msqid64, buf); - buf64 = &msqid64; + /* This is a Linux extension where kernel returns a 'struct msginfo' + instead. */ + if (cmd == IPC_INFO || cmd == MSG_INFO) + buf64 = (struct __msqid64_ds *) buf; + else + { + msqid_to_msqid64 (&msqid64, buf); + buf64 = &msqid64; + } } int ret = __msgctl64 (msqid, cmd, buf64); diff --git a/sysdeps/unix/sysv/linux/tst-sysvmsg-linux.c b/sysdeps/unix/sysv/linux/tst-sysvmsg-linux.c new file mode 100644 index 0000000000..630f4f792c --- /dev/null +++ b/sysdeps/unix/sysv/linux/tst-sysvmsg-linux.c @@ -0,0 +1,177 @@ +/* Basic tests for Linux SYSV message queue extensions. + Copyright (C) 2020 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include +#include + +#include +#include + +#define MSGQ_MODE 0644 + +/* These are for the temporary file we generate. */ +static char *name; +static int msqid; + +static void +remove_msq (void) +{ + /* Enforce message queue removal in case of early test failure. + Ignore error since the msg may already have being removed. */ + msgctl (msqid, IPC_RMID, NULL); +} + +static void +do_prepare (int argc, char *argv[]) +{ + TEST_VERIFY_EXIT (create_temp_file ("tst-sysvmsg.", &name) != -1); +} + +#define PREPARE do_prepare + +struct test_msginfo +{ + int msgmax; + int msgmnb; + int msgmni; +}; + +/* It tries to obtain some system-wide SysV messsage queue information from + /proc to check against IPC_INFO/MSG_INFO. The /proc only returns the + tunables value of MSGMAX, MSGMNB, and MSGMNI. + + The kernel also returns constant value for MSGSSZ, MSGSEG and also MSGMAP, + MSGPOOL, and MSGTQL (for IPC_INFO). The issue to check them is they might + change over kernel releases. */ + +static int +read_proc_file (const char *file) +{ + FILE *f = fopen (file, "r"); + if (f == NULL) + FAIL_UNSUPPORTED ("/proc is not mounted or %s is not available", file); + + int v; + int r = fscanf (f, "%d", & v); + TEST_VERIFY_EXIT (r == 1); + + fclose (f); + return v; +} + + +/* Check if the message queue with IDX (index into the kernel's internal + array) matches the one with KEY. The CMD is either MSG_STAT or + MSG_STAT_ANY. */ + +static bool +check_msginfo (int idx, key_t key, int cmd) +{ + struct msqid_ds msginfo; + int mid = msgctl (idx, cmd, &msginfo); + /* Ignore unused array slot returned by the kernel or information from + unknown message queue. */ + if ((mid == -1 && errno == EINVAL) || mid != msqid) + return false; + + if (mid == -1) + FAIL_EXIT1 ("msgctl with %s failed: %m", + cmd == MSG_STAT ? "MSG_STAT" : "MSG_STAT_ANY"); + + TEST_COMPARE (msginfo.msg_perm.__key, key); + TEST_COMPARE (msginfo.msg_perm.mode, MSGQ_MODE); + TEST_COMPARE (msginfo.msg_qnum, 0); + + return true; +} + +static int +do_test (void) +{ + atexit (remove_msq); + + key_t key = ftok (name, 'G'); + if (key == -1) + FAIL_EXIT1 ("ftok failed: %m"); + + msqid = msgget (key, MSGQ_MODE | IPC_CREAT); + if (msqid == -1) + FAIL_EXIT1 ("msgget failed: %m"); + + struct test_msginfo tipcinfo; + tipcinfo.msgmax = read_proc_file ("/proc/sys/kernel/msgmax"); + tipcinfo.msgmnb = read_proc_file ("/proc/sys/kernel/msgmnb"); + tipcinfo.msgmni = read_proc_file ("/proc/sys/kernel/msgmni"); + + int msqidx; + + { + struct msginfo ipcinfo; + msqidx = msgctl (msqid, IPC_INFO, (struct msqid_ds *) &ipcinfo); + if (msqidx == -1) + FAIL_EXIT1 ("msgctl with IPC_INFO failed: %m"); + + TEST_COMPARE (ipcinfo.msgmax, tipcinfo.msgmax); + TEST_COMPARE (ipcinfo.msgmnb, tipcinfo.msgmnb); + TEST_COMPARE (ipcinfo.msgmni, tipcinfo.msgmni); + } + + /* Same as before but with MSG_INFO. */ + { + struct msginfo ipcinfo; + msqidx = msgctl (msqid, MSG_INFO, (struct msqid_ds *) &ipcinfo); + if (msqidx == -1) + FAIL_EXIT1 ("msgctl with IPC_INFO failed: %m"); + + TEST_COMPARE (ipcinfo.msgmax, tipcinfo.msgmax); + TEST_COMPARE (ipcinfo.msgmnb, tipcinfo.msgmnb); + TEST_COMPARE (ipcinfo.msgmni, tipcinfo.msgmni); + } + + /* We check if the created message queue shows in global list. */ + bool found = false; + for (int i = 0; i <= msqidx; i++) + { + /* We can't tell apart if MSG_STAT_ANY is not supported (kernel older + than 4.17) or if the index used is invalid. So it just check if the + value returned from a valid call matches the created message + queue. */ + check_msginfo (i, key, MSG_STAT_ANY); + + if (check_msginfo (i, key, MSG_STAT)) + { + found = true; + break; + } + } + + if (!found) + FAIL_EXIT1 ("msgctl with MSG_STAT/MSG_STAT_ANY could not find the " + "created message queue"); + + if (msgctl (msqid, IPC_RMID, NULL) == -1) + FAIL_EXIT1 ("msgctl failed"); + + return 0; +} + +#include -- cgit 1.4.1 From 0b9460d22e285432d232f42c7442a3226e1bf830 Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Tue, 29 Sep 2020 14:51:36 -0300 Subject: sysvipc: Fix IPC_INFO and SHM_INFO handling [BZ #26636] Both commands are Linux extensions where the third argument is either a 'struct shminfo' (IPC_INFO) or a 'struct shm_info' (SHM_INFO) instead of 'struct shmid_ds'. And their information does not contain any time related fields, so there is no need to extra conversion for __IPC_TIME64. The regression testcase checks for Linux specifix SysV ipc message control extension. For SHM_INFO it tries to match the values against the tunable /proc values and for MSG_STAT/MSG_STAT_ANY it check if the create\ shared memory is within the global list returned by the kernel. Checked on x86_64-linux-gnu and on i686-linux-gnu (Linux v5.4 and on Linux v4.15). (cherry picked from commit a49d7fd4f764e97ccaf922e433046590ae52fce9) --- NEWS | 2 + sysdeps/unix/sysv/linux/Makefile | 2 +- sysdeps/unix/sysv/linux/shmctl.c | 24 +++- sysdeps/unix/sysv/linux/tst-sysvshm-linux.c | 185 ++++++++++++++++++++++++++++ 4 files changed, 206 insertions(+), 7 deletions(-) create mode 100644 sysdeps/unix/sysv/linux/tst-sysvshm-linux.c (limited to 'sysdeps') diff --git a/NEWS b/NEWS index 15c0299dd0..3030735839 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,8 @@ The following bugs are resolved with this release: [26534] libm.so 2.32 SIGILL in pow() due to FMA4 instruction on non-FMA4 system [26555] string: strerrorname_np does not return the documented value + [26636] libc: 32-bit shmctl(IPC_INFO) crashes when shminfo struct is + at the end of a memory mapping [26637] libc: semctl SEM_STAT_ANY fails to pass the buffer specified by the caller to the kernel [26639] libc: msgctl IPC_INFO and MSG_INFO return garbage diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile index 6ea615ab00..34748ffcd1 100644 --- a/sysdeps/unix/sysv/linux/Makefile +++ b/sysdeps/unix/sysv/linux/Makefile @@ -100,7 +100,7 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \ tst-quota tst-sync_file_range tst-sysconf-iov_max tst-ttyname \ test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \ tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \ - tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux + tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables diff --git a/sysdeps/unix/sysv/linux/shmctl.c b/sysdeps/unix/sysv/linux/shmctl.c index 76d88441f1..1d19a798b1 100644 --- a/sysdeps/unix/sysv/linux/shmctl.c +++ b/sysdeps/unix/sysv/linux/shmctl.c @@ -90,8 +90,15 @@ __shmctl64 (int shmid, int cmd, struct __shmid64_ds *buf) struct kernel_shmid64_ds kshmid, *arg = NULL; if (buf != NULL) { - shmid64_to_kshmid64 (buf, &kshmid); - arg = &kshmid; + /* This is a Linux extension where kernel expects either a + 'struct shminfo' (IPC_INFO) or 'struct shm_info' (SHM_INFO). */ + if (cmd == IPC_INFO || cmd == SHM_INFO) + arg = (struct kernel_shmid64_ds *) buf; + else + { + shmid64_to_kshmid64 (buf, &kshmid); + arg = &kshmid; + } } # ifdef __ASSUME_SYSVIPC_BROKEN_MODE_T if (cmd == IPC_SET) @@ -107,7 +114,6 @@ __shmctl64 (int shmid, int cmd, struct __shmid64_ds *buf) switch (cmd) { - case IPC_INFO: case IPC_STAT: case SHM_STAT: case SHM_STAT_ANY: @@ -168,8 +174,15 @@ __shmctl (int shmid, int cmd, struct shmid_ds *buf) struct __shmid64_ds shmid64, *buf64 = NULL; if (buf != NULL) { - shmid_to_shmid64 (&shmid64, buf); - buf64 = &shmid64; + /* This is a Linux extension where kernel expects either a + 'struct shminfo' (IPC_INFO) or 'struct shm_info' (SHM_INFO). */ + if (cmd == IPC_INFO || cmd == SHM_INFO) + buf64 = (struct __shmid64_ds *) buf; + else + { + shmid_to_shmid64 (&shmid64, buf); + buf64 = &shmid64; + } } int ret = __shmctl64 (shmid, cmd, buf64); @@ -178,7 +191,6 @@ __shmctl (int shmid, int cmd, struct shmid_ds *buf) switch (cmd) { - case IPC_INFO: case IPC_STAT: case SHM_STAT: case SHM_STAT_ANY: diff --git a/sysdeps/unix/sysv/linux/tst-sysvshm-linux.c b/sysdeps/unix/sysv/linux/tst-sysvshm-linux.c new file mode 100644 index 0000000000..7128ae2e14 --- /dev/null +++ b/sysdeps/unix/sysv/linux/tst-sysvshm-linux.c @@ -0,0 +1,185 @@ +/* Basic tests for Linux SYSV shared memory extensions. + Copyright (C) 2020 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +#define SHM_MODE 0644 + +/* These are for the temporary file we generate. */ +static char *name; +static int shmid; +static long int pgsz; + +static void +remove_shm (void) +{ + /* Enforce message queue removal in case of early test failure. + Ignore error since the shm may already have being removed. */ + shmctl (shmid, IPC_RMID, NULL); +} + +static void +do_prepare (int argc, char *argv[]) +{ + TEST_VERIFY_EXIT (create_temp_file ("tst-sysvshm.", &name) != -1); +} + +#define PREPARE do_prepare + +struct test_shminfo +{ + unsigned long int shmall; + unsigned long int shmmax; + unsigned long int shmmni; +}; + +/* It tries to obtain some system-wide SysV shared memory information from + /proc to check against IPC_INFO/SHM_INFO. The /proc only returns the + tunables value of SHMALL, SHMMAX, and SHMMNI. */ + +static uint64_t +read_proc_file (const char *file) +{ + FILE *f = fopen (file, "r"); + if (f == NULL) + FAIL_UNSUPPORTED ("/proc is not mounted or %s is not available", file); + + /* Handle 32-bit binaries running on 64-bit kernels. */ + uint64_t v; + int r = fscanf (f, "%" SCNu64, &v); + TEST_VERIFY_EXIT (r == 1); + + fclose (f); + return v; +} + + +/* Check if the message queue with IDX (index into the kernel's internal + array) matches the one with KEY. The CMD is either SHM_STAT or + SHM_STAT_ANY. */ + +static bool +check_shminfo (int idx, key_t key, int cmd) +{ + struct shmid_ds shminfo; + int sid = shmctl (idx, cmd, &shminfo); + /* Ignore unused array slot returned by the kernel or information from + unknown message queue. */ + if ((sid == -1 && errno == EINVAL) || sid != shmid) + return false; + + if (sid == -1) + FAIL_EXIT1 ("shmctl with %s failed: %m", + cmd == SHM_STAT ? "SHM_STAT" : "SHM_STAT_ANY"); + + TEST_COMPARE (shminfo.shm_perm.__key, key); + TEST_COMPARE (shminfo.shm_perm.mode, SHM_MODE); + TEST_COMPARE (shminfo.shm_segsz, pgsz); + + return true; +} + +static int +do_test (void) +{ + atexit (remove_shm); + + pgsz = sysconf (_SC_PAGESIZE); + if (pgsz == -1) + FAIL_EXIT1 ("sysconf (_SC_PAGESIZE) failed: %m"); + + key_t key = ftok (name, 'G'); + if (key == -1) + FAIL_EXIT1 ("ftok failed: %m"); + + shmid = shmget (key, pgsz, IPC_CREAT | IPC_EXCL | SHM_MODE); + if (shmid == -1) + FAIL_EXIT1 ("shmget failed: %m"); + + struct test_shminfo tipcinfo; + { + uint64_t v = read_proc_file ("/proc/sys/kernel/shmmax"); +#if LONG_MAX == INT_MAX + /* Kernel explicit clamp the value for shmmax on compat symbol (32-bit + binaries running on 64-bit kernels). */ + if (v > INT_MAX) + v = INT_MAX; +#endif + tipcinfo.shmmax = v; + } + tipcinfo.shmall = read_proc_file ("/proc/sys/kernel/shmall"); + tipcinfo.shmmni = read_proc_file ("/proc/sys/kernel/shmmni"); + + int shmidx; + + /* Note: SHM_INFO does not return a shminfo, but rather a 'struct shm_info'. + It is tricky to verify its values since the syscall returns system wide + resources consumed by shared memory. The shmctl implementation handles + SHM_INFO as IPC_INFO, so the IPC_INFO test should validate SHM_INFO as + well. */ + + { + struct shminfo ipcinfo; + shmidx = shmctl (shmid, IPC_INFO, (struct shmid_ds *) &ipcinfo); + if (shmidx == -1) + FAIL_EXIT1 ("shmctl with IPC_INFO failed: %m"); + + TEST_COMPARE (ipcinfo.shmall, tipcinfo.shmall); + TEST_COMPARE (ipcinfo.shmmax, tipcinfo.shmmax); + TEST_COMPARE (ipcinfo.shmmni, tipcinfo.shmmni); + } + + /* We check if the created shared memory shows in the global list. */ + bool found = false; + for (int i = 0; i <= shmidx; i++) + { + /* We can't tell apart if SHM_STAT_ANY is not supported (kernel older + than 4.17) or if the index used is invalid. So it just check if + value returned from a valid call matches the created message + queue. */ + check_shminfo (i, key, SHM_STAT_ANY); + + if (check_shminfo (i, key, SHM_STAT)) + { + found = true; + break; + } + } + + if (!found) + FAIL_EXIT1 ("shmctl with SHM_STAT/SHM_STAT_ANY could not find the " + "created shared memory"); + + if (shmctl (shmid, IPC_RMID, NULL) == -1) + FAIL_EXIT1 ("shmctl failed"); + + return 0; +} + +#include -- cgit 1.4.1 From e61a8fd8fadbf1a8cef997a0f921575cb2905ea2 Mon Sep 17 00:00:00 2001 From: Patrick McGehearty Date: Mon, 28 Sep 2020 20:11:28 +0000 Subject: Reversing calculation of __x86_shared_non_temporal_threshold The __x86_shared_non_temporal_threshold determines when memcpy on x86 uses non_temporal stores to avoid pushing other data out of the last level cache. This patch proposes to revert the calculation change made by H.J. Lu's patch of June 2, 2017. H.J. Lu's patch selected a threshold suitable for a single thread getting maximum performance. It was tuned using the single threaded large memcpy micro benchmark on an 8 core processor. The last change changes the threshold from using 3/4 of one thread's share of the cache to using 3/4 of the entire cache of a multi-threaded system before switching to non-temporal stores. Multi-threaded systems with more than a few threads are server-class and typically have many active threads. If one thread consumes 3/4 of the available cache for all threads, it will cause other active threads to have data removed from the cache. Two examples show the range of the effect. John McCalpin's widely parallel Stream benchmark, which runs in parallel and fetches data sequentially, saw a 20% slowdown with this patch on an internal system test of 128 threads. This regression was discovered when comparing OL8 performance to OL7. An example that compares normal stores to non-temporal stores may be found at https://vgatherps.github.io/2018-09-02-nontemporal/. A simple test shows performance loss of 400 to 500% due to a failure to use nontemporal stores. These performance losses are most likely to occur when the system load is heaviest and good performance is critical. The tunable x86_non_temporal_threshold can be used to override the default for the knowledgable user who really wants maximum cache allocation to a single thread in a multi-threaded system. The manual entry for the tunable has been expanded to provide more information about its purpose. modified: sysdeps/x86/cacheinfo.c modified: manual/tunables.texi (cherry picked from commit d3c57027470b78dba79c6d931e4e409b1fecfc80) --- manual/tunables.texi | 6 +++++- sysdeps/x86/cacheinfo.c | 16 +++++++++++----- 2 files changed, 16 insertions(+), 6 deletions(-) (limited to 'sysdeps') diff --git a/manual/tunables.texi b/manual/tunables.texi index 23ef0d40e7..d72d7a5ec0 100644 --- a/manual/tunables.texi +++ b/manual/tunables.texi @@ -432,7 +432,11 @@ set shared cache size in bytes for use in memory and string routines. @deftp Tunable glibc.cpu.x86_non_temporal_threshold The @code{glibc.cpu.x86_non_temporal_threshold} tunable allows the user -to set threshold in bytes for non temporal store. +to set threshold in bytes for non temporal store. Non temporal stores +give a hint to the hardware to move data directly to memory without +displacing other data from the cache. This tunable is used by some +platforms to determine when to use non temporal stores in operations +like memmove and memcpy. This tunable is specific to i386 and x86-64. @end deftp diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c index 217c21c34f..dadec5d58f 100644 --- a/sysdeps/x86/cacheinfo.c +++ b/sysdeps/x86/cacheinfo.c @@ -854,14 +854,20 @@ init_cacheinfo (void) __x86_shared_cache_size = shared; } - /* The large memcpy micro benchmark in glibc shows that 6 times of - shared cache size is the approximate value above which non-temporal - store becomes faster on a 8-core processor. This is the 3/4 of the - total shared cache size. */ + /* The default setting for the non_temporal threshold is 3/4 of one + thread's share of the chip's cache. For most Intel and AMD processors + with an initial release date between 2017 and 2020, a thread's typical + share of the cache is from 500 KBytes to 2 MBytes. Using the 3/4 + threshold leaves 125 KBytes to 500 KBytes of the thread's data + in cache after a maximum temporal copy, which will maintain + in cache a reasonable portion of the thread's stack and other + active data. If the threshold is set higher than one thread's + share of the cache, it has a substantial risk of negatively + impacting the performance of other threads running on the chip. */ __x86_shared_non_temporal_threshold = (cpu_features->non_temporal_threshold != 0 ? cpu_features->non_temporal_threshold - : __x86_shared_cache_size * threads * 3 / 4); + : __x86_shared_cache_size * 3 / 4); /* NB: The REP MOVSB threshold must be greater than VEC_SIZE * 8. */ unsigned int minimum_rep_movsb_threshold; -- cgit 1.4.1 From 8813b2682e4094e43b0cf1634e99619f1b8b2c62 Mon Sep 17 00:00:00 2001 From: Sajan Karumanchi Date: Wed, 28 Oct 2020 13:05:33 +0530 Subject: x86: Optimizing memcpy for AMD Zen architecture. Modifying the shareable cache '__x86_shared_cache_size', which is a factor in computing the non-temporal threshold parameter '__x86_shared_non_temporal_threshold' to optimize memcpy for AMD Zen architectures. In the existing implementation, the shareable cache is computed as 'L3 per thread, L2 per core'. Recomputing this shareable cache as 'L3 per CCX(Core-Complex)' has brought in performance gains. As per the large bench variant results, this patch also addresses the regression problem on AMD Zen architectures. Backport of commit 59803e81f96b479c17f583b31eac44b57591a1bf upstream, with the fix from cb3a749a22a55645dc6a52659eea765300623f98 ("x86: Restore processing of cache size tunables in init_cacheinfo") applied. Reviewed-by: Premachandra Mallappa Co-Authored-by: Florian Weimer --- sysdeps/x86/cacheinfo.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) (limited to 'sysdeps') diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c index dadec5d58f..3fb4a028d8 100644 --- a/sysdeps/x86/cacheinfo.c +++ b/sysdeps/x86/cacheinfo.c @@ -808,7 +808,7 @@ init_cacheinfo (void) threads = 1 << ((ecx >> 12) & 0x0f); } - if (threads == 0) + if (threads == 0 || cpu_features->basic.family >= 0x17) { /* If APIC ID width is not available, use logical processor count. */ @@ -823,8 +823,22 @@ init_cacheinfo (void) if (threads > 0) shared /= threads; - /* Account for exclusive L2 and L3 caches. */ - shared += core; + /* Get shared cache per ccx for Zen architectures. */ + if (cpu_features->basic.family >= 0x17) + { + unsigned int eax; + + /* Get number of threads share the L3 cache in CCX. */ + __cpuid_count (0x8000001D, 0x3, eax, ebx, ecx, edx); + + unsigned int threads_per_ccx = ((eax >> 14) & 0xfff) + 1; + shared *= threads_per_ccx; + } + else + { + /* Account for exclusive L2 and L3 caches. */ + shared += core; + } } } -- cgit 1.4.1 From 70ee5e8b573f76745760dd6b75f705590fc1923a Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Thu, 22 Oct 2020 17:55:01 +0100 Subject: aarch64: Fix DT_AARCH64_VARIANT_PCS handling [BZ #26798] The variant PCS support was ineffective because in the common case linkmap->l_mach.plt == 0 but then the symbol table flags were ignored and normal lazy binding was used instead of resolving the relocs early. (This was a misunderstanding about how GOT[1] is setup by the linker.) In practice this mainly affects SVE calls when the vector length is more than 128 bits, then the top bits of the argument registers get clobbered during lazy binding. Fixes bug 26798. (cherry picked from commit 558251bd8785760ad40fcbfeaaee5d27fa5b0fe4) --- sysdeps/aarch64/dl-machine.h | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'sysdeps') diff --git a/sysdeps/aarch64/dl-machine.h b/sysdeps/aarch64/dl-machine.h index 70b9ed3925..fde7cfd9e2 100644 --- a/sysdeps/aarch64/dl-machine.h +++ b/sysdeps/aarch64/dl-machine.h @@ -395,13 +395,6 @@ elf_machine_lazy_rel (struct link_map *map, /* Check for unexpected PLT reloc type. */ if (__builtin_expect (r_type == AARCH64_R(JUMP_SLOT), 1)) { - if (map->l_mach.plt == 0) - { - /* Prelinking. */ - *reloc_addr += l_addr; - return; - } - if (__glibc_unlikely (map->l_info[DT_AARCH64 (VARIANT_PCS)] != NULL)) { /* Check the symbol table for variant PCS symbols. */ @@ -425,7 +418,10 @@ elf_machine_lazy_rel (struct link_map *map, } } - *reloc_addr = map->l_mach.plt; + if (map->l_mach.plt == 0) + *reloc_addr += l_addr; + else + *reloc_addr = map->l_mach.plt; } else if (__builtin_expect (r_type == AARCH64_R(TLSDESC), 1)) { -- cgit 1.4.1 From c6e794640c324db37038c6a8606f3f5f8903250b Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Mon, 9 Nov 2020 11:31:04 +0100 Subject: aarch64: Add unwind information to _start (bug 26853) This adds CFI directives which communicate that the stack ends with this function. Fixes bug 26853. (cherry picked from commit 5edf3d9fd6efe06fda37b2a460e60690a90457a4) --- NEWS | 1 + sysdeps/aarch64/start.S | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'sysdeps') diff --git a/NEWS b/NEWS index 3030735839..d2a484462b 100644 --- a/NEWS +++ b/NEWS @@ -15,6 +15,7 @@ The following bugs are resolved with this release: [26637] libc: semctl SEM_STAT_ANY fails to pass the buffer specified by the caller to the kernel [26639] libc: msgctl IPC_INFO and MSG_INFO return garbage + [26853] aarch64: Missing unwind information in statically linked startup code Version 2.32 diff --git a/sysdeps/aarch64/start.S b/sysdeps/aarch64/start.S index 75393e1c18..108f602721 100644 --- a/sysdeps/aarch64/start.S +++ b/sysdeps/aarch64/start.S @@ -43,11 +43,9 @@ */ .text - .globl _start - .type _start,#function -_start: - BTI_C +ENTRY(_start) /* Create an initial frame with 0 LR and FP */ + cfi_undefined (x30) mov x29, #0 mov x30, #0 @@ -103,6 +101,7 @@ _start: __wrap_main: b main #endif +END(_start) /* Define a symbol for the first piece of initialized data. */ .data -- cgit 1.4.1 From 3ea24955bff835f1c5bbfd7674208e25fa795c1a Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Wed, 11 Nov 2020 11:59:11 +0100 Subject: struct _Unwind_Exception alignment should not depend on compiler flags __attribute__((__aligned__)) selects an alignment that depends on the micro-architecture selected by GCC flags. Enabling vector extensions may increase the allignment. This is a problem when building glibc as a collection of ELF multilibs with different GCC flags because ld.so and libc.so/libpthread.so/&c may end up with a different layout of struct pthread because of the changing offset of its struct _Unwind_Exception field. Tested-By: Matheus Castanho (cherry picked from commit 30af7c7fa13e17d82c3f1f91536384715844f432) --- sysdeps/generic/unwind.h | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) (limited to 'sysdeps') diff --git a/sysdeps/generic/unwind.h b/sysdeps/generic/unwind.h index b667a5b652..c229603af3 100644 --- a/sysdeps/generic/unwind.h +++ b/sysdeps/generic/unwind.h @@ -75,15 +75,21 @@ typedef void (*_Unwind_Exception_Cleanup_Fn) (_Unwind_Reason_Code, struct _Unwind_Exception { - _Unwind_Exception_Class exception_class; - _Unwind_Exception_Cleanup_Fn exception_cleanup; - _Unwind_Word private_1; - _Unwind_Word private_2; - - /* @@@ The IA-64 ABI says that this structure must be double-word aligned. - Taking that literally does not make much sense generically. Instead we - provide the maximum alignment required by any type for the machine. */ -} __attribute__((__aligned__)); + union + { + struct + { + _Unwind_Exception_Class exception_class; + _Unwind_Exception_Cleanup_Fn exception_cleanup; + _Unwind_Word private_1; + _Unwind_Word private_2; + }; + + /* The IA-64 ABI says that this structure must be double-word aligned. */ + _Unwind_Word unwind_exception_align[2] + __attribute__ ((__aligned__ (2 * sizeof (_Unwind_Word)))); + }; +}; /* The ACTIONS argument to the personality routine is a bitwise OR of one -- cgit 1.4.1 From ac0a6929c5d370952557aded97c2dd073a28773b Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Wed, 25 Nov 2020 15:00:44 -0300 Subject: sh: Add sh4 fpu Implies folder The commit 605f38177db (sh: Split BE/LE abilist) did not take in consideration the SH4 fpu support. Checked with a build for sh4-linux-gnu and manually checked that the implementations at sysdeps/sh/sh4/fpu/ are selected. John Paul Adrian Glaubitz also confirmed it fixes the build issues he encontered. (cherry-picked from 9ff2674ef82eccd5ae5dfa6bb733c0e3613764c6) --- NEWS | 1 + sysdeps/sh/be/sh4/fpu/Implies | 1 + sysdeps/sh/le/sh4/fpu/Implies | 1 + sysdeps/unix/sysv/linux/sh/be/sh4/fpu/Implies | 1 + sysdeps/unix/sysv/linux/sh/le/sh4/fpu/Implies | 1 + 5 files changed, 5 insertions(+) create mode 100644 sysdeps/sh/be/sh4/fpu/Implies create mode 100644 sysdeps/sh/le/sh4/fpu/Implies create mode 100644 sysdeps/unix/sysv/linux/sh/be/sh4/fpu/Implies create mode 100644 sysdeps/unix/sysv/linux/sh/le/sh4/fpu/Implies (limited to 'sysdeps') diff --git a/NEWS b/NEWS index 1c1f270784..8b18675683 100644 --- a/NEWS +++ b/NEWS @@ -17,6 +17,7 @@ The following bugs are resolved with this release: by the caller to the kernel [26639] libc: msgctl IPC_INFO and MSG_INFO return garbage [26853] aarch64: Missing unwind information in statically linked startup code + [26932] libc: sh: Multiple floating point functions defined as stubs only Version 2.32 diff --git a/sysdeps/sh/be/sh4/fpu/Implies b/sysdeps/sh/be/sh4/fpu/Implies new file mode 100644 index 0000000000..71b28ee1a4 --- /dev/null +++ b/sysdeps/sh/be/sh4/fpu/Implies @@ -0,0 +1 @@ +sh/sh4/fpu diff --git a/sysdeps/sh/le/sh4/fpu/Implies b/sysdeps/sh/le/sh4/fpu/Implies new file mode 100644 index 0000000000..71b28ee1a4 --- /dev/null +++ b/sysdeps/sh/le/sh4/fpu/Implies @@ -0,0 +1 @@ +sh/sh4/fpu diff --git a/sysdeps/unix/sysv/linux/sh/be/sh4/fpu/Implies b/sysdeps/unix/sysv/linux/sh/be/sh4/fpu/Implies new file mode 100644 index 0000000000..7eeaf15a5a --- /dev/null +++ b/sysdeps/unix/sysv/linux/sh/be/sh4/fpu/Implies @@ -0,0 +1 @@ +unix/sysv/linux/sh/sh4/fpu diff --git a/sysdeps/unix/sysv/linux/sh/le/sh4/fpu/Implies b/sysdeps/unix/sysv/linux/sh/le/sh4/fpu/Implies new file mode 100644 index 0000000000..7eeaf15a5a --- /dev/null +++ b/sysdeps/unix/sysv/linux/sh/le/sh4/fpu/Implies @@ -0,0 +1 @@ +unix/sysv/linux/sh/sh4/fpu -- cgit 1.4.1