From b6a02c360655cbb84772bb577fcd8ae54d7f6d82 Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Tue, 5 Jul 2022 12:41:07 -0700 Subject: x86: Add support for building {w}memmove{_chk} with explicit ISA level 1. Refactor files so that all implementations are in the multiarch directory - Moved the implementation portion of memmove sse2 from memmove.S to multiarch/memmove-sse2.S - The non-multiarch file now only includes one of the implementations in the multiarch directory based on the compiled ISA level (only used for non-multiarch builds. Otherwise we go through the ifunc selector). 2. Add ISA level build guards to different implementations. - I.e memmove-avx2-unaligned-erms.S which is ISA level 3 will only build if compiled ISA level <= 3. Otherwise there is no reason to include it as we will always use one of the ISA level 4 implementations (memmove-evex-unaligned-erms.S). 3. Add new multiarch/rtld-memmove.S that just include the non-multiarch memmove.S which will in turn select the best implementation based on the compiled ISA level. 4. Refactor the ifunc selector and ifunc implementation list to use the ISA level aware wrapper macros that allow functions below the compiled ISA level (with a guranteed replacement) to be skipped. Tested with and without multiarch on x86_64 for ISA levels: {generic, x86-64-v2, x86-64-v3, x86-64-v4} And m32 with and without multiarch. isa raising memmove --- sysdeps/x86_64/multiarch/memmove-avx512-no-vzeroupper.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sysdeps/x86_64/multiarch/memmove-avx512-no-vzeroupper.S') diff --git a/sysdeps/x86_64/multiarch/memmove-avx512-no-vzeroupper.S b/sysdeps/x86_64/multiarch/memmove-avx512-no-vzeroupper.S index 42d15a142a..9c090d368b 100644 --- a/sysdeps/x86_64/multiarch/memmove-avx512-no-vzeroupper.S +++ b/sysdeps/x86_64/multiarch/memmove-avx512-no-vzeroupper.S @@ -17,8 +17,9 @@ . */ #include +#include -#if IS_IN (libc) +#if ISA_SHOULD_BUILD (4) # include "asm-syntax.h" -- cgit 1.4.1