From 0aac205a814a8511e98d02b91a8dc908f1c53cde Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Mon, 26 Feb 2024 06:37:03 -0800 Subject: x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers Compiler generates the following instruction sequence for GNU2 dynamic TLS access: leaq tls_var@TLSDESC(%rip), %rax call *tls_var@TLSCALL(%rax) or leal tls_var@TLSDESC(%ebx), %eax call *tls_var@TLSCALL(%eax) CALL instruction is transparent to compiler which assumes all registers, except for EFLAGS and RAX/EAX, are unchanged after CALL. When _dl_tlsdesc_dynamic is called, it calls __tls_get_addr on the slow path. __tls_get_addr is a normal function which doesn't preserve any caller-saved registers. _dl_tlsdesc_dynamic saved and restored integer caller-saved registers, but didn't preserve any other caller-saved registers. Add _dl_tlsdesc_dynamic IFUNC functions for FNSAVE, FXSAVE, XSAVE and XSAVEC to save and restore all caller-saved registers. This fixes BZ #31372. Add GLRO(dl_x86_64_runtime_resolve) with GLRO(dl_x86_tlsdesc_dynamic) to optimize elf_machine_runtime_setup. Reviewed-by: Noah Goldstein --- sysdeps/x86/features-offsets.sym | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 sysdeps/x86/features-offsets.sym (limited to 'sysdeps/x86/features-offsets.sym') diff --git a/sysdeps/x86/features-offsets.sym b/sysdeps/x86/features-offsets.sym new file mode 100644 index 0000000000..77e990c705 --- /dev/null +++ b/sysdeps/x86/features-offsets.sym @@ -0,0 +1,8 @@ +#define SHARED 1 + +#include + +RTLD_GLOBAL_RO_DL_X86_CPU_FEATURES_OFFSET offsetof (struct rtld_global_ro, _dl_x86_cpu_features) +#ifdef __x86_64__ +RTLD_GLOBAL_DL_X86_FEATURE_1_OFFSET offsetof (struct rtld_global, _dl_x86_feature_1) +#endif -- cgit 1.4.1