From c79a72aa5cb8357c216a71015c7448a9259c8531 Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Tue, 2 May 2017 14:39:58 -0300 Subject: posix: Fix and simplify default p{read,write}v implementation Currently all architectures but microblaze use wire-up syscall for p{readv,write}v. Microblaze still uses the syscall emulation using sysdep/posix/p{readv,writev}.c and it was reported in some ocasions [1] [2] that it might have some issues with some linux specific usage (mainly with O_DIRECT and the alignment requirement). Although it is not an issue for virtually all the system, this patch refactors the sysdeps/posix p{read,write}v syscall to avoid such issue (by using posix_memalign on the buffer used on p{read,write} call) and by refactoring it common files to avoid the need check on defines to correct set the alias and internal symbols. Checked on microblaze-linux-gnu check with run-built-tests=no and by using the sysdeps/posix implementation on x86_64-linux-gnu (just for sanity test where it shown no regression). * sysdeps/posix/preadv.c: Use sysdeps/posix/preadv_common.c. * sysdeps/posix/preadv64.c: Likewise. * sysdeps/unix/sysv/linux/preadv.c: Likewise. * sysdeps/unix/sysv/linux/preadv64.c: Likewise. * sysdeps/posix/pwritev.c: Use sysdeps/posix/pwritev_common.c. * sysdeps/posix/pwritev64.c: Likewise. * sysdeps/unix/sysv/linux/pwritev.c: Likewise. * sysdeps/unix/sysv/linux/pwritev64.c: Likewise. * sysdeps/posix/preadv_common.c: New file. * sysdeps/posix/pwritev_common.c: Likewise. [1] http://www.mail-archive.com/qemu-devel@nongnu.org/msg25282.html [2] https://bugzilla.redhat.com/show_bug.cgi?id=563103#c8 --- sysdeps/unix/sysv/linux/preadv.c | 2 +- sysdeps/unix/sysv/linux/preadv64.c | 2 +- sysdeps/unix/sysv/linux/pwritev.c | 2 +- sysdeps/unix/sysv/linux/pwritev64.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'sysdeps/unix') diff --git a/sysdeps/unix/sysv/linux/preadv.c b/sysdeps/unix/sysv/linux/preadv.c index ccfe7636d6..7d971cc7b3 100644 --- a/sysdeps/unix/sysv/linux/preadv.c +++ b/sysdeps/unix/sysv/linux/preadv.c @@ -48,6 +48,6 @@ preadv (int fd, const struct iovec *vector, int count, off_t offset) # define PREADV static internal_function __atomic_preadv_replacement # define PREAD __pread # define OFF_T off_t -# include +# include # endif /* __ASSUME_PREADV */ #endif diff --git a/sysdeps/unix/sysv/linux/preadv64.c b/sysdeps/unix/sysv/linux/preadv64.c index 979db95571..66daa74ded 100644 --- a/sysdeps/unix/sysv/linux/preadv64.c +++ b/sysdeps/unix/sysv/linux/preadv64.c @@ -46,7 +46,7 @@ preadv64 (int fd, const struct iovec *vector, int count, off64_t offset) # define PREADV static internal_function __atomic_preadv64_replacement # define PREAD __pread64 # define OFF_T off64_t -# include +# include #endif #ifdef __OFF_T_MATCHES_OFF64_T diff --git a/sysdeps/unix/sysv/linux/pwritev.c b/sysdeps/unix/sysv/linux/pwritev.c index 2789943760..ce02996a0b 100644 --- a/sysdeps/unix/sysv/linux/pwritev.c +++ b/sysdeps/unix/sysv/linux/pwritev.c @@ -48,6 +48,6 @@ pwritev (int fd, const struct iovec *vector, int count, off_t offset) # define PWRITEV static internal_function __atomic_pwritev_replacement # define PWRITE __pwrite # define OFF_T off_t -# include +# include # endif /* __ASSUME_PREADV */ #endif diff --git a/sysdeps/unix/sysv/linux/pwritev64.c b/sysdeps/unix/sysv/linux/pwritev64.c index 1e3a36ca58..45fb90b0d7 100644 --- a/sysdeps/unix/sysv/linux/pwritev64.c +++ b/sysdeps/unix/sysv/linux/pwritev64.c @@ -46,7 +46,7 @@ pwritev64 (int fd, const struct iovec *vector, int count, off64_t offset) # define PWRITEV static internal_function __atomic_pwritev64_replacement # define PWRITE __pwrite64 # define OFF_T off64_t -# include +# include #endif #ifdef __OFF_T_MATCHES_OFF64_T -- cgit 1.4.1