From 1a2325c06cf309d1d8b4aafcfb1a3d43905baf9b Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Wed, 18 Feb 2015 00:26:35 +0000 Subject: Fix posix_spawn getrlimit64 namespace (bug 17991). posix_spawn (a standard POSIX function) brings in a use of getrlimit64 (not a standard POSIX function). This patch fixes this by using __getrlimit64 and making getrlimit64 a weak alias. This is more complicated than some such changes because of files that define getrlimit64 in their own way using symbol versioning after including the main sysdeps/unix/sysv/linux/getrlimit64.c with a getrlimit macro defined. There are various existing patterns for such cases in glibc; the one I've used here is that a getrlimit64 macro disables the weak_alias / libc_hidden_weak calls, leaving it to the including file to define the getrlimit64 name in whatever way is appropriate. Tested for x86_64 and x86 that installed stripped shared libraries are unchanged by this patch. [BZ #17991] * include/sys/resource.h (__getrlimit64): Declare. Use libc_hidden_proto. * resource/getrlimit64.c (getrlimit64): Rename to __getrlimit64 and define as weak alias of __getrlimit64. Use libc_hidden_weak. * sysdeps/posix/spawni.c (__spawni): Call __getrlimit64 instead of getrlimit64. * sysdeps/unix/sysv/linux/getrlimit64.c (getrlimit64): Rename to __getrlimit64. [!getrlimit64] (getrlimit64): Define as weak alias of __getrlimit64. Use libc_hidden_weak. * sysdeps/unix/sysv/linux/i386/getrlimit64.c (getrlimit64): Define using __getrlimit64 not __new_getrlimit64. (__GI_getrlimit64): Likewise. * sysdeps/unix/sysv/linux/mips/getrlimit64.c (getrlimit64): Likewise. (__GI_getrlimit64): Likewise. (__old_getrlimit64): Use __getrlimit64 not __new_getrlimit64. * sysdeps/unix/sysv/linux/powerpc/powerpc64/syscalls.list (getrlimit): Add __getrlimit64 alias. * sysdeps/unix/sysv/linux/wordsize-64/syscalls.list (getrlimit): Likewise. * conform/Makefile (test-xfail-XOPEN2K/spawn.h/linknamespace): Remove variable. (test-xfail-POSIX2008/spawn.h/linknamespace): Likewise. (test-xfail-XOPEN2K8/spawn.h/linknamespace): Likewise. --- sysdeps/unix/sysv/linux/getrlimit64.c | 8 ++++++-- sysdeps/unix/sysv/linux/i386/getrlimit64.c | 4 ++-- sysdeps/unix/sysv/linux/mips/getrlimit64.c | 6 +++--- sysdeps/unix/sysv/linux/powerpc/powerpc64/syscalls.list | 2 +- sysdeps/unix/sysv/linux/wordsize-64/syscalls.list | 2 +- 5 files changed, 13 insertions(+), 9 deletions(-) (limited to 'sysdeps/unix') diff --git a/sysdeps/unix/sysv/linux/getrlimit64.c b/sysdeps/unix/sysv/linux/getrlimit64.c index 461d3458df..100ba623e2 100644 --- a/sysdeps/unix/sysv/linux/getrlimit64.c +++ b/sysdeps/unix/sysv/linux/getrlimit64.c @@ -24,7 +24,7 @@ /* Put the soft and hard limits for RESOURCE in *RLIMITS. Returns 0 if successful, -1 if not (and sets errno). */ int -getrlimit64 (enum __rlimit_resource resource, struct rlimit64 *rlimits) +__getrlimit64 (enum __rlimit_resource resource, struct rlimit64 *rlimits) { #ifdef __ASSUME_PRLIMIT64 return INLINE_SYSCALL (prlimit64, 4, 0, resource, NULL, rlimits); @@ -51,4 +51,8 @@ getrlimit64 (enum __rlimit_resource resource, struct rlimit64 *rlimits) return 0; #endif } -libc_hidden_def (getrlimit64) +libc_hidden_def (__getrlimit64) +#ifndef getrlimit64 +weak_alias (__getrlimit64, getrlimit64) +libc_hidden_weak (getrlimit64) +#endif diff --git a/sysdeps/unix/sysv/linux/i386/getrlimit64.c b/sysdeps/unix/sysv/linux/i386/getrlimit64.c index a771584399..8bd3bd9dab 100644 --- a/sysdeps/unix/sysv/linux/i386/getrlimit64.c +++ b/sysdeps/unix/sysv/linux/i386/getrlimit64.c @@ -21,5 +21,5 @@ #undef getrlimit64 #include -versioned_symbol (libc, __new_getrlimit64, getrlimit64, GLIBC_2_2); -strong_alias (__new_getrlimit64, __GI_getrlimit64) +versioned_symbol (libc, __getrlimit64, getrlimit64, GLIBC_2_2); +strong_alias (__getrlimit64, __GI_getrlimit64) diff --git a/sysdeps/unix/sysv/linux/mips/getrlimit64.c b/sysdeps/unix/sysv/linux/mips/getrlimit64.c index 7080f77e81..751b11a631 100644 --- a/sysdeps/unix/sysv/linux/mips/getrlimit64.c +++ b/sysdeps/unix/sysv/linux/mips/getrlimit64.c @@ -25,8 +25,8 @@ # include # undef getrlimit64 -versioned_symbol (libc, __new_getrlimit64, getrlimit64, GLIBC_2_19); -strong_alias (__new_getrlimit64, __GI_getrlimit64) +versioned_symbol (libc, __getrlimit64, getrlimit64, GLIBC_2_19); +strong_alias (__getrlimit64, __GI_getrlimit64) # if SHLIB_COMPAT (libc, GLIBC_2_2, GLIBC_2_19) @@ -45,7 +45,7 @@ __old_getrlimit64 (enum __rlimit_resource resource, { struct rlimit64 krlimits; - if (__new_getrlimit64 (resource, &krlimits) < 0) + if (__getrlimit64 (resource, &krlimits) < 0) return -1; if (krlimits.rlim_cur == RLIM64_INFINITY) diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/syscalls.list b/sysdeps/unix/sysv/linux/powerpc/powerpc64/syscalls.list index aee60bf9d5..6ba6f9b1e9 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/syscalls.list +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/syscalls.list @@ -1,3 +1,3 @@ # File name Caller Syscall name # args Strong name Weak names -getrlimit - ugetrlimit i:ip __getrlimit getrlimit getrlimit64 +getrlimit - ugetrlimit i:ip __getrlimit getrlimit getrlimit64 __getrlimit64 diff --git a/sysdeps/unix/sysv/linux/wordsize-64/syscalls.list b/sysdeps/unix/sysv/linux/wordsize-64/syscalls.list index 77aa246435..2876bbdc3e 100644 --- a/sysdeps/unix/sysv/linux/wordsize-64/syscalls.list +++ b/sysdeps/unix/sysv/linux/wordsize-64/syscalls.list @@ -10,7 +10,7 @@ statfs - statfs i:sp __statfs statfs statfs64 mmap - mmap b:aniiii __mmap mmap __mmap64 mmap64 ftruncate - ftruncate i:ii __ftruncate ftruncate ftruncate64 __ftruncate64 truncate - truncate i:si truncate truncate64 -getrlimit - getrlimit i:ip __getrlimit getrlimit getrlimit64 +getrlimit - getrlimit i:ip __getrlimit getrlimit getrlimit64 __getrlimit64 setrlimit - setrlimit i:ip __setrlimit setrlimit setrlimit64 readahead - readahead i:iii __readahead readahead sendfile - sendfile i:iipi sendfile sendfile64 -- cgit 1.4.1