From e0cb7b6131ee5f2dca2938069b8b9590304e6f6b Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Tue, 26 Feb 2019 02:09:18 +0000 Subject: Add and move fall-through comments in system-specific code. This patch fixes -Wimplicit-fallthrough warnings in system-specific code that show up building glibc with -Wextra, by adding fall-through comments, or moving existing such comments to the place required for them to work (immediately before the case label being fallen through). Tested with build-many-glibcs.py. * sysdeps/i386/dl-machine.h (elf_machine_rela): Add fall-through comments. * sysdeps/m68k/m680x0/fpu/s_cexp_template.c (s(__cexp)): Likewise. * sysdeps/m68k/memcopy.h (WORD_COPY_FWD): Likewise. (WORD_COPY_BWD): Likewise. * sysdeps/mach/hurd/ioctl.c (__ioctl): Likewise. * sysdeps/powerpc/powerpc64/dl-machine.h (elf_machine_rela): Likewise. * sysdeps/s390/iso-8859-1_cp037_z900.c (TR_LOOP): Likewise. * sysdeps/mips/dl-machine.h (elf_machine_reloc): Move fall-through comment. * sysdeps/mips/dl-trampoline.c (__dl_runtime_resolve): Likewise. --- sysdeps/mips/dl-machine.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sysdeps/mips/dl-machine.h') diff --git a/sysdeps/mips/dl-machine.h b/sysdeps/mips/dl-machine.h index e82891fa3f..f9e7e90b41 100644 --- a/sysdeps/mips/dl-machine.h +++ b/sysdeps/mips/dl-machine.h @@ -712,8 +712,8 @@ elf_machine_reloc (struct link_map *map, ElfW(Addr) r_info, it's totally unnecessary. */ if (ELFW(R_SYM) (r_info) == 0) break; - /* Fall through. */ #endif + /* Fall through. */ default: _dl_reloc_bad_type (map, r_type, 0); break; -- cgit 1.4.1