From 9ec31e57278ffc4e680ef03e75ce5b6b02e5edcf Mon Sep 17 00:00:00 2001 From: Sergey Bugaev Date: Sat, 20 May 2023 14:55:29 +0300 Subject: hurd: Use __hurd_fail () instead of assigning errno The __hurd_fail () inline function is the dedicated, idiomatic way of reporting errors in the Hurd part of glibc. Not only is it more concise than '{ errno = err; return -1; }', it is since commit 6639cc10029e24e06b34e169712b21c31b8cf213 "hurd: Mark error functions as __COLD" marked with the cold attribute, telling the compiler that this codepath is unlikely to be executed. In one case, use __hurd_dfail () over the plain __hurd_fail (). Signed-off-by: Sergey Bugaev Message-Id: <20230520115531.3911877-1-bugaevc@gmail.com> --- sysdeps/mach/hurd/libc_sigaction.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'sysdeps/mach/hurd/libc_sigaction.c') diff --git a/sysdeps/mach/hurd/libc_sigaction.c b/sysdeps/mach/hurd/libc_sigaction.c index 3053c7e7ac..748647e9f8 100644 --- a/sysdeps/mach/hurd/libc_sigaction.c +++ b/sysdeps/mach/hurd/libc_sigaction.c @@ -33,10 +33,7 @@ __libc_sigaction (int sig, const struct sigaction *act, if (act != NULL && act->sa_handler != SIG_DFL && ((__sigmask (sig) & _SIG_CANT_MASK) || act->sa_handler == SIG_ERR)) - { - errno = EINVAL; - return -1; - } + return __hurd_fail (EINVAL); /* Copy so we fault before taking locks. */ if (act != NULL) -- cgit 1.4.1