From e7223fa1e8e0673440cc62364b67d55afc78123a Mon Sep 17 00:00:00 2001
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Tue, 6 Dec 2022 13:28:40 -0300
Subject: stdio: Do not ignore posix_spawn error on popen (BZ #29016)

To correctly return error in case of default shell is not present.

Checked on x86_64-linux-gnu.
---
 stdio-common/Makefile     |  3 +++
 stdio-common/tst-popen3.c | 38 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+)
 create mode 100644 stdio-common/tst-popen3.c

(limited to 'stdio-common')

diff --git a/stdio-common/Makefile b/stdio-common/Makefile
index 652d9e5f95..92a3499a94 100644
--- a/stdio-common/Makefile
+++ b/stdio-common/Makefile
@@ -238,6 +238,9 @@ tests := \
   xbug \
   # tests
 
+tests-container += \
+  tst-popen3
+
 generated += \
   errlist-data-aux-shared.S \
   errlist-data-aux.S \
diff --git a/stdio-common/tst-popen3.c b/stdio-common/tst-popen3.c
new file mode 100644
index 0000000000..add5e97c09
--- /dev/null
+++ b/stdio-common/tst-popen3.c
@@ -0,0 +1,38 @@
+/* Check if popen return a correct error code if the default shell does not
+   exists (BZ#29016).
+
+   Copyright (C) 2022 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <paths.h>
+#include <stdio.h>
+#include <errno.h>
+#include <support/check.h>
+#include <support/xunistd.h>
+
+int
+do_test (void)
+{
+  xunlink (_PATH_BSHELL);
+
+  FILE *f = popen ("/non-existent", "r");
+  TEST_VERIFY (f == NULL);
+  TEST_COMPARE (errno, ENOENT);
+  return 0;
+}
+
+#include <support/test-driver.c>
-- 
cgit 1.4.1