From 43257c335ad6b9e05fb882975e1776ff763164ee Mon Sep 17 00:00:00 2001 From: "Gabriel F. T. Gomes" Date: Tue, 6 Nov 2018 17:44:13 -0200 Subject: Use TEST_COMPARE_STRING in recently added test The commit commit 1df872fd74f730bcae3df201a229195445d2e18a Author: Florian Weimer Date: Wed Nov 7 12:42:44 2018 +0100 support: Implement TEST_COMPARE_STRING added the new macro TEST_COMPARE_STRING, which compares the output of functions under test against expected strings, and, when there's a mismatch, automatically reports an error and prints the differences. This patch adapts recently added test cases to use this new macro. Tested for powerpc64le (as is, and locally patched to intentionally fail and produce error output). * argp/tst-ldbl-argp.c (do_one_test): Use TEST_COMPARE_STRING, instead of manually comparing and reporting mismatching strings. * misc/tst-ldbl-error.c (do_one_test): Likewise. * misc/tst-ldbl-warn.c (do_one_test): Likewise. --- misc/tst-ldbl-error.c | 9 +-------- misc/tst-ldbl-warn.c | 6 +----- 2 files changed, 2 insertions(+), 13 deletions(-) (limited to 'misc') diff --git a/misc/tst-ldbl-error.c b/misc/tst-ldbl-error.c index a02cb2772a..76b2c8f784 100644 --- a/misc/tst-ldbl-error.c +++ b/misc/tst-ldbl-error.c @@ -95,14 +95,7 @@ do_one_test (void *callback, const char *expected, ...) message = strstr (result.err.buffer, needle); /* Verify that the output message is as expected. */ - if (strcmp (message, expected) != 0) - { - support_record_failure (); - printf ("error:\n" - " expected: '%s'\n" - " actual: '%s'\n", - expected, message); - } + TEST_COMPARE_STRING (message, expected); va_end (args); } diff --git a/misc/tst-ldbl-warn.c b/misc/tst-ldbl-warn.c index 3ac0e4c873..69a528755c 100644 --- a/misc/tst-ldbl-warn.c +++ b/misc/tst-ldbl-warn.c @@ -61,11 +61,7 @@ do_one_test (int select, const char *format, va_list args, /* Close the in-memory stream and check the output buffer. */ xfclose_memstream (&stream); - if (strcmp (stream.buffer, expected) != 0) - FAIL_EXIT1 ("error:\n" - " expected: '%s'\n" - " actual: '%s'\n", - expected, stream.buffer); + TEST_COMPARE_STRING (stream.buffer, expected); if (stream.buffer != NULL) free (stream.buffer); -- cgit 1.4.1