From 67f0aff0c63e5deaade7f6cc7758f5cb63344fb8 Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Wed, 16 Aug 2017 20:33:59 +0000 Subject: Fix sigval namespace (bug 21944). XPG4.2 defines the siginfo_t type, but not union sigval or its contents (which were added in the 1993 edition of POSIX.1), resulting in namespace violations for sigval, sival_int and sival_ptr for signal.h and sys/wait.h for that standard because those headers incorrectly expose those names in that case. This patch fixes this problem. The public type in this case is union sigval, but various places in the headers use the sigval_t name for it; direct uses of union sigval are already properly guarded or in headers not in XPG4.2. Now, sigval_t, although not a standard name, does seem to be widely used outside glibc. The approach taken by this patch is to make installed headers use the name __sigval_t instead. __sigval_t is then defined to either union sigval or union __sigval (where union __sigval has __-prefixed member names as well), depending on whether there are any namespace issues with the union sigval name and its members. In the case where union __sigval is used, sigval_t is not defined at all, to avoid the problem of sigval_t having a C++ mangled name that depends on feature test macros. sigval_t is still defined by signal.h if __USE_MISC (reflecting the nonstandard nature of that name). Tested for x86_64. [BZ #21944] * signal/bits/types/__sigval_t.h: New file. * signal/Makefile (headers): Add bits/types/__sigval_t.h. * signal/bits/types/sigval_t.h: Include and define sigval_t using __sigval_t. * include/bits/types/__sigval_t.h: New file. * bits/types/sigevent_t.h: Include instead of . (struct sigevent): Use __sigval_t instead of sigval_t. * bits/types/siginfo_t.h: Include instead of . (siginfo_t): Use __sigval_t instead of sigval_t. * sysdeps/unix/sysv/linux/bits/types/sigevent_t.h: Include instead of . (struct sigevent): Use __sigval_t instead of sigval_t. * sysdeps/unix/sysv/linux/bits/types/siginfo_t.h: Include instead of . (siginfo_t): Use __sigval_t instead of sigval_t. * signal/signal.h [__USE_MISC]: Include . --- include/bits/types/__sigval_t.h | 1 + 1 file changed, 1 insertion(+) create mode 100644 include/bits/types/__sigval_t.h (limited to 'include/bits') diff --git a/include/bits/types/__sigval_t.h b/include/bits/types/__sigval_t.h new file mode 100644 index 0000000000..62f8e48ed8 --- /dev/null +++ b/include/bits/types/__sigval_t.h @@ -0,0 +1 @@ +#include -- cgit 1.4.1