From e0ed2fb40a0e29c43cf60addc74741dab15f2e05 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Fri, 6 Mar 2015 04:55:56 -0800 Subject: Replace __attribute__((visibility("protected"))) With copy relocation, address of protected data defined in the shared library may be external. Compiler shouldn't asssume protected data will be local. But due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248 __attribute__((visibility("protected"))) doesn't work correctly, we need to use asm (".protected xxx") instead. * elf/ifuncdep2.c (global): Replace __attribute__((visibility("protected"))) with asm (".protected global"). * elf/ifuncmod1.c (global): Likewise. * elf/ifuncmod5.c (global): Likewise. --- elf/ifuncmod1.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'elf/ifuncmod1.c') diff --git a/elf/ifuncmod1.c b/elf/ifuncmod1.c index 2b8195ce55..0b6138056d 100644 --- a/elf/ifuncmod1.c +++ b/elf/ifuncmod1.c @@ -6,7 +6,13 @@ */ #include "ifunc-sel.h" -int global __attribute__ ((visibility ("protected"))) = -1; +int global = -1; +/* Can't use __attribute__((visibility("protected"))) until the GCC bug: + + https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248 + + is fixed. */ +asm (".protected global"); static int one (void) -- cgit 1.4.1