From a4733812085f338dfcbb3f31b48747b00eb5c46c Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Fri, 14 Nov 2014 18:35:42 +0000 Subject: Only declare __sigpause in installed signal.h when necessary. This patch makes the installed signal.h declare __sigpause only when necessary (when a macro definition of sigpause makes use of __sigpause), rather than unconditionally. This fixes false positives in the linknamespace tests by making it visible to those tests that no use of ISO C functionality will actually bring in the definition of __sigpause and so bring in the other symbols defined in the same object. There is no bug filed in Bugzilla because this is fixing false positives rather than any user-visible bug. Tested for x86_64 (testsuite, and that installed stripped shared libraries are unchanged by this patch). * signal/signal.h (__sigpause): Only declare if [__USE_XOPEN && !__GNUC__]. * include/signal.h (__sigpause): Move declaration above call to libc_hidden_proto. * conform/Makefile (test-xfail-ISO/signal.h/linknamespace): Remove variable. (test-xfail-ISO99/signal.h/linknamespace): Likewise. (test-xfail-ISO11/signal.h/linknamespace): Likewise. --- conform/Makefile | 3 --- 1 file changed, 3 deletions(-) (limited to 'conform') diff --git a/conform/Makefile b/conform/Makefile index 45917a66f3..b2806b1662 100644 --- a/conform/Makefile +++ b/conform/Makefile @@ -326,19 +326,16 @@ test-xfail-XOPEN2K8/ndbm.h/linknamespace = yes # Unsorted expected failures. test-xfail-ISO/math.h/linknamespace = yes -test-xfail-ISO/signal.h/linknamespace = yes test-xfail-ISO/stdio.h/linknamespace = yes test-xfail-ISO/time.h/linknamespace = yes test-xfail-ISO99/complex.h/linknamespace = yes test-xfail-ISO99/ctype.h/linknamespace = yes test-xfail-ISO99/math.h/linknamespace = yes -test-xfail-ISO99/signal.h/linknamespace = yes test-xfail-ISO99/stdio.h/linknamespace = yes test-xfail-ISO99/tgmath.h/linknamespace = yes test-xfail-ISO11/complex.h/linknamespace = yes test-xfail-ISO11/ctype.h/linknamespace = yes test-xfail-ISO11/math.h/linknamespace = yes -test-xfail-ISO11/signal.h/linknamespace = yes test-xfail-ISO11/stdio.h/linknamespace = yes test-xfail-ISO11/tgmath.h/linknamespace = yes test-xfail-XPG3/ctype.h/linknamespace = yes -- cgit 1.4.1