From 8e2f7c68111ba8fae795ee08b6822e21ab8cfa38 Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Wed, 21 Oct 2015 15:14:13 +0000 Subject: Use -Wold-style-definition. This patch makes glibc build with -Wold-style-definition to avoid old-style function definitions creeping back in by accident. Tested for x86_64 and x86 (testsuite, and that installed shared libraries are unchanged by the patch). Also tested build for arm, mips64 and powerpc32. Hopefully there aren't any remaining system-specific files with old-style definitions whose formatting evaded my searches, but if there are, they will be easy to fix. * Makeconfig (+gccwarn-c): Add -Wold-style-definition. * Makefile ($(objpfx)c++-types-check.out): Filter out $(+gccwarn-c) instead of -Wstrict-prototypes. --- Makeconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Makeconfig') diff --git a/Makeconfig b/Makeconfig index 1dc522c7ed..f3668c616a 100644 --- a/Makeconfig +++ b/Makeconfig @@ -752,7 +752,7 @@ endif ifeq ($(enable-werror),yes) +gccwarn += -Werror endif -+gccwarn-c = -Wstrict-prototypes ++gccwarn-c = -Wstrict-prototypes -Wold-style-definition # We do not depend on the address of constants in different files to be # actually different, so allow the compiler to merge them all. -- cgit 1.4.1