From f7b425175c3fa2f063a6c5657d84b799929db459 Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Mon, 6 Oct 2014 22:58:59 +0000 Subject: Support and use mixed compat/non-compat aliases in syscalls.list. This patch enables syscalls.list entries to specify both compat and non-compat symbol versions for the same syscall definition, making use of this for setrlimit / chown / lchown where the inability to specify such aliases showed up in the course of work on bug 14138. The change to make-syscalls.sh is minimal: adding a SHARED conditional on the compat_symbol calls. It remains the case that if a compat symbol version is specified, the syscall is only built for the shared library at all if an explicit symbol version is given for a non-compat symbol (so it's necessary to specify "lchown@@GLIBC_2.0 chown@GLIBC_2.0" rather than just "lchown chown@GLIBC_2.0"). It also remains the case, as already commented in make-syscalls.sh, that no SHLIB_COMPAT conditionals are generated, so there would be problems if the same syscalls.list file, with compat symbols, were used for both configurations that should have those symbols and configurations for which they should be conditioned out with SHLIB_COMPAT. Tested for x86. * sysdeps/unix/make-syscalls.sh (emit_weak_aliases): Condition compat_symbol calls on [SHARED]. * sysdeps/unix/sysv/linux/powerpc/lchown.S: Remove file. * sysdeps/unix/sysv/linux/i386/syscalls.list (oldsetrlimit): Remove. (setrlimit): Add setrlimit@GLIBC_2.0 alias. * sysdeps/unix/sysv/linux/m68k/m680x0/syscalls.list (oldsetrlimit): Remove. (setrlimit): Add setrlimit@GLIBC_2.0 alias. * sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list (lchown): New syscall entry. (oldsetrlimit): Remove. (setrlimit): Add setrlimit@GLIBC_2.0 alias. * sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list (oldsetrlimit): Remove. (setrlimit): Add setrlimit@GLIBC_2.0 alias. --- ChangeLog | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index 5a89797b45..29c5883ca6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,22 @@ 2014-10-06 Joseph Myers + * sysdeps/unix/make-syscalls.sh (emit_weak_aliases): Condition + compat_symbol calls on [SHARED]. + * sysdeps/unix/sysv/linux/powerpc/lchown.S: Remove file. + * sysdeps/unix/sysv/linux/i386/syscalls.list (oldsetrlimit): + Remove. + (setrlimit): Add setrlimit@GLIBC_2.0 alias. + * sysdeps/unix/sysv/linux/m68k/m680x0/syscalls.list + (oldsetrlimit): Remove. + (setrlimit): Add setrlimit@GLIBC_2.0 alias. + * sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list + (lchown): New syscall entry. + (oldsetrlimit): Remove. + (setrlimit): Add setrlimit@GLIBC_2.0 alias. + * sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list + (oldsetrlimit): Remove. + (setrlimit): Add setrlimit@GLIBC_2.0 alias. + [BZ #14138] * sysdeps/unix/sysv/linux/arm/fchown.c: Remove file. * sysdeps/unix/sysv/linux/arm/lchown.c: Likewise. -- cgit 1.4.1