From e442e40de5646e93bf31ace3e0c5159085a7259b Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Wed, 21 Nov 2018 11:41:05 +0000 Subject: io: Consolidate lockf implementation With internal fcntl64 internal (commit 06ab719d), it is possible to consolidate lockf implementation by using the LFS fcntl interface instead of using arch and system-specific implementations. For Linux, the i386 implementation is used as generic implementation by replacing the direct syscall with fcntl64 call. The LFS symbol alias for default LFS ABI (__OFF_T_MATCHES_OFF64_T) is used to avoid the duplicate symbol (instead of overriding the implementation with an empty file). For Hurd lockf64 semantic is changed: previous generic lockf64 implementation returned EOVERFLOW if LEN input is larger than 32-bit off_t. However, Hurd fcntl64 implementation for F_GETLK64, F_SETLK64, and F_SETLKW64 do accept off64_t inputs (__f_setlk accepts only off64_t inputs). Checked on i686-linux-gnu and x86_64-linux-gnu along with a i686-gnu build. * io/Makefile (tests): Add tst-lockf. * io/lockf.c (lockf): Use __fcntl and only define for !__OFF_T_MATCHES_OFF64_T. * io/lockf64.c (__lockf64): Call __fcntl64 and alias to lockf for __OFF_T_MATCHES_OFF64_T case. * io/tst-lockf.c: New file. * sysdeps/unix/sysv/linux/i386/lockf64.c: Remove file. * sysdeps/unix/sysv/linux/arm/lockf64.c: Likewise. * sysdeps/unix/sysv/linux/m68k/lockf64.c: Likewise. * sysdeps/unix/sysv/linux/mips/mips32/lockf64.c: Likewise. * sysdeps/unix/sysv/linux/mips/mips64/n32/lockf64.c: Likewise. * sysdeps/unix/sysv/linux/powerpc/powerpc32/lockf64.c: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/lockf64.c: Likewise. * sysdeps/unix/sysv/linux/sh/lockf64.c: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/lockf64.c: Likewise. --- ChangeLog | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index 39d44fd671..c38971ad23 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,21 @@ +2019-02-15 Adhemerval Zanella + + * io/Makefile (tests): Add tst-lockf. + * io/lockf.c (lockf): Use __fcntl and only define for + !__OFF_T_MATCHES_OFF64_T. + * io/lockf64.c (__lockf64): Call __fcntl64 and alias to lockf for + __OFF_T_MATCHES_OFF64_T case. + * io/tst-lockf.c: New file. + * sysdeps/unix/sysv/linux/i386/lockf64.c: Remove file. + * sysdeps/unix/sysv/linux/arm/lockf64.c: Likewise. + * sysdeps/unix/sysv/linux/m68k/lockf64.c: Likewise. + * sysdeps/unix/sysv/linux/mips/mips32/lockf64.c: Likewise. + * sysdeps/unix/sysv/linux/mips/mips64/n32/lockf64.c: Likewise. + * sysdeps/unix/sysv/linux/powerpc/powerpc32/lockf64.c: Likewise. + * sysdeps/unix/sysv/linux/s390/s390-32/lockf64.c: Likewise. + * sysdeps/unix/sysv/linux/sh/lockf64.c: Likewise. + * sysdeps/unix/sysv/linux/sparc/sparc32/lockf64.c: Likewise. + 2019-02-15 Florian Weimer [BZ #24211] -- cgit 1.4.1