From 126c4e3f804881f9fbc4eb71787f41793d2d7be5 Mon Sep 17 00:00:00 2001 From: Wilco Dijkstra Date: Wed, 15 Aug 2018 16:01:21 +0100 Subject: Use generic sinf/cosf in lgammaf_r The internal functions __kernel_sinf and __kernel_cosf are used only by lgammaf_r. Removing the internal functions and using the generic sinf and cosf is better overall. Benchmarking on Cortex-A72 shows the generic sinf and cosf are 1.4x and 2.3x faster in the range |x| < PI/4, and 0.66x and 1.1x for |x| < PI/2, so it should make lgammaf_r faster on average. GLIBC regression tests pass on AArch64. * sysdeps/ieee754/flt-32/e_lgammaf_r.c (sin_pif): Use __sinf/__cosf. * sysdeps/ieee754/flt-32/k_cosf.c (__kernel_cosf): Remove all code. * sysdeps/ieee754/flt-32/k_sinf.c (__kernel_sinf): Likewise. --- ChangeLog | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index f1cc02c1ef..21404da510 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2018-08-15 Wilco Dijkstra + + * sysdeps/ieee754/flt-32/e_lgammaf_r.c (sin_pif): Use __sinf/__cosf. + * sysdeps/ieee754/flt-32/k_cosf.c (__kernel_cosf): Remove all code. + * sysdeps/ieee754/flt-32/k_sinf.c (__kernel_sinf): Likewise. + 2018-08-15 Wilco Dijkstra * sysdeps/x86_64/fpu/libm-test-ulps: Regenerate to fix spaces. -- cgit 1.4.1