From f8aa69be445f65bb36cb3ae9291423600da7d6d2 Mon Sep 17 00:00:00 2001 From: Aurelien Jarno Date: Fri, 29 Dec 2017 14:44:57 +0100 Subject: tst-realloc: do not check for errno on success [BZ #22611] POSIX explicitly says that applications should check errno only after failure, so the errno value can be clobbered on success as long as it is not set to zero. Changelog: [BZ #22611] * malloc/tst-realloc.c (do_test): Remove the test checking that errno is unchanged on success. --- ChangeLog | 6 ++++++ malloc/tst-realloc.c | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index a1e065e62c..02f491b6b0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2017-12-29 Aurelien Jarno + + [BZ #22611] + * malloc/tst-realloc.c (do_test): Remove the test checking that errno + is unchanged on success. + 2017-12-27 Dmitry V. Levin * elf/dl-dst.h (DL_DST_COUNT): Remove is_path argument, all callers diff --git a/malloc/tst-realloc.c b/malloc/tst-realloc.c index 31a58bd026..d942c6e536 100644 --- a/malloc/tst-realloc.c +++ b/malloc/tst-realloc.c @@ -66,10 +66,6 @@ do_test (void) if (p == NULL) merror ("realloc (NULL, 10) failed."); - /* errno should be clear on success (POSIX). */ - if (p != NULL && save != 0) - merror ("errno is set but should not be"); - free (p); p = calloc (20, 1); -- cgit 1.4.1