From b31606c0e1d9f04e2498b7c8262f7de87daa7ce7 Mon Sep 17 00:00:00 2001 From: Pino Toscano Date: Fri, 28 Sep 2012 18:35:43 +0200 Subject: aio_fsync: fix the access mode check Make use of O_ACCMODE and O_RDONLY instead of assuming details of the O_* flags. --- ChangeLog | 4 ++++ sysdeps/pthread/aio_fsync.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 27cf3a9503..207519baee 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2012-09-28 Pino Toscano + + * sysdeps/pthread/aio_fsync.c: Fix the file mode checking. + 2012-09-28 Dmitry V. Levin [BZ #11438] diff --git a/sysdeps/pthread/aio_fsync.c b/sysdeps/pthread/aio_fsync.c index 046e25c171..5b5d1863e7 100644 --- a/sysdeps/pthread/aio_fsync.c +++ b/sysdeps/pthread/aio_fsync.c @@ -46,7 +46,7 @@ aio_fsync (int op, struct aiocb *aiocbp) flags = fcntl (aiocbp->aio_fildes, F_GETFL); if (__builtin_expect (flags == -1, 0) - || __builtin_expect ((flags & (O_RDWR | O_WRONLY)) == 0, 0)) + || __builtin_expect ((flags & O_ACCMODE) == O_RDONLY, 0)) { __set_errno (EBADF); return -1; -- cgit 1.4.1