From 986ae1d6ff82013ae0002745fb1a6b1aeb317b9f Mon Sep 17 00:00:00 2001 From: John David Anglin Date: Sun, 10 Aug 2014 09:54:53 -0400 Subject: hppa: fix pthread spinlock --- sysdeps/hppa/nptl/pthread_spin_init.c | 8 ++++---- sysdeps/hppa/nptl/pthread_spin_unlock.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/sysdeps/hppa/nptl/pthread_spin_init.c b/sysdeps/hppa/nptl/pthread_spin_init.c index c83669eb91..b0ff78917b 100644 --- a/sysdeps/hppa/nptl/pthread_spin_init.c +++ b/sysdeps/hppa/nptl/pthread_spin_init.c @@ -20,9 +20,9 @@ int pthread_spin_init (pthread_spinlock_t *lock, int pshared) { - int tmp = 0; - /* This should be a memory barrier to newer compilers */ - __asm__ __volatile__ ("stw,ma %1,0(%0)" - : : "r" (lock), "r" (tmp) : "memory"); + /* The LWS-CAS operation on hppa is a synthetic atomic operation + that doesn't provide the type of coherency that we need. Therefore + we force that coherency by using LWS-CAS again. */ + atomic_exchange_rel (lock, 0); return 0; } diff --git a/sysdeps/hppa/nptl/pthread_spin_unlock.c b/sysdeps/hppa/nptl/pthread_spin_unlock.c index 5a8aed8e38..7a4a996b8e 100644 --- a/sysdeps/hppa/nptl/pthread_spin_unlock.c +++ b/sysdeps/hppa/nptl/pthread_spin_unlock.c @@ -20,9 +20,9 @@ int pthread_spin_unlock (pthread_spinlock_t *lock) { - int tmp = 0; - /* This should be a memory barrier to newer compilers */ - __asm__ __volatile__ ("stw,ma %1,0(%0)" - : : "r" (lock), "r" (tmp) : "memory"); + /* The LWS-CAS operation on hppa is a synthetic atomic operation + that doesn't provide the type of coherency that we need. Therefore + we force that coherency by using LWS-CAS again. */ + atomic_exchange_rel (lock, 0); return 0; } -- cgit 1.4.1