From 95a4e1ea3b019e60bb260d6e70b1657ea27770e8 Mon Sep 17 00:00:00 2001 From: Chris Metcalf Date: Wed, 3 Jul 2013 14:48:39 -0400 Subject: tile: use _dl_static_init to set GLRO(gl_pagesize) A recently-added test (dlfcn/tststatic5) pointed out that tile was not properly initializing the variable pagesize in certain cases. This change just copies the existing code from MIPS. --- ports/ChangeLog.tile | 6 ++ ports/sysdeps/unix/sysv/linux/tile/Makefile | 6 ++ ports/sysdeps/unix/sysv/linux/tile/Versions | 6 ++ ports/sysdeps/unix/sysv/linux/tile/dl-static.c | 84 ++++++++++++++++++++++++++ ports/sysdeps/unix/sysv/linux/tile/ldsodefs.h | 32 ++++++++++ 5 files changed, 134 insertions(+) create mode 100644 ports/sysdeps/unix/sysv/linux/tile/dl-static.c create mode 100644 ports/sysdeps/unix/sysv/linux/tile/ldsodefs.h diff --git a/ports/ChangeLog.tile b/ports/ChangeLog.tile index 9a60357698..88da5e81d2 100644 --- a/ports/ChangeLog.tile +++ b/ports/ChangeLog.tile @@ -1,5 +1,11 @@ 2013-07-03 Chris Metcalf + * sysdeps/unix/sysv/linux/tile/dl-static.c: New file to support + variable page size for tile. + * sysdeps/unix/sysv/linux/tile/ldsodefs.h: Likewise. + * sysdeps/unix/sysv/linux/tile/Makefile: Build dl-static in elf. + * sysdeps/unix/sysv/linux/tile/Versions: Add _dl_var_init. + * sysdeps/tile/libm-test-ulps: Update with new tests. * sysdeps/tile/s_fma.c: Use soft-fp version instead of ieee754. diff --git a/ports/sysdeps/unix/sysv/linux/tile/Makefile b/ports/sysdeps/unix/sysv/linux/tile/Makefile index 1c0c968dc1..0bcb95f63a 100644 --- a/ports/sysdeps/unix/sysv/linux/tile/Makefile +++ b/ports/sysdeps/unix/sysv/linux/tile/Makefile @@ -16,4 +16,10 @@ endif ifeq ($(subdir),elf) sysdep_routines += dl-vdso +ifeq ($(build-shared),yes) +# This is needed for DSO loading from static binaries. +sysdep-dl-routines += dl-static +sysdep_routines += dl-static +sysdep-rtld-routines += dl-static +endif endif diff --git a/ports/sysdeps/unix/sysv/linux/tile/Versions b/ports/sysdeps/unix/sysv/linux/tile/Versions index 1df7518c78..9b40d2839f 100644 --- a/ports/sysdeps/unix/sysv/linux/tile/Versions +++ b/ports/sysdeps/unix/sysv/linux/tile/Versions @@ -1,3 +1,9 @@ +ld { + GLIBC_PRIVATE { + # used for loading by static libraries + _dl_var_init; + } +} libc { GLIBC_2.12 { _flush_cache; diff --git a/ports/sysdeps/unix/sysv/linux/tile/dl-static.c b/ports/sysdeps/unix/sysv/linux/tile/dl-static.c new file mode 100644 index 0000000000..5b59a04dc4 --- /dev/null +++ b/ports/sysdeps/unix/sysv/linux/tile/dl-static.c @@ -0,0 +1,84 @@ +/* Variable initialization. Tile version. + Copyright (C) 2001-2013 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#include + +#ifdef SHARED + +void +_dl_var_init (void *array[]) +{ + /* It has to match "variables" below. */ + enum + { + DL_PAGESIZE = 0 + }; + + GLRO(dl_pagesize) = *((size_t *) array[DL_PAGESIZE]); +} + +#else + +static void *variables[] = +{ + &GLRO(dl_pagesize) +}; + +static void +_dl_unprotect_relro (struct link_map *l) +{ + ElfW(Addr) start = ((l->l_addr + l->l_relro_addr) + & ~(GLRO(dl_pagesize) - 1)); + ElfW(Addr) end = ((l->l_addr + l->l_relro_addr + l->l_relro_size) + & ~(GLRO(dl_pagesize) - 1)); + + if (start != end) + __mprotect ((void *) start, end - start, PROT_READ | PROT_WRITE); +} + +void +_dl_static_init (struct link_map *l) +{ + struct link_map *rtld_map = l; + struct r_scope_elem **scope; + const ElfW(Sym) *ref = NULL; + lookup_t loadbase; + void (*f) (void *[]); + size_t i; + + loadbase = _dl_lookup_symbol_x ("_dl_var_init", l, &ref, l->l_local_scope, + NULL, 0, 1, NULL); + + for (scope = l->l_local_scope; *scope != NULL; scope++) + for (i = 0; i < (*scope)->r_nlist; i++) + if ((*scope)->r_list[i] == loadbase) + { + rtld_map = (*scope)->r_list[i]; + break; + } + + if (ref != NULL) + { + f = (void (*) (void *[])) DL_SYMBOL_ADDRESS (loadbase, ref); + _dl_unprotect_relro (rtld_map); + f (variables); + _dl_protect_relro (rtld_map); + } +} + +#endif diff --git a/ports/sysdeps/unix/sysv/linux/tile/ldsodefs.h b/ports/sysdeps/unix/sysv/linux/tile/ldsodefs.h new file mode 100644 index 0000000000..92877e53d1 --- /dev/null +++ b/ports/sysdeps/unix/sysv/linux/tile/ldsodefs.h @@ -0,0 +1,32 @@ +/* Run-time dynamic linker data structures for loaded ELF shared objects. Tile. + Copyright (C) 2001-2013 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef _LDSODEFS_H + +/* Get the real definitions. */ +#include_next + +/* Now define our stuff. */ + +/* We need special support to initialize DSO loaded for statically linked + binaries. */ +extern void _dl_static_init (struct link_map *map); +#undef DL_STATIC_INIT +#define DL_STATIC_INIT(map) _dl_static_init (map) + +#endif /* ldsodefs.h */ -- cgit 1.4.1