From 2c3d9ba9a332cecb009b97ebac5bb78a13118c7c Mon Sep 17 00:00:00 2001 From: ryanarn Date: Fri, 1 Jul 2011 09:42:21 -0500 Subject: Remove pthread_attr_setstacksize from __aio_create_helper_thread. --- ChangeLog | 8 ++++++++ nptl/sysdeps/unix/sysv/linux/aio_misc.h | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9ad4d2e1b3..5ec2eb3272 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2011-06-30 Ryan S. Arnold + + * nptl/sysdeps/unix/sysv/linux/aio_misc.h + (__aio_create_helper_thread): Remove call to + pthread_attr_setstacksize () which set the stacksize to + PTHREAD_STACK_MIN. This is too small if large amounts of TLS are in + use. Removing this call effectively sets stacksize to 'default'. + 2011-03-15 Alan Modra * elf/dl-reloc.c (_dl_try_allocate_static_tls ): Handle diff --git a/nptl/sysdeps/unix/sysv/linux/aio_misc.h b/nptl/sysdeps/unix/sysv/linux/aio_misc.h index 406d96e865..2bf7c17aed 100644 --- a/nptl/sysdeps/unix/sysv/linux/aio_misc.h +++ b/nptl/sysdeps/unix/sysv/linux/aio_misc.h @@ -46,8 +46,8 @@ __aio_create_helper_thread (pthread_t *threadp, void *(*tf) (void *), pthread_attr_init (&attr); pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED); - /* The helper thread needs only very little resources. */ - (void) pthread_attr_setstacksize (&attr, PTHREAD_STACK_MIN); + /* Don't set the stacksize to PTHREAD_STACK_MIN. Let it default, otherwise + the stack may be too small if TLS is in use. */ /* Block all signals in the helper thread. To do this thoroughly we temporarily have to block all signals here. */ -- cgit 1.4.1