about summary refs log tree commit diff
path: root/support
Commit message (Collapse)AuthorAgeFilesLines
* nss_files: Fix /etc/aliases null pointer dereference [BZ #24059]Florian Weimer2019-01-312-0/+4
| | | | | | | | If /etc/aliases ends with a continuation line (a line that starts with whitespace) which does not have a trailing newline character, the file parser would crash due to a null pointer dereference. Reviewed-by: Carlos O'Donell <carlos@redhat.com>
* hurd: Fix libsupport xsigstack buildAdhemerval Zanella2019-01-241-0/+7
| | | | | | | | | Hurd does not support MAP_NORESERVE and MAP_STACK. Checked on i686-gnu build. * support/xsigstack.c (MAP_NORESERVE, MAP_STACK): Define if they are not defined.
* Tests for minimal signal handler functionality in MINSIGSTKSZ space.Zack Weinberg2019-01-164-0/+190
| | | | | | | | | | | | | | | | | | | | | | | There is general agreement that the very short list of things that ISO C says you can do in an async signal handler should all work when the handler is running on an alternate signal stack with only MINSIGSTKSZ space. This patch adds tests to make sure those things do work. To facilitate this, there is a new set of test support routines for setting up alternate signal stacks; see support/xsignal.h for the API. * support/xsignal.h (xalloc_sigstack, xfree_sigstack) (xget_sigstack_location): New test support functions. * support/xsigstack.c: New file, implementing them. * support/tst-xsigstack.c: New test for them. * support/Makefile: Update. * signal/tst-minsigstksz-1.c * signal/tst-minsigstksz-2.c * signal/tst-minsigstksz-3.c * signal/tst-minsigstksz-3a.c * signal/tst-minsigstksz-4.c: New tests. * signal/Makefile: Run them.
* Update copyright dates with scripts/update-copyrights.Joseph Myers2019-01-01169-169/+169
| | | | | | | * All files with FSF copyright notices: Update copyright dates using scripts/update-copyrights. * locale/programs/charmap-kw.h: Regenerated. * locale/programs/locfile-kw.h: Likewise.
* Replace check_mul_overflow_size_t with __builtin_mul_overflowAdhemerval Zanella2018-12-281-23/+3
| | | | | | | | | | | | | | | Checked on x86_64-linux-gnu and i686-linux-gnu. * malloc/alloc_buffer_alloc_array.c (__libc_alloc_buffer_alloc_array): Use __builtin_mul_overflow in place of check_mul_overflow_size_t. * malloc/dynarray_emplace_enlarge.c (__libc_dynarray_emplace_enlarge): Likewise. * malloc/dynarray_resize.c (__libc_dynarray_resize): Likewise. * malloc/reallocarray.c (__libc_reallocarray): Likewise. * malloc/malloc-internal.h (check_mul_overflow_size_t): Remove function. * support/blob_repeat.c (check_mul_overflow_size_t, (minimum_stride_size, support_blob_repeat_allocate): Likewise.
* support: Do not require overflow builtin in support/blob_repeat.cFlorian Weimer2018-12-151-3/+23
| | | | | | It is only available in GCC 5 and later. Tested-by: Romain Naour <romain.naour@gmail.com>
* test-container: move postclean outside of namespace changesDJ Delorie2018-12-101-8/+37
| | | | | | | | | | | | | | | | | | | | During postclean.req testing it was found that the fork in the parent process (after the unshare syscall) would fail with ENOMEM (see recursive_remove() in test-container.c). While failing with ENOMEM is certainly unexpected, it is simply easier to refactor the design and have the parent remain outside of the namespace. This change moves the postclean.req processing to a distinct process (the parent) that then forks the test process (which will have to fork once more to complete uid/gid transitions). When the test process exists the cleanup process will ensure all files are deleted when a post clean is requested. Signed-off-by: DJ Delorie <dj@redhat.com> Reviewed-by: Carlos O'Donell <carlos@redhat.com> [BZ #23948] * support/test-container.c: Move postclean step to before we change namespaces.
* support: Implement <support/descriptors.h> to track file descriptorsFlorian Weimer2018-12-066-0/+533
|
* test-container: add "su" command to run test as root, add unshare hintsDJ Delorie2018-12-041-4/+64
| | | | | | * support/test-container.c (check_for_unshare_hints): New. (main): Call it if unshare fails. Add support for "su" scriptlet command.
* support: Close original descriptors in support_capture_subprocessFlorian Weimer2018-12-011-0/+6
|
* support: Add signal support to support_capture_subprocess_checkFlorian Weimer2018-11-283-11/+59
| | | | | | | | Signal zero does not terminate a process, so it is safe to use negative values for signal numbers. Adjust libio/tst-vtables-common.c to use this new functionality, instead of determining the termination status for a signal indirectly.
* support_quote_string: Do not use str parameter nameFlorian Weimer2018-11-281-2/+2
| | | | | This avoids a build failure if this identifier is used as a macro in a test.
* support: Implement support_quote_stringFlorian Weimer2018-11-274-0/+93
| | | | Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
* support: Print timestamps in timeout handlerFlorian Weimer2018-11-191-0/+28
| | | | | | This is sometimes useful to determine if a test truly got stuck, or if it was making progress (logging information to standard output) and was merely slow to finish.
* support: Fix printf format for TEST_COMPARE_STRINGAdhemerval Zanella2018-11-071-1/+1
| | | | | | | | | | | | | | | | Fix the following on 32 bits targets: support_test_compare_string.c: In function ‘support_test_compare_string’: support_test_compare_string.c:80:37: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘size_t’ {aka ‘unsigned int’} [-Werror=format=] printf (" string length: %lu bytes\n", left_length); ~~^ ~~~~~~~~~~~ %u Checked on arm-linux-gnueabihf. * support/support_test_compare_string.c (support_test_compare_string): Fix printf format.
* support: Implement TEST_COMPARE_STRINGFlorian Weimer2018-11-074-0/+213
|
* support/shell-container.c: Use support_copy_file_rangeFlorian Weimer2018-11-021-1/+1
| | | | Reviewed-by: DJ Delorie <dj@redhat.com>
* support/test-container.c: Include <libc-pointer-arith.h>Florian Weimer2018-11-021-0/+1
| | | | Reviewed-by: DJ Delorie <dj@redhat.com>
* support_blob_repeat: Call mkstemp directory for the backing fileFlorian Weimer2018-10-301-5/+9
| | | | This avoids a warning during post-test cleanup.
* stdlib/test-bz22786: Avoid spurious test failures using alias mappingsFlorian Weimer2018-10-304-0/+409
| | | | | | | | On systems without enough random-access memory, stdlib/test-bz22786 will go deeply into swap and time out, even with a substantial TIMEOUTFACTOR. This commit adds a facility to construct repeating strings with alias mappings, so that the requirement for physical memory, and uses it in stdlib/test-bz22786.
* Adjust name of ld.so in test-container.c.Stefan Liebler2018-10-044-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | The test-container.c file assumes that ld.so is always named something like /elf/ld-linux-*. But e.g. on s390x it is named ld64.so.1 or ld.so.1 on s390. There are other architectures like power or mips with similar names. This patch introduces the new global variable support_objdir_elf_ldso which contains the absolute path to the runtime linker used by the testsuite, e.g. OBJDIR_PATH/elf/ld-linux-x86-64.so.2. The check in test-container.c is now comparing against this path. Without this patch, test-container.c is searching invalid files / directories and fails to find glibc/nss/tst-nss-test3.root/tst-nss-test3.script. Then the test tst-nss-test3 fails! Reviewed-by: Carlos O'Donell <carlos@redhat.com> ChangeLog: * support/support.h (support_objdir_elf_ldso): New variable. * support/support_paths.c (support_objdir_elf_ldso): Likewise. * support/Makefile (CFLAGS-support_paths.c): Add definition for OBJDIR_ELF_LDSO_PATH. * support/test-container.c (main): Search for the ld.so which is also used by the testsuite.
* test-container: Use xcopy_file_range for cross-device copy [BZ #23597]H.J. Lu2018-08-316-2/+186
| | | | | | | | | | | | | | | | | | | | copy_file_range can't be used to copy a file from glibc source directory to glibc build directory since they may be on different filesystems. This patch adds xcopy_file_range for cross-device copy. Reviewed-by: Carlos O'Donell <carlos@redhat.com> [BZ #23597] * support/Makefile (libsupport-routines): Add support_copy_file_range and xcopy_file_range. * support/support.h: Include <sys/types.h>. (support_copy_file_range): New prototype. * support/support_copy_file_range.c: New file. Copied and modified from io/copy_file_range-compat.c. * support/test-container.c (copy_one_file): Call xcopy_file_rang instead of copy_file_range. * support/xcopy_file_range.c: New file. * support/xunistd.h (xcopy_file_range): New prototype.
* test-container: EPERM from unshare is UNSUPPORTEDFlorian Weimer2018-08-281-2/+3
| | | | | For example, the security policy on the Fedora build daemons results in this EPERM error.
* links-dso-program: Fix build-programs=no build case.DJ Delorie2018-08-271-10/+0
| | | | | * support/Makefile (others): Don't list programs explicitly as a dependency of "others".
* Fix IA64 links-dso-program link.DJ Delorie2018-08-241-1/+1
| | | | | * support/Makefile (LDLIBS-links-dso-program): Add -lgcc and $(libunwind).
* Add test-in-container infrastructure.DJ Delorie2018-08-2212-0/+1667
| | | | | | | | | | | | | | | | | | | | | | | | | * Makefile (testroot.pristine): New rules to initialize the test-in-container "testroot". * Makerules (all-testsuite): Add tests-container. * Rules (tests-expected): Add tests-container. (binaries-all-tests): Likewise. (tests-container): New, run these tests in the testroot container. * support/Makefile (others): Add *-container, support_paths.c, xmkdirp, and links-dso-program. * support/links-dso-program-c.c: New. * support/links-dso-program.cc: New. * support/test-container.c: New. * support/shell-container.c: New. * support/echo-container.c: New. * support/true-container.c: New. * support/xmkdirp.c: New. * support/xsymlink.c: New. * support/support_paths.c: New. * support/support.h: Add support paths prototypes. * support/xunistd.h: Add xmkdirp () and xsymlink (). * nss/tst-nss-test3.c: Convert to test-in-container. * nss/tst-nss-test3.root/: New.
* Avoid running some tests if the file system does not support holesFlorian Weimer2018-08-213-0/+94
| | | | | Otherwise, these tests fills up the entire disk (or just run very slowly and eventually time out).
* support: Add TEST_NO_SETVBUFFlorian Weimer2018-06-263-1/+7
| | | | | This is sometimes needed for testing stdio streams, where the setvbuf call in the test driver could interfere with the test.
* support: Add wrappers for pthread_barrierattr_tFlorian Weimer2018-05-295-0/+84
|
* Switch IDNA implementation to libidn2 [BZ #19728] [BZ #19729] [BZ #22247]Florian Weimer2018-05-231-2/+0
| | | | | This provides an implementation of the IDNA2008 standard and fixes CVE-2016-6261, CVE-2016-6263, CVE-2017-14062.
* support: Add TEST_COMPARE_BLOB, support_quote_blobFlorian Weimer2018-05-167-0/+377
| | | | | | | The declaration of support_test_compare_blob uses unsigned long int, to avoid including <stddef.h>. Reviewed-by: Carlos O'Donell <carlos@redhat.com>
* support_format_addrinfo: Include unknown error number in resultFlorian Weimer2018-04-011-1/+5
|
* [BZ 1190] Make EOF sticky in stdio.Zack Weinberg2018-03-133-0/+155
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | C99 specifies that the EOF condition on a file is "sticky": once EOF has been encountered, all subsequent reads should continue to return EOF until the file is closed or something clears the "end-of-file indicator" (e.g. fseek, clearerr). This is arguably a change from C89, where the wording was ambiguous; the BSDs always had sticky EOF, but the System V lineage would attempt to read from the underlying fd again. GNU libc has followed System V for as long as we've been using libio, but nowadays C99 conformance and BSD compatibility are more important than System V compatibility. You might wonder if changing the _underflow impls is sufficient to apply the C99 semantics to all of the many stdio functions that perform input. It should be enough to cover all paths to _IO_SYSREAD, and the only other functions that call _IO_SYSREAD are the _seekoff impls, which is OK because seeking clears EOF, and the _xsgetn impls, which, as far as I can tell, are unused within glibc. The test programs in this patch use a pseudoterminal to set up the necessary conditions. To facilitate this I added a new test-support function that sets up a pair of pty file descriptors for you; it's almost the same as BSD openpty, the only differences are that it allocates the optionally-returned tty pathname with malloc, and that it crashes if anything goes wrong. [BZ #1190] [BZ #19476] * libio/fileops.c (_IO_new_file_underflow): Return EOF immediately if the _IO_EOF_SEEN bit is already set; update commentary. * libio/oldfileops.c (_IO_old_file_underflow): Likewise. * libio/wfileops.c (_IO_wfile_underflow): Likewise. * support/support_openpty.c, support/tty.h: New files. * support/Makefile (libsupport-routines): Add support_openpty. * libio/tst-fgetc-after-eof.c, wcsmbs/test-fgetwc-after-eof.c: New test cases. * libio/Makefile (tests): Add tst-fgetc-after-eof. * wcsmbs/Makefile (tests): Add tst-fgetwc-after-eof.
* support: Preserve errno in write_message, TEST_VERIFY and other checksFlorian Weimer2018-01-124-0/+12
| | | | | These facilities could clobber errno, which makes it difficult to write certain checks because a specific order has to be used.
* resolv: Support binary labels in test frameworkFlorian Weimer2018-01-081-133/+161
| | | | | | | | | | The old implementation based on hsearch_r used an ad-hoc C string encoding and produced an incorrect format on the wire for domain names which contained bytes which needed escaping when printed. This commit switches to ns_name_pton for the wire format conversion (now that we have separate tests for it) and uses a tsearch tree with a suitable comparison function to locate compression targets.
* support: Increase usability of TEST_COMPAREFlorian Weimer2018-01-083-32/+37
| | | | | | | | | | | | | | | | | | | | | The previous implementation of the TEST_COMPARE macro would fail to compile code like this: int ret = res_send (query, sizeof (query), buf, sizeof (buf)); TEST_COMPARE (ret, sizeof (query) + 2 /* Compression reference. */ + 2 + 2 + 4 + 2 /* Type, class, TTL, RDATA length. */ + 1 /* Pascal-style string length. */ + strlen (expected_name)); This resulted in a failed static assertion, "integer conversions may alter sign of operands". A user of the TEST_COMPARE would have to add a cast to fix this. This patch reverts to the original proposed solution of a run-time check, making TEST_COMPARE usable for comparisons of numbers with types with different signedness in more contexts.
* support: Define support_static_assert for use with C and C++Florian Weimer2018-01-081-9/+16
| | | | And update TEST_COMPARE to use it, to make it usable from C++.
* support_enter_mount_namespace: Fix indentationSamuel Thibault2018-01-041-1/+1
| | | | * support/support_enter_mount_namespace.c: Fix indentation.
* hurd: Fix support/support_enter_mount_namespace.c buildSamuel Thibault2018-01-041-0/+2
| | | | | * support/support_enter_mount_namespace.c [!CLONE_NEWNS]: Do not include <sys/mount.h>.
* Update copyright dates with scripts/update-copyrights.Joseph Myers2018-01-01140-140/+140
| | | | | | | * All files with FSF copyright notices: Update copyright dates using scripts/update-copyrights. * locale/programs/charmap-kw.h: Regenerated. * locale/programs/locfile-kw.h: Likewise.
* copy_file_range: New function to copy file dataFlorian Weimer2017-12-225-0/+90
| | | | | The semantics are based on the Linux system call, but a very close emulation in user space is provided.
* support: Simplify compiling most of support/ outside of glibcFlorian Weimer2017-12-1411-2/+11
| | | | | | | Some include files were missing because they are implied by the in-tree build process. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
* Linux: Implement interfaces for memory protection keysFlorian Weimer2017-12-057-1/+133
| | | | | | | | | | | | | | | | This adds system call wrappers for pkey_alloc, pkey_free, pkey_mprotect, and x86-64 implementations of pkey_get and pkey_set, which abstract over the PKRU CPU register and hide the actual number of memory protection keys supported by the CPU. pkey_mprotect with a -1 key is implemented using mprotect, so it will work even if the kernel does not support the pkey_mprotect system call. The system call wrapers use unsigned int instead of unsigned long for parameters, so that no special treatment for x32 is needed. The flags argument is currently unused, and the access rights bit mask is limited to two bits by the current PKRU register layout anyway. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
* support/tst-test_compare: Fix 32-bit/64-bit expected output mismatchFlorian Weimer2017-12-051-2/+2
| | | | | | The use of a long type resulted in test output differences between 32-bit and 64-bit architectures, causing the test to fail on 32-bit architectures.
* support: Add TEST_COMPARE macroFlorian Weimer2017-12-044-0/+216
|
* support_become_root: Fix comment styleChristian Brauner2017-11-181-1/+1
|
* support_become_root: Don't fail when /proc/<pid/setgroups is missingChristian Brauner2017-11-181-5/+16
| | | | | | | The requirement to write "deny" to /proc/<pid>/setgroups for a given user namespace before being able to write a gid mapping was introduced in Linux 3.19. Before that this requirement including the file did not exist. So don't fail when errno == ENOENT.
* support_enter_mount_namespace: Unshare with mount --make-rprivateFlorian Weimer2017-11-183-0/+51
| | | | | | | System defaults vary, and a mere unshare (CLONE_NEWNS) (which is part of support_become_root) is no longer sufficient. Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
* support_create_temp_directory: Align behavior with create_temp_fileFlorian Weimer2017-11-184-15/+10
| | | | | | | | create_temp_file automatically supplies the test directory and the XXXXXX suffix. support_create_temp_directory required the caller to specify them, which was confusing. Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
* support_become_root: Enable file creation in user namespacesFlorian Weimer2017-11-171-3/+54
| | | | | | | | Without UID/GID maps, file creation will file with EOVERFLOW. This patch is based on DJ Delorie's work on container testing. Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-07-07 13:07:31 +0000