about summary refs log tree commit diff
path: root/support
Commit message (Collapse)AuthorAgeFilesLines
* support_become_root: Fix comment styleChristian Brauner2017-11-181-1/+1
|
* support_become_root: Don't fail when /proc/<pid/setgroups is missingChristian Brauner2017-11-181-5/+16
| | | | | | | The requirement to write "deny" to /proc/<pid>/setgroups for a given user namespace before being able to write a gid mapping was introduced in Linux 3.19. Before that this requirement including the file did not exist. So don't fail when errno == ENOENT.
* support_enter_mount_namespace: Unshare with mount --make-rprivateFlorian Weimer2017-11-183-0/+51
| | | | | | | System defaults vary, and a mere unshare (CLONE_NEWNS) (which is part of support_become_root) is no longer sufficient. Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
* support_create_temp_directory: Align behavior with create_temp_fileFlorian Weimer2017-11-184-15/+10
| | | | | | | | create_temp_file automatically supplies the test directory and the XXXXXX suffix. support_create_temp_directory required the caller to specify them, which was confusing. Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
* support_become_root: Enable file creation in user namespacesFlorian Weimer2017-11-171-3/+54
| | | | | | | | Without UID/GID maps, file creation will file with EOVERFLOW. This patch is based on DJ Delorie's work on container testing. Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
* support: Add <support/next_to_fault.h>Florian Weimer2017-11-133-0/+101
| | | | Based on the implementation in resolv/tst-inet_pton.c.
* support: Add xstrndup, xunlink, xreadlink, support_create_temp_directoryFlorian Weimer2017-11-1210-5/+207
|
* support_format_hostent: Add more error information for NETDB_INTERNALFlorian Weimer2017-10-051-4/+10
|
* Revert "resolv_test.c: also cope with CONNREFUSED errors returned by recvfrom"Samuel Thibault2017-09-251-7/+1
| | | | This reverts commit 6174537c24cfe324d6e8f5a2a421883df12b8b6a.
* resolv_test.c: also cope with CONNREFUSED errors returned by recvfromSamuel Thibault2017-09-251-1/+7
| | | | | | | | | | | server_thread_udp_process_one already takes care of calling sendto() instead of xsendto to be able to ignore the case where the client has closed the socket. Depending on the TCP/IP stack behavior, this error could be notified later through recvfrom(), so we need to ignore it there too. * support/resolv_test.c (server_thread_udp_process_one): Call recvfrom instead of xrecvfrom, and ignore ECONNREFUSED errors.
* Implement xdlopen, xdlsym and xdlclose routines which terminate testPaul Pluzhnikov2017-09-203-0/+93
| | | | | | | program with appropriate message if the corresponding dlfcn.h routine returns an error. Use them in stdlib/tst-tls-atexit.c
* support_chroot_create: Add support for /etc/hosts, /etc/host.confFlorian Weimer2017-09-012-12/+31
|
* rwlock: Fix explicit hand-over (bug 21298)Carlos O'Donell2017-07-288-0/+172
| | | | | | | Without this fix, the rwlock can fail to execute the explicit hand-over in certain cases (e.g., empty critical sections that switch quickly between read and write phases). This can then lead to errors in how __wrphase_futex is accessed, which in turn can lead to deadlocks.
* support: Add resolver testing mode which does not patch _resFlorian Weimer2017-07-052-2/+45
|
* support: Add support_chroot_create and support_chroot_freeFlorian Weimer2017-07-053-0/+104
|
* support: Check isolation of loopback addresses in tst-support-namespaceFlorian Weimer2017-07-051-2/+82
|
* support: Report actual exit status in support_capture_subprocess_checkFlorian Weimer2017-06-301-1/+1
|
* __inet_pton_length: Implement new internal helper functionFlorian Weimer2017-06-213-1/+30
|
* support: Add optstring supportAdhemerval Zanella2017-06-153-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds an option to test to add small command line option through CMDLINE_OPTSTRING define. For instance: #define CMDLINE_OPTSTRING "vd" static void cmdline_process_function (int c) { switch (c): 'v': /* process '-v' option. */ break; 'd': /* process '-d' option. */ break; } #define CMDLINE_PROCESS cmdline_process_function It will add both '-v' and '-d' along with already default long options. * support/support_test_main.c (support_test_main): Use optstring member for option string in getopt_long. * support/test-driver.c: Add comment about CMDLINE_OPTSTRING. (CMDLINE_OPTSTRING): New define. * support/test-driver.h (test_config): Add optstring member.
* nptl: Invert the mmap/mprotect logic on allocated stacks (BZ#18988)Adhemerval Zanella2017-06-143-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Current allocate_stack logic for create stacks is to first mmap all the required memory with the desirable memory and then mprotect the guard area with PROT_NONE if required. Although it works as expected, it pessimizes the allocation because it requires the kernel to actually increase commit charge (it counts against the available physical/swap memory available for the system). The only issue is to actually check this change since side-effects are really Linux specific and to actually account them it would require a kernel specific tests to parse the system wide information. On the kernel I checked /proc/self/statm does not show any meaningful difference for vmm and/or rss before and after thread creation. I could only see really meaningful information checking on system wide /proc/meminfo between thread creation: MemFree, MemAvailable, and Committed_AS shows large difference without the patch. I think trying to use these kind of information on a testcase is fragile. The BZ#18988 reports shows that the commit pages are easily seen with mlockall (MCL_FUTURE) (with lock all pages that become mapped in the process) however a more straighfoward testcase shows that pthread_create could be faster using this patch: -- static const int inner_count = 256; static const int outer_count = 128; static void *thread1(void *arg) { return NULL; } static void *sleeper(void *arg) { pthread_t ts[inner_count]; for (int i = 0; i < inner_count; i++) pthread_create (&ts[i], &a, thread1, NULL); for (int i = 0; i < inner_count; i++) pthread_join (ts[i], NULL); return NULL; } int main(void) { pthread_attr_init(&a); pthread_attr_setguardsize(&a, 1<<20); pthread_attr_setstacksize(&a, 1134592); pthread_t ts[outer_count]; for (int i = 0; i < outer_count; i++) pthread_create(&ts[i], &a, sleeper, NULL); for (int i = 0; i < outer_count; i++) pthread_join(ts[i], NULL); assert(r == 0); } return 0; } -- On x86_64 (4.4.0-45-generic, gcc 5.4.0) running the small benchtests I see: $ time ./test real 0m3.647s user 0m0.080s sys 0m11.836s While with the patch I see: $ time ./test real 0m0.696s user 0m0.040s sys 0m1.152s So I added a pthread_create benchtest (thread_create) which check the thread creation latency. As for the simple benchtests, I saw improvements in thread creation on all architectures I tested the change. Checked on x86_64-linux-gnu, i686-linux-gnu, aarch64-linux-gnu, arm-linux-gnueabihf, powerpc64le-linux-gnu, sparc64-linux-gnu, and sparcv9-linux-gnu. [BZ #18988] * benchtests/thread_create-inputs: New file. * benchtests/thread_create-source.c: Likewise. * support/xpthread_attr_setguardsize.c: Likewise. * support/Makefile (libsupport-routines): Add xpthread_attr_setguardsize object. * support/xthread.h: Add xpthread_attr_setguardsize prototype. * benchtests/Makefile (bench-pthread): Add thread_create. * nptl/allocatestack.c (allocate_stack): Call mmap with PROT_NONE and then mprotect the required area.
* support: Expose TEST_VERIFY_EXIT behavior to GCC optimizersFlorian Weimer2017-06-092-7/+15
| | | | | | | Previously, the implementation would conditionally exit based on the status argument, which GCC did not know about. This leads to false uninitialized variable warnings when data is accessed after a TEST_VERIFY_EXIT failure (from code which would never execute).
* resolv: Tests for various versions of res_initFlorian Weimer2017-06-0214-1/+445
|
* Add internal facility for dynamic array handlingFlorian Weimer2017-06-027-0/+400
| | | | | | This is intended as a type-safe alternative to obstacks and hand-written realloc constructs. The implementation avoids writing function pointers to the heap.
* support_format_addrinfo: Fix flags and canonname formattingFlorian Weimer2017-05-111-16/+53
| | | | | | | | | | The address family splitting via format_ai_family made unpredictable the place where the canonname field was printed. This commit adjusts the implementation so that the ai_flags is checked for consistency across the list, and ai_canonname must only be present on the first list element. Tests for AI_CANONNAME are added to resolv/tst-resolv-basic.
* support: Prevent multiple deletion of temporary filesFlorian Weimer2017-05-081-4/+14
| | | | | | Otherwise, another user might recreate these files after the first deletion. Particularly with temporary directories, this could result in the removal of unintended files through symbol link attacks.
* support: Delete temporary files in LIFO orderFlorian Weimer2017-05-081-11/+5
| | | | | | | | This is required to remove temporary directories which contain temporary files. Previously, FIFO order meant that directory removal was attempted when the directory still contained files, which meant that temporary directory cleanup was essentially unsupported.
* Fix sys/socket.h namespace issues from sys/uio.h inclusion (bug 21426).Joseph Myers2017-04-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sys/socket.h includes sys/uio.h to get the definition of the iovec structure. POSIX allows sys/socket.h to make all sys/uio.h symbols visible. However, all of sys/uio.h is XSI-shaded, so for non-XSI POSIX this results in conformtest failures (for sys/socket.h and other headers that include it): Namespace violation: "UIO_MAXIOV" Namespace violation: "readv" Namespace violation: "writev" Now, there is some ambiguity in POSIX about what namespace reservations apply in this case - see http://austingroupbugs.net/view.php?id=1127 - but glibc convention would still avoid declaring readv and writev, for example, for feature test macros that don't include them (if only headers from the relevant standard are included), even if such declarations are permitted, so there is a bug here according to glibc conventions. This patch moves the struct iovec definition to a new bits/types/struct_iovec.h header and includes that from sys/socket.h instead of including the whole of sys/uio.h. This fixes the namespace issue; however, three files in glibc that were relying on the implicit inclusion needed to be updated to include sys/uio.h explicitly. So there is a question of whether sys/socket.h should continue to include sys/uio.h under some conditions, such as __USE_XOPEN or __USE_MISC or __USE_XOPEN || __USE_MISC, for greater compatibility with code that (wrongly) expects this optional inclusion to be present there. (I think the three affected files in glibc should still have explicit sys/uio.h inclusions added in any case, however.) Tested for x86_64. [BZ #21426] * misc/bits/types/struct_iovec.h: New file. * misc/Makefile (headers): Add bits/types/struct_iovec.h. * include/bits/types/struct_iovec.h: New file. * bits/uio.h (struct iovec): Replace by inclusion of <bits/types/struct_iovec.h>. * sysdeps/unix/sysv/linux/bits/uio.h (struct iovec): Likewise. * socket/sys/socket.h: Include <bits/types/struct_iovec.h> instead of <sys/uio.h>. * nptl/tst-cancel4.c: Include <sys/uio.h> * posix/test-errno.c: Likewise. * support/resolv_test.c: Likewise. * conform/Makefile (test-xfail-POSIX2008/arpa/inet.h/conform): Remove. (test-xfail-POSIX2008/netdb.h/conform): Likewise. (test-xfail-POSIX2008/netinet/in.h/conform): Likewise. (test-xfail-POSIX2008/sys/socket.h/conform): Likewise.
* Assume that accept4 is always available and worksFlorian Weimer2017-04-193-0/+34
| | | | | | | | | | Simplify the Linux accept4 implementation based on the assumption that it is available in some way. __ASSUME_ACCEPT4_SOCKETCALL was previously unused, so remove it. For ia64, the accept4 system call (and socket call) were backported in kernel version 3.2.18. Reflect this in the installation instructions.
* resolv: Reduce EDNS payload size to 1200 bytes [BZ #21361]Florian Weimer2017-04-132-3/+64
| | | | This hardens the stub resolver against fragmentation-based attacks.
* Another round of inclusion fixes for _ISOMAC testsuite.Zack Weinberg2017-03-223-5/+10
| | | | | | | | | * stdio-common/bug25.c: Include stdlib.h. * support/tst-support_format_dns_packet.c: Include stdio.h, stdlib.h, and string.h. * support/tst-support_record_failure.c: Include string.h. * support/tst-support_record_failure-2.sh: Adjust line number expectations and correct a typo in an error message.
* support: Explain ignored failures of temporary file removal [BZ #21243]Florian Weimer2017-03-151-1/+4
|
* support: Add error checking to close system calls [BZ #21244]Florian Weimer2017-03-156-15/+50
|
* support_format_dns_packet: Fix CNAME and multiple RR handlingFlorian Weimer2017-03-153-7/+114
| | | | | | | | | | Before this change, the loop iterating over RRs in the answer section stopped at the first CNAME record, never printing them. The CNAME and PTR record contents was extracted from the wrong buffer (whole packet instead RDATA). This desynced the parsing after the first CNAME or PTR record. Also fix the AAAA record parsing by checking their sizes.
* Bug 20116: Fix use after free in pthread_create()Carlos O'Donell2017-01-286-0/+114
| | | | | | | | | | | | | | | | | | The commit documents the ownership rules around 'struct pthread' and when a thread can read or write to the descriptor. With those ownership rules in place it becomes obvious that pd->stopped_start should not be touched in several of the paths during thread startup, particularly so for detached threads. In the case of detached threads, between the time the thread is created by the OS kernel and the creating thread checks pd->stopped_start, the detached thread might have already exited and the memory for pd unmapped. As a regression test we add a simple test which exercises this exact case by quickly creating detached threads with large enough stacks to ensure the thread stack cache is bypassed and the stacks are unmapped. Before the fix the testcase segfaults, after the fix it works correctly and completes without issue. For a detailed discussion see: https://www.sourceware.org/ml/libc-alpha/2017-01/msg00505.html
* nptl: Add tst-robust-forkFlorian Weimer2017-01-2714-0/+317
|
* support: struct netent portability fix for support_format_netentFlorian Weimer2017-01-011-1/+3
|
* support: Use %td for pointer difference in xwriteFlorian Weimer2017-01-011-2/+2
|
* Update copyright dates with scripts/update-copyrights.Joseph Myers2017-01-0181-81/+81
|
* resolv: Add beginnings of a libresolv test suiteFlorian Weimer2016-12-3138-0/+2906
|
* support: Implement --verbose option for test programsFlorian Weimer2016-12-315-8/+22
| | | | | | Some tests can produce rather verbose tracing information, and the --verbose option provides a standardized way to enable such logging output.
* support: Use support_record_failure consistentlyFlorian Weimer2016-12-3111-32/+28
| | | | | | | | This causes more test programs to link in the support_record_failure function, which triggers an early call to mmap from an ELF constructor, but this should not have side effects intefering with the functionality actually under test (unlike, say, a call to malloc).
* support: Helper functions for entering namespacesFlorian Weimer2016-12-317-0/+268
|
* Fix tst-support_record_failure-2 for run-built-tests = no.Joseph Myers2016-12-301-0/+2
| | | | | | | | | | | | | | | The support/tst-support_record_failure-2.out test attempts to run built code even if run-built-tests = no, so failing with build-many-glibcs.py for all architectures whose code cannot be run on the system running the script. This patch disables the test in that case. Tested for x86_64 (native), and for aarch64 with build-many-glibcs.py. * support/Makefile (tests-special): Make definition conditional on [$(run-built-tests) = yes]. ($(objpfx)tst-support_record_failure-2.out): Make rule conditional on [$(run-built-tests) = yes].
* Add SYSV message queue testAdhemerval Zanella2016-12-281-0/+5
| | | | | | | | | | This patch adds a simple SYSV message queue test to check for correct argument passing on kernel. The idea is neither to be an extensive testing nor to check for any specific Linux test. * sysvipc/Makefile (tests): Add test-sysvmsg. * sysvipc/test-sysvmsg.c: New file. * test-skeleton.c (FAIL_UNSUPPORTED): New define.
* support: Add support for delayed test failure reportingFlorian Weimer2016-12-2810-7/+530
| | | | | | The new functions support_record_failure records a test failure, but does not terminate the process. The macros TEST_VERIFY and TEST_VERIFY_EXIT check that a condition is true.
* Fix assertion failure on test timeoutAndreas Schwab2016-12-151-1/+1
|
* Fix testsuite timeout handlingAndreas Schwab2016-12-101-1/+1
|
* support: Introduce new subdirectory for test infrastructureFlorian Weimer2016-12-0937-0/+1898
The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-06 16:57:29 +0000