about summary refs log tree commit diff
path: root/nptl/sysdeps
Commit message (Collapse)AuthorAgeFilesLines
* Fix typos.Ondřej Bílka2013-08-211-1/+1
|
* Clean up whitespace in lock elision patches.Dominik Vogt2013-07-1912-28/+34
| | | | Signed-off-by: Carlos O'Donell <carlos@redhat.com>
* Remove remains of rwlock elision which is not implemented yet.Dominik Vogt2013-07-192-11/+0
| | | | | | | | | | | | | | | Signed-off-by: Carlos O'Donell <carlos@redhat.com> --- nptl/ 2013-07-19 Dominik Vogt <vogt@de.ibm.com> * sysdeps/unix/sysv/linux/x86/elision-conf.c: Remove __rwlock_rtm_enabled and __rwlock_rtm_read_retries. (elision_init): Don't set __rwlock_rtm_enabled. * sysdeps/unix/sysv/linux/x86/elision-conf.h: Remove __rwlock_rtm_enabled.
* Add x86 init-arch to nptlH.J. Lu2013-07-032-0/+2
|
* Add a configure option to enable lock elision and disable by defaultAndi Kleen2013-07-021-0/+3
| | | | Can be enabled with --enable-lock-elision=yes at configure time.
* Add elision to pthread_mutex_{try,timed,un}lockAndi Kleen2013-07-028-5/+134
| | | | | | | | | | | | | | | | | | | | | | | Add elision paths to the basic mutex locks. The normal path has a check for RTM and upgrades the lock to RTM when available. Trylocks cannot automatically upgrade, so they check for elision every time. We use a 4 byte value in the mutex to store the lock elision adaptation state. This is separate from the adaptive spin state and uses a separate field. Condition variables currently do not support elision. Recursive mutexes and condition variables may be supported at some point, but are not in the current implementation. Also "trylock" will not automatically enable elision unless some other lock call has been already called on the lock. This version does not use IFUNC, so it means every lock has one additional check for elision. Benchmarking showed the overhead to be negligible.
* Add new internal mutex type flags for elision.Andi Kleen2013-07-021-8/+20
| | | | | | | | | | Add Enable/disable flags used internally Extend the mutex initializers to have the fields needed for elision. The layout stays the same, and this is not visible to programs. These changes are not exposed outside pthread
* Add the low level infrastructure for pthreads lock elision with TSXAndi Kleen2013-07-0210-0/+480
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lock elision using TSX is a technique to optimize lock scaling It allows to run locks in parallel using hardware support for a transactional execution mode in 4th generation Intel Core CPUs. See http://www.intel.com/software/tsx for more Information. This patch implements a simple adaptive lock elision algorithm based on RTM. It enables elision for the pthread mutexes and rwlocks. The algorithm keeps track whether a mutex successfully elides or not, and stops eliding for some time when it is not. When the CPU supports RTM the elision path is automatically tried, otherwise any elision is disabled. The adaptation algorithm and its tuning is currently preliminary. The code adds some checks to the lock fast paths. Micro-benchmarks show little to no difference without RTM. This patch implements the low level "lll_" code for lock elision. Followon patches hook this into the pthread implementation Changes with the RTM mutexes: ----------------------------- Lock elision in pthreads is generally compatible with existing programs. There are some obscure exceptions, which are expected to be uncommon. See the manual for more details. - A broken program that unlocks a free lock will crash. There are ways around this with some tradeoffs (more code in hot paths) I'm still undecided on what approach to take here; have to wait for testing reports. - pthread_mutex_destroy of a lock mutex will not return EBUSY but 0. - There's also a similar situation with trylock outside the mutex, "knowing" that the mutex must be held due to some other condition. In this case an assert failure cannot be recovered. This situation is usually an existing bug in the program. - Same applies to the rwlocks. Some of the return values changes (for example there is no EDEADLK for an elided lock, unless it aborts. However when elided it will also never deadlock of course) - Timing changes, so broken programs that make assumptions about specific timing may expose already existing latent problems. Note that these broken programs will break in other situations too (loaded system, new faster hardware, compiler optimizations etc.) - Programs with non recursive mutexes that take them recursively in a thread and which would always deadlock without elision may not always see a deadlock. The deadlock will only happen on an early or delayed abort (which typically happens at some point) This only happens for mutexes not explicitely set to PTHREAD_MUTEX_NORMAL or PTHREAD_MUTEX_ADAPTIVE_NP. PTHREAD_MUTEX_NORMAL mutexes do not elide. The elision default can be set at configure time. This patch implements the basic infrastructure for elision.
* PowerPC: Reserve TCB space for EBB frameworkAdhemerval Zanella2013-06-171-0/+5
| | | | | This patch reserves four pointer to be used in future Event-Based Branch framework for PowerPC.
* New API to set default thread attributesSiddhesh Poyarekar2013-06-151-0/+8
| | | | | | | This patch introduces two new convenience functions to set the default thread attributes used for creating threads. This allows a programmer to set the default thread attributes just once in a process and then run pthread_create without additional attributes.
* Avoid access beyond memory bounds in pthread_attr_getaffinity_npSiddhesh Poyarekar2013-06-141-1/+6
| | | | | | | | | Resolves BZ #15618. pthread_attr_getaffinity_np may write beyond bounds of the input cpuset buffer if the size of the input buffer is smaller than the buffer present in the input pthread attributes. Fix is to copy to the extent of the minimum of the source and the destination.
* x86*: Return syscall error for lll_futex_wake.Carlos O'Donell2013-06-102-8/+10
| | | | | | | | | | | | | | | | | | | | | | It is very very possible that the futex syscall returns an error and that the caller of lll_futex_wake may want to look at that error and propagate the failure. This patch allows a caller to see the syscall error. There are no users of the syscall error at present, but future cleanups are now be able to check for the error. -- nplt/ 2013-06-10 Carlos O'Donell <carlos@redhat.com> * sysdeps/unix/sysv/linux/i386/lowlevellock.h (lll_futex_wake): Return syscall error. * sysdeps/unix/sysv/linux/x86_64/lowlevellock.h (lll_futex_wake): Return syscall error.
* Fix previous commit.Ondrej Bilka2013-06-081-2/+2
|
* Silence warning: __inline is not at beginning of declaration.Ondrej Bilka2013-06-081-1/+1
|
* Remove trailing whitespace in nptl.Joseph Myers2013-06-0612-46/+46
|
* Add #include <stdint.h> for uint[32|64]_t usage (except installed headers).Ryan S. Arnold2013-05-161-0/+1
|
* Reserve new TLS field for x86 and x86_64Andreas Jaeger2013-05-152-2/+6
| | | | | | | [BZ #10686] * sysdeps/x86_64/tls.h (struct tcbhead_t): Add __private_ss field. * sysdeps/i386/tls.h (struct tcbhead_t): Likewise.
* Consolidate pthread_attr value validationSiddhesh Poyarekar2013-04-221-17/+3
| | | | | Define inline functions that wrap around validation for each of the pthread attributes to reduce duplication in code.
* Extend i486 pthread_cond_timedwait to use futex syscall with absolute timeoutAndreas Schwab2013-04-111-66/+315
|
* sem_post.c: Include atomic.h.Carlos O'Donell2013-04-071-0/+1
| | | | | | | | | | | | | | The sem_post.c file uses atomic functions without including atomic.h. Add `#include <atomic.h>' to the file to prevent any compile time warnings when other headers change and atomic.h isn't implicitly included. --- nptl/ 2013-04-07 Carlos O'Donell <carlos@redhat.com> * sysdeps/unix/sysv/linux/sem_post.c: Include atomic.h.
* Fix static build when configured with --disable-hidden-pltSiddhesh Poyarekar2013-04-041-1/+1
| | | | | | | | | | | | | | | Fixes BZ #15337. Static builds fail with the following warning: /home/tools/glibc/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/x86_64/cancellation.S:80: undefined reference to `__GI___pthread_unwind' When the source is configured with --disable-hidden-plt. This is because the preprocessor conditional in cancellation.S only checks if the build is for SHARED, whereas hidden_def is defined appropriately only for a SHARED build that will have symbol versioning *and* hidden defs are enabled. The last case is false here.
* Include atomic.h in generic lowlevellock.c.Carlos O'Donell2013-03-121-1/+1
|
* Rejigger i386 dl-sysdep.h files.Roland McGrath2013-03-042-50/+31
|
* Add priority inheritance futex support on sparc.David S. Miller2013-02-211-0/+30
| | | | | | | | | * sysdeps/unix/sysv/linux/sparc/lowlevellock.h (FUTEX_WAIT_REQUEUE_PI): Define. (FUTEX_CMP_REQUEUE_PI): Likewise. (lll_futex_wait_requeue_pi): Likewise. (lll_futex_timed_wait_requeue_pi): Likewise. (lll_futex_cmp_requeue_pi): Likewise.
* nptl: Fix comment typo in fork.c.Carlos O'Donell2013-02-211-1/+1
|
* Fix build warnings in some test casesSiddhesh Poyarekar2013-02-181-0/+1
| | | | Include stdlib.h to get declaration of exit(3)
* FUTEX_*_REQUEUE_PI support for non-x86 codeSiddhesh Poyarekar2013-02-182-0/+58
| | | | | Add FUTEX_*_REQUEUE_PI support for the default C code and also add implementations for s-390 and ppc.
* Remove bp-sym.h and BP_SYM uses from C code.Joseph Myers2013-02-141-23/+22
|
* Revert "Extend i486 pthread_cond_timedwait to use futex syscall with ↵Andreas Schwab2013-01-101-315/+66
| | | | | | absolute timeout" This reverts commit 1bd57044e963abb886cb912beadea714815a3d5c.
* Extend i486 pthread_cond_timedwait to use futex syscall with absolute timeoutAndreas Schwab2013-01-101-66/+315
| | | | | | * sysdeps/unix/sysv/linux/i386/i486/pthread_cond_timedwait.S (__pthread_cond_timedwait): If possible use FUTEX_WAIT_BITSET to directly use absolute timeout.
* Update copyright notices with scripts/update-copyrights.Joseph Myers2013-01-02295-300/+295
|
* Add script to update copyright notices and reformat some to facilitate its use.Joseph Myers2013-01-011-1/+1
|
* Add sparc implementation of lll_futex_timed_wait_bitsetDavid S. Miller2012-12-271-0/+13
| | | | | | | nptl/ * sysdeps/unix/sysv/linux/sparc/lowlevellock.h (lll_futex_timed_wait_bitset): New macro.
* [s390] Replace lll_futex_* assembly code with INTERNAL_SYSCALLSiddhesh Poyarekar2012-12-271-74/+31
|
* Fix some build warnings on s390xSiddhesh Poyarekar2012-12-081-2/+2
|
* Remove unused variable from powerpc sem_post.c.Joseph Myers2012-12-041-2/+2
|
* Cast to __intptr_t before casting pointer to int64H.J. Lu2012-11-262-4/+6
|
* Remove unused variable from sem_post.c.Joseph Myers2012-11-211-1/+1
|
* [S390,PPC] Implement FUTEX_WAIT_BITSET for timedwait functionsSiddhesh Poyarekar2012-11-053-1/+48
| | | | | | | | | | | | | | Since the FUTEX_WAIT operation takes a relative timeout, the pthread_cond_timedwait and other timed function implementations have to get a relative timeout from the absolute timeout parameter it gets before it makes the futex syscall. This value is then converted back into an absolute timeout within the kernel. This is a waste and has hence been improved upon by a FUTEX_WAIT_BITSET operation (OR'd with FUTEX_CLOCK_REALTIME to make the kernel use the realtime clock instead of the default monotonic clock). This was implemented only in the x86 and sh assembly code and not in the C code. This patch implements support for FUTEX_WAIT_BITSET whenever available (since linux-2.6.29) for s390 and powerpc.
* Fix coding style in sparc lowlevellock.hDavid S. Miller2012-11-031-2/+2
| | | | | | | | nptl/ * sysdeps/unix/sysv/linux/sparc/lowlevellock.h (BUSY_WAIT_NOP): Add missing spaces. (__cpu_relax): Likewise.
* Compile x86 rtld with -mno-sse -mno-mmxH.J. Lu2012-11-021-2/+9
|
* Define a BUSY_WAIT_NOP for sparc.David S. Miller2012-10-285-0/+76
| | | | | | | | | | | | | | nptl/ * sysdeps/unix/sysv/linux/sparc/lowlevellock.h (BUSY_WAIT_NOP): Define when we have v9 instructions available. * sysdeps/unix/sysv/linux/sparc/sparc64/cpu_relax.S: New file. * sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9/cpu_relax.S: New file. * sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9/Makefile: New file. * sysdeps/unix/sysv/linux/sparc/sparc64/Makefile: Add cpu_relax to libpthread-routines.
* Adjust mutex lock in condvar_cleanup if we got it from requeue_piSiddhesh Poyarekar2012-10-164-4/+17
| | | | This completes the fix to bz #14652.
* Fix formatting in nptl/sysdeps/pthread/pthread.h.Carlos O'Donell2012-10-101-2/+2
| | | | | | | | The macro pthread_cleanup_push_defer_np in pthread.h has a misaligned line continuation marker. This marker was previously aligned, but recent changes have moved it out of alignment. This change realigns the marker. This also reduces the diff against the hppa version of pthread.h where the marker is aligned.
* Take lock in pthread_cond_wait cleanup handler only when neededSiddhesh Poyarekar2012-10-105-8/+65
| | | | | | | | | | [BZ #14652] When a thread waiting in pthread_cond_wait with a PI mutex is cancelled after it has returned successfully from the futex syscall but just before async cancellation is disabled, it enters its cancellation handler with the mutex held and simply calling a mutex_lock again will result in a deadlock. Hence, it is necessary to see if the thread owns the lock and try to lock it only if it doesn't.
* Add missing magic to GLIBC_PROVIDES.Roland McGrath2012-10-092-202/+0
|
* Correct libthreadb register access for 64-bit sparc.David S. Miller2012-10-051-2/+2
| | | | | | | [BZ #14568] * sysdeps/sparc/tls.h (DB_THREAD_SELF_INCLUDE): Delete. (DB_THREAD_SELF): Use constants for the register offsets. Correct the case of a 64-bit debugger with a 32-bit inferior.
* Unlock mutex before going back to waiting for PI mutexesSiddhesh Poyarekar2012-10-054-171/+156
| | | | | | | | | | [BZ #14417] A futex call with FUTEX_WAIT_REQUEUE_PI returns with the mutex locked on success. If such a successful thread is pipped to the cond_lock by another spuriously woken waiter, it could be sent back to wait on the futex with the mutex lock held, thus causing a deadlock. So it is necessary that the thread relinquishes the mutex before going back to sleep.
* Update copyright yearsH.J. Lu2012-10-021-1/+1
|
* Fix clone flag name in comment to CLONE_CHILD_CLEARTID.Siddhesh Poyarekar2012-10-026-6/+6
|
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-08-22 22:17:05 +0000