about summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* nptl: Move call_once into libcFlorian Weimer2021-05-0366-69/+88
| | | | | | | | | | | | | | | The symbol was moved using scripts/move-symbol-to-libc.py. This change also turns __pthread_once into a compatibility symbol because after the call_once move, an internal call to __pthread_once can be used. This an adjustment to __libc_once: Outside libc (e.g., in nscd), it has to call pthread_once. With __pthread_once as a compatibility symbol, it is no longer to add a new GLIBC_2.34 version after the move from libpthread, and this commit removes the new __pthread_once@@GLIBC_2.34 version. Reviewed-by: Carlos O'Donell <carlos@redhat.com> Tested-by: Carlos O'Donell <carlos@redhat.com>
* Add pthread-in-libc, libpthread-routines-var, librt-routines-varFlorian Weimer2021-05-039-0/+40
| | | | | | | | These make variables can be used to add routines to different libraries for the Hurd and Linux builds. Reviewed-by: Carlos O'Donell <carlos@redhat.com> Tested-by: Carlos O'Donell <carlos@redhat.com>
* powerpc64le: Optimize memset for POWER10Raoni Fassina Firmino2021-04-306-1/+314
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This implementation is based on __memset_power8 and integrates a lot of suggestions from Anton Blanchard. The biggest difference is that it makes extensive use of stxvl to alignment and tail code to avoid branches and small stores. It has three main execution paths: a) "Short lengths" for lengths up to 64 bytes, avoiding as many branches as possible. b) "General case" for larger lengths, it has an alignment section using stxvl to avoid branches, a 128 bytes loop and then a tail code, again using stxvl with few branches. c) "Zeroing cache blocks" for lengths from 256 bytes upwards and set value being zero. It is mostly the __memset_power8 code but the alignment phase was simplified because, at this point, address is already 16-bytes aligned and also changed to use vector stores. The tail code was also simplified to reuse the general case tail. All unaligned stores use stxvl instructions that do not generate alignment interrupts on POWER10, making it safe to use on caching-inhibited memory. On average, this implementation provides something around 30% improvement when compared to __memset_power8. Reviewed-by: Matheus Castanho <msc@linux.ibm.com> Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
* powerpc64le: Optimize memcpy for POWER10Tulio Magno Quites Machado Filho2021-04-305-1/+238
| | | | | | | | | | | | | | | | | | This implementation is based on __memcpy_power8_cached and integrates suggestions from Anton Blanchard. It benefits from loads and stores with length for short lengths and for tail code, simplifying the code. All unaligned memory accesses use instructions that do not generate alignment interrupts on POWER10, making it safe to use on caching-inhibited memory. The main loop has also been modified in order to increase instruction throughput by reducing the dependency on updates from previous iterations. On average, this implementation provides around 30% improvement when compared to __memcpy_power7 and 10% improvement in comparison to __memcpy_power8_cached.
* powerpc64le: Optimized memmove for POWER10Lucas A. M. Magalhaes2021-04-308-7/+388
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch was initially based on the __memmove_power7 with some ideas from strncpy implementation for Power 9. Improvements from __memmove_power7: 1. Use lxvl/stxvl for alignment code. The code for Power 7 uses branches when the input is not naturally aligned to the width of a vector. The new implementation uses lxvl/stxvl instead which reduces pressure on GPRs. It also allows the removal of branch instructions, implicitly removing branch stalls and mispredictions. 2. Use of lxv/stxv and lxvl/stxvl pair is safe to use on Cache Inhibited memory. On Power 10 vector load and stores are safe to use on CI memory for addresses unaligned to 16B. This code takes advantage of this to do unaligned loads. The unaligned loads don't have a significant performance impact by themselves. However doing so decreases register pressure on GPRs and interdependence stalls on load/store pairs. This also improved readability as there are now less code paths for different alignments. Finally this reduces the overall code size. 3. Improved performance. This version runs on average about 30% better than memmove_power7 for lengths larger than 8KB. For input lengths shorter than 8KB the improvement is smaller, it has on average about 17% better performance. This version has a degradation of about 50% for input lengths in the 0 to 31 bytes range when dest is unaligned. Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
* Update kernel version to 5.12 in tst-mman-consts.py.Joseph Myers2021-04-291-1/+1
| | | | | | | | This patch updates the kernel version in the test tst-mman-consts.py to 5.12. (There are no new MAP_* constants covered by this test in 5.12 that need any other header changes.) Tested with build-many-glibcs.py.
* Update syscall lists for Linux 5.12.Joseph Myers2021-04-2826-2/+28
| | | | | | | | Linux 5.12 has one new syscall, mount_setattr. Update syscall-names.list and regenerate the arch-syscall.h headers with build-many-glibcs.py update-syscalls. Tested with build-many-glibcs.py.
* regenerate ulps on x86_64 with -march=nativePaul Zimmermann2021-04-281-3/+3
| | | | | | | On x86_64, when configuring glibc with CFLAGS="-O2 -g -march=native", some tests fail. After this patch, "make check" succeeds. Tested on Intel Core i5-4590 with gcc 10.2.1.
* Pass a valid pointer to pthread_setspecific to avoid GCC 11 warning.Martin Sebor2021-04-278-18/+30
|
* Add __attribute_access_none to disable GCC warnings [BZ #27714]Martin Sebor2021-04-275-3/+54
| | | | | | | | | | | | | | | | GCC 11 warns when a pointer to an uninitialized object is passed to a function that takes a const-qualified argument. This is done on the assumption that most such functions read from the object. For the rare case of a function that doesn't, GCC 11 extends attribute access to add a new mode called none. POSIX pthread_setspecific() is one such rare function that takes a const void* argument but that doesn't read from the object it points to. To suppress the -Wmaybe-uninitialized issued by GCC 11 when the address of an uninitialized object is passed to it (e.g., the result of malloc()), this change #defines __attr_access_none in cdefs.h and uses the macro on the function in sysdeps/htl/pthread.h and sysdeps/nptl/pthread.h.
* Use Linux 5.12 and GCC 11 branch in build-many-glibcs.py.Joseph Myers2021-04-271-2/+2
| | | | | | | | This patch makes build-many-glibcs.py use Linux 5.12 and GCC 11 branch. Tested with build-many-glibcs.py (host-libraries, compilers and glibcs builds).
* powerpc: Add log IFUNC multiarch support for POWER10Raphael Moreira Zinsly2021-04-268-0/+104
| | | | | | | Checked on ppc64le built without --with-cpu, with --with-cpu=power9 and with --disable-multi-arch. Reviewed-by: Matheus Castanho <msc@linux.ibm.com>
* LC_COLLATE: Fix last character ellipsis handling (Bug 22668)Hanataka Shinya2021-04-261-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During ellipsis processing the collation cursor was not correctly moved to the end of the ellipsis after processing. The code inserted the new entry after the cursor, but before the real end of the ellipsis: [cursor] ... element_t <-> element_t <-> element_t <-> element_t "<U0000>" "<U0001>" "<U007F>" startp endp At the end of the function we have: [cursor] ... element_t <-> element_t <-> element_t "<U007E>" "<U007F>" endp The cursor should be pointing at endp, the last element in the doubly-linked list, otherwise when execution returns to the caller we will start inserting the next line after <U007E>. Subsequent operations end up unlinking the ellipsis end entry or just leaving it in the list dangling from the end. This kind of dangling is immediately visible in C.UTF-8 with the following sorting from strcoll: <U0010FFFF> <U0000FFFF> <U000007FF> <U0000007F> With the cursor correctly adjusted the end entry is correctly given the right location and thus the right weight. Retested and no regressions on x86_64 and i686. Co-authored-by: Carlos O'Donell <carlos@redhat.com>
* x86: Optimize strchr-evex.SNoah Goldstein2021-04-251-174/+218
| | | | | | | | | | No bug. This commit optimizes strchr-evex.S. The optimizations are mostly small things such as save an ALU in the alignment process, saving a few instructions in the loop return. The one significant change is saving 2 instructions in the 4x loop. test-strchr, test-strchrnul, test-wcschr, and test-wcschrnul are all passing. Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
* x86: Optimize strchr-avx2.SNoah Goldstein2021-04-251-117/+169
| | | | | | | | | | No bug. This commit optimizes strchr-avx2.S. The optimizations are all small things such as save an ALU in the alignment process, saving a few instructions in the loop return, saving some bytes in the main loop, and increasing the ILP in the return cases. test-strchr, test-strchrnul, test-wcschr, and test-wcschrnul are all passing. Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
* nptl: Remove __h_errno_location from libpthreadFlorian Weimer2021-04-2332-65/+0
| | | | | | | The existing definition in libc will be used instead. The symbol was moved (that is, removed) using scripts/move-symbol-to-libc.py.
* nptl: Remove __res_state from libpthreadFlorian Weimer2021-04-2332-57/+0
| | | | | | | The existing definition in libc will be used instead. The symbol was moved (that is, removed) using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_spin_trylock into libcFlorian Weimer2021-04-2372-52/+158
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_spin_lock into libcFlorian Weimer2021-04-2372-47/+139
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_spin_init, Move pthread_spin_unlock into libcFlorian Weimer2021-04-2373-89/+233
| | | | | | | For some architectures, the two functions are aliased, so these symbols need to be moved at the same time. The symbols were moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_spin_destroy into libcFlorian Weimer2021-04-2364-33/+76
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_condattr_setpshared into libcFlorian Weimer2021-04-2364-32/+76
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_condattr_setclock into libcFlorian Weimer2021-04-2364-32/+75
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_condattr_getpshared into libcFlorian Weimer2021-04-2364-33/+76
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_condattr_getclock into libcFlorian Weimer2021-04-2364-33/+77
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_settype, __pthread_mutexattr_settype into libcFlorian Weimer2021-04-2365-97/+187
| | | | | | | | | And pthread_mutexattr_setkind_np as a compatibility symbol. __pthread_mutexattr_settype is used in mtx_init from libpthread, so this commit adds a GLIBC_2.34 symbol version for it. The symbols were moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_setrobust into libcFlorian Weimer2021-04-2367-68/+149
| | | | | | And pthread_mutexattr_getrobust_np as a compat symbol. The symbols were moved using scripts/move-symbol-to-libc.py.
* pthread: Use pthread_mutexattr_setrobust in testsFlorian Weimer2021-04-235-6/+6
| | | | pthread_mutexattr_setrobust_np is about to be deprecated.
* nptl: Move pthread_mutexattr_setpshared into libcFlorian Weimer2021-04-2364-33/+76
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_setprotocol into libcFlorian Weimer2021-04-2364-33/+76
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_setprioceiling into libcFlorian Weimer2021-04-2364-33/+76
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_init, __pthread_mutexattr_init into libcFlorian Weimer2021-04-2365-66/+146
| | | | | | | __pthread_mutexattr_init cannot be be made a compat symbol because it is used in mtx_init, which is still in libpthread. The symbols were moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_gettype into libcFlorian Weimer2021-04-2364-64/+114
| | | | | | | | And pthread_mutexattr_getkind_np as a compatibility symbol. (There is no declaration in <pthread.h>, so there is no need to add an alias or a deprecation warning there.) The symbols were moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_getrobust into libcFlorian Weimer2021-04-2366-67/+128
| | | | | | And pthread_mutexattr_getrobust_np as a compat symbol. The symbols were moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_getpshared into libcFlorian Weimer2021-04-2364-33/+75
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_getprotocol into libcFlorian Weimer2021-04-2364-33/+76
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_getprioceiling into libcFlorian Weimer2021-04-2364-34/+77
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutexattr_destroy into libcFlorian Weimer2021-04-2364-64/+110
| | | | | | | And __pthread_mutexattr_destroy as a compat symbol (so no GLIBC_2.34 symbol version is added for it). The symbols were moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutex_trylock, __pthread_mutex_trylock into libcFlorian Weimer2021-04-2365-69/+143
| | | | | | | | The symbols were moved using scripts/move-symbol-to-libc.py. __pthread_mutex_trylock is used to implement mtx_timedlock, which still resides in libpthread, so add a GLIBC_2.34 version for it, to match the existing GLIBC_2.0 version.
* nptl: Move pthread_mutex_timedlock, pthread_mutex_clocklock to libcFlorian Weimer2021-04-2365-78/+181
| | | | | | | The symbols were moved using scripts/move-symbol-to-libc.py. The symbol aliasing follows pthread_cond_timedwait et al. Missing hidden prototypes had to be added to nptl/pthreadP.h for consistency.
* nptl: Move pthread_mutex_setprioceiling into libcFlorian Weimer2021-04-2364-34/+77
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* nptl: Move pthread_mutex_getprioceiling into libcFlorian Weimer2021-04-2364-33/+76
| | | | The symbol was moved using scripts/move-symbol-to-libc.py.
* powerpc: Add optimized strlen for POWER10Matheus Castanho2021-04-225-1/+230
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improvements compared to POWER9 version: 1. Take into account first 16B comparison for aligned strings The previous version compares the first 16B and increments r4 by the number of bytes until the address is 16B-aligned, then starts doing aligned loads at that address. For aligned strings, this causes the first 16B to be compared twice, because the increment is 0. Here we calculate the next 16B-aligned address differently, which avoids that issue. 2. Use simple comparisons for the first ~192 bytes The main loop is good for big strings, but comparing 16B each time is better for smaller strings. So after aligning the address to 16 Bytes, we check more 176B in 16B chunks. There may be some overlaps with the main loop for unaligned strings, but we avoid using the more aggressive strategy too soon, and also allow the loop to start at a 64B-aligned address. This greatly benefits smaller strings and avoids overlapping checks if the string is already aligned at a 64B boundary. 3. Reduce dependencies between load blocks caused by address calculation on loop Doing a precise time tracing on the code showed many loads in the loop were stalled waiting for updates to r4 from previous code blocks. This implementation avoids that as much as possible by using 2 registers (r4 and r5) to hold addresses to be used by different parts of the code. Also, the previous code aligned the address to 16B, then to 64B by doing a few 48B loops (if needed) until the address was aligned. The main loop could not start until that 48B loop had finished and r4 was updated with the current address. Here we calculate the address used by the loop very early, so it can start sooner. The main loop now uses 2 pointers 128B apart to make pointer updates less frequent, and also unrolls 1 iteration to guarantee there is enough time between iterations to update the pointers, reducing stalled cycles. 4. Use new P10 instructions lxvp is used to load 32B with a single instruction, reducing contention in the load queue. vextractbm allows simplifying the tail code for the loop, replacing vbpermq and avoiding having to generate a permute control vector. Reviewed-by: Paul E Murphy <murphyp@linux.ibm.com> Reviewed-by: Raphael M Zinsly <rzinsly@linux.ibm.com> Reviewed-by: Lucas A. M. Magalhaes <lamm@linux.ibm.com>
* nptl: Do not build nptl/tst-pthread-gdb-attach as PIEFlorian Weimer2021-04-221-0/+3
|
* nptl: Move pthread_kill_other_threads_np compatibility symbol into libcFlorian Weimer2021-04-2264-33/+35
| | | | And stop including the function for new architectures.
* x86: tst-cpu-features-supports.c: Update AMX checkH.J. Lu2021-04-221-3/+3
| | | | | Pass "amx-bf16", "amx-int8" and "amx-tile", instead of "amx_bf16", "amx_int8" and "amx_tile", to __builtin_cpu_supports for GCC 11.
* nptl: Move pthread_atfork compatibility symbol to libcFlorian Weimer2021-04-2236-19/+21
| | | | | | | The symbol was moved using scripts/move-symbol-to-libc.py. There is no new symbol version because of the compatibility symbol status. The __pthread_atfork reference in nptl/Versions was unused.
* nptl: Check for compatible GDB in nptl/tst-pthread-gdb-attachFlorian Weimer2021-04-221-2/+76
| | | | | Also do not clear the subprocess environment, in case running GDB needs certain environment variables.
* nptl: __nptl_set_robust_list_avail must be nocommonFlorian Weimer2021-04-221-1/+1
| | | | | | | This is required for GCC versions before 10 which default to -fcommon. Fixes commit 442e8a40da9dfa24aeebf4f1a163f0a58b12cf7e ("nptl: Move part of TCB initialization from libpthread to __tls_init_tp").
* nptl: Remove remnants of the libc/libpthread forwarder interfaceFlorian Weimer2021-04-217-147/+10
| | | | | | All previously forwarded functions are now implemented in libc. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>