diff options
Diffstat (limited to 'nptl')
-rw-r--r-- | nptl/Makefile | 13 | ||||
-rw-r--r-- | nptl/Versions | 2 | ||||
-rw-r--r-- | nptl/forward.c | 16 | ||||
-rw-r--r-- | nptl/nptl-init.c | 1 | ||||
-rw-r--r-- | nptl/pthreadP.h | 1 | ||||
-rw-r--r-- | nptl/pthread_exit.c | 9 | ||||
-rw-r--r-- | nptl/tst-pthread_exit-nothreads-static.c | 19 | ||||
-rw-r--r-- | nptl/tst-pthread_exit-nothreads.c | 28 |
8 files changed, 65 insertions, 24 deletions
diff --git a/nptl/Makefile b/nptl/Makefile index 60fa98140d..f96d905b0b 100644 --- a/nptl/Makefile +++ b/nptl/Makefile @@ -74,6 +74,7 @@ routines = \ pthread_condattr_destroy \ pthread_condattr_init \ pthread_equal \ + pthread_exit \ pthread_getaffinity \ pthread_getattr_np \ pthread_getschedparam \ @@ -134,7 +135,6 @@ libpthread-routines = \ pthread_condattr_setpshared \ pthread_create \ pthread_detach \ - pthread_exit \ pthread_getattr_default_np \ pthread_getconcurrency \ pthread_getcpuclockid \ @@ -313,7 +313,13 @@ tests = tst-attr2 tst-attr3 tst-default-attr \ tst-pthread-defaultattr-free \ tst-pthread-attr-sigmask \ tst-pthread-timedlock-lockloop \ - tst-pthread-gdb-attach tst-pthread-gdb-attach-static + tst-pthread-gdb-attach tst-pthread-gdb-attach-static \ + tst-pthread_exit-nothreads \ + tst-pthread_exit-nothreads-static \ + +tests-nolibpthread = \ + tst-pthread_exit-nothreads \ + tst-pthread_exit-nothreads-static \ tests-container = tst-pthread-getattr @@ -452,7 +458,8 @@ tests-static += tst-stackguard1-static \ tst-cancel24-static \ tst-mutex8-static tst-mutexpi8-static tst-sem11-static \ tst-sem12-static tst-cond11-static \ - tst-pthread-gdb-attach-static + tst-pthread-gdb-attach-static \ + tst-pthread_exit-nothreads-static tests += tst-cancel24-static diff --git a/nptl/Versions b/nptl/Versions index 2fc5cc17ef..f563e3b6cf 100644 --- a/nptl/Versions +++ b/nptl/Versions @@ -118,6 +118,7 @@ libc { __pthread_cleanup_upto; __pthread_cond_destroy; # Used by the C11 threads. __pthread_cond_init; # Used by the C11 threads. + __pthread_exit; __pthread_force_elision; __pthread_getattr_default_np; __pthread_keys; @@ -157,7 +158,6 @@ libpthread { pthread_cond_wait; pthread_create; pthread_detach; - pthread_exit; pthread_getspecific; pthread_join; pthread_key_create; diff --git a/nptl/forward.c b/nptl/forward.c index 7a7f54f9d9..a4a377ba6a 100644 --- a/nptl/forward.c +++ b/nptl/forward.c @@ -41,17 +41,6 @@ name decl \ return PTHFCT_CALL (ptr_##name, params); \ } -/* Same as FORWARD2, only without return. */ -#define FORWARD_NORETURN(name, rettype, decl, params, defaction) \ -rettype \ -name decl \ -{ \ - if (!__libc_pthread_functions_init) \ - defaction; \ - \ - PTHFCT_CALL (ptr_##name, params); \ -} - #define FORWARD(name, decl, params, defretval) \ FORWARD2 (name, int, decl, params, return defretval) @@ -103,11 +92,6 @@ versioned_symbol (libc, __pthread_cond_timedwait, pthread_cond_timedwait, GLIBC_2_3_2); -FORWARD_NORETURN (__pthread_exit, void, (void *retval), (retval), - exit (EXIT_SUCCESS)) -strong_alias (__pthread_exit, pthread_exit); - - FORWARD (pthread_mutex_destroy, (pthread_mutex_t *mutex), (mutex), 0) FORWARD (pthread_mutex_init, diff --git a/nptl/nptl-init.c b/nptl/nptl-init.c index 701876dd5d..761294929c 100644 --- a/nptl/nptl-init.c +++ b/nptl/nptl-init.c @@ -80,7 +80,6 @@ static const struct pthread_functions pthread_functions = .ptr___pthread_cond_wait_2_0 = __pthread_cond_wait_2_0, .ptr___pthread_cond_timedwait_2_0 = __pthread_cond_timedwait_2_0, # endif - .ptr___pthread_exit = __pthread_exit, .ptr_pthread_mutex_destroy = __pthread_mutex_destroy, .ptr_pthread_mutex_init = __pthread_mutex_init, .ptr_pthread_mutex_lock = __pthread_mutex_lock, diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h index b47c4c5be1..b99aae2bfe 100644 --- a/nptl/pthreadP.h +++ b/nptl/pthreadP.h @@ -535,6 +535,7 @@ extern int __pthread_detach (pthread_t th); extern int __pthread_cancel (pthread_t th); extern int __pthread_kill (pthread_t threadid, int signo); extern void __pthread_exit (void *value) __attribute__ ((__noreturn__)); +libc_hidden_proto (__pthread_exit) extern int __pthread_join (pthread_t threadid, void **thread_return); extern int __pthread_setcanceltype (int type, int *oldtype); extern int __pthread_enable_asynccancel (void) attribute_hidden; diff --git a/nptl/pthread_exit.c b/nptl/pthread_exit.c index aed8c12e17..6abf66463e 100644 --- a/nptl/pthread_exit.c +++ b/nptl/pthread_exit.c @@ -36,8 +36,11 @@ __pthread_exit (void *value) __do_cancel (); } +libc_hidden_def (__pthread_exit) weak_alias (__pthread_exit, pthread_exit) -/* After a thread terminates, __libc_start_main decrements - __nptl_nthreads defined in pthread_create.c. */ -PTHREAD_STATIC_FN_REQUIRE (__pthread_create) +/* Ensure that the unwinder is always linked in (the __pthread_unwind + reference from __do_cancel is weak). Use ___pthread_unwind_next + (three underscores) to produce a strong reference to the same + file. */ +PTHREAD_STATIC_FN_REQUIRE (___pthread_unwind_next) diff --git a/nptl/tst-pthread_exit-nothreads-static.c b/nptl/tst-pthread_exit-nothreads-static.c new file mode 100644 index 0000000000..e8cf19b1a4 --- /dev/null +++ b/nptl/tst-pthread_exit-nothreads-static.c @@ -0,0 +1,19 @@ +/* Check that pthread_exit works if there are no threads. Static version. + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <https://www.gnu.org/licenses/>. */ + +#include "tst-pthread_exit-nothreads.c" diff --git a/nptl/tst-pthread_exit-nothreads.c b/nptl/tst-pthread_exit-nothreads.c new file mode 100644 index 0000000000..d47455c75c --- /dev/null +++ b/nptl/tst-pthread_exit-nothreads.c @@ -0,0 +1,28 @@ +/* Check that pthread_exit works if there are no threads. + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <https://www.gnu.org/licenses/>. */ + +#include <pthread.h> + +static int +do_test (void) +{ + pthread_exit (NULL); + return 1; /* Not reached. */ +} + +#include <support/test-driver.c> |