about summary refs log tree commit diff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog2
-rw-r--r--Makefile2
2 files changed, 3 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 68254a9a3d..1ec13ba982 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 2015-05-19  Siddhesh Poyarekar  <siddhesh@redhat.com>
 
+	* Makefile (summarize-tests): Fix return value on success.
+
 	* manual/string.texi (Envz Functions): Add envz_remove.
 
 2015-05-18  Roland McGrath  <roland@hack.frob.com>
diff --git a/Makefile b/Makefile
index 7edf517724..658ccfa037 100644
--- a/Makefile
+++ b/Makefile
@@ -320,7 +320,7 @@ define summarize-tests
 @egrep -v '^(PASS|XFAIL):' $(objpfx)$1 || true
 @echo "Summary of test results$2:"
 @sed 's/:.*//' < $(objpfx)$1 | sort | uniq -c
-@egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1 && false
+@! egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1
 endef
 
 tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))