about summary refs log tree commit diff
path: root/time
diff options
context:
space:
mode:
authorZack Weinberg <zackw@panix.com>2019-08-16 21:10:11 -0400
committerZack Weinberg <zackw@panix.com>2019-08-21 08:26:36 -0400
commit1baae4aa6f3313da77d799f12f963910b05db637 (patch)
tree8e355e8254a1e5f93b381f552ab5e95a3dd64fcf /time
parentf9fabc1b02d252d5d9b2e0df406bb394b8a7b46a (diff)
downloadglibc-1baae4aa6f3313da77d799f12f963910b05db637.tar.gz
glibc-1baae4aa6f3313da77d799f12f963910b05db637.tar.xz
glibc-1baae4aa6f3313da77d799f12f963910b05db637.zip
Don't use the argument to time.
It doesn't make sense to remove all the internal uses of time.
It's still a standard ISO C function, and its callers don't need
sub-second resolution and would be unnecessarily complicated if
they had to declare a struct timespec instead of just a time_t.
However, a handful of places were using the vestigial "result"
argument instead of the return value, which is slightly less
efficient and also looks strange.  Correct this.

	* misc/syslog.c (__vsyslog_internal)
	* time/getdate.c (__getdate_r)
	* time/tst_wcsftime.c (main):
	Use return value of time, not its argument.

	* string/strfry.c (strfry)
	* sysdeps/mach/sleep.c (__sleep):
	Remove unnecessary casts of NULL in calls to time.
Diffstat (limited to 'time')
-rw-r--r--time/getdate.c2
-rw-r--r--time/tst_wcsftime.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/time/getdate.c b/time/getdate.c
index aee96f7163..8a567c3fcd 100644
--- a/time/getdate.c
+++ b/time/getdate.c
@@ -219,7 +219,7 @@ __getdate_r (const char *string, struct tm *tp)
     return 7;
 
   /* Get current time.  */
-  time (&timer);
+  timer = time (NULL);
   __localtime_r (&timer, &tm);
 
   /* If only the weekday is given, today is assumed if the given day
diff --git a/time/tst_wcsftime.c b/time/tst_wcsftime.c
index 3f6f0d9f77..55c45f6a81 100644
--- a/time/tst_wcsftime.c
+++ b/time/tst_wcsftime.c
@@ -10,7 +10,7 @@ main (int argc, char *argv[])
   int result = 0;
   size_t n;
 
-  time (&t);
+  t = time (NULL);
   tp = gmtime (&t);
 
   n = wcsftime (buf, sizeof (buf) / sizeof (buf[0]),