about summary refs log tree commit diff
path: root/time/bug-asctime_r.c
diff options
context:
space:
mode:
authorUlrich Drepper <drepper@redhat.com>2005-10-14 15:17:40 +0000
committerUlrich Drepper <drepper@redhat.com>2005-10-14 15:17:40 +0000
commitce982312e888ff1fd9b869240951805d281f7517 (patch)
treee68f0f42b945ce719ad1ea032b59deb1bc78e57b /time/bug-asctime_r.c
parent576c8451485408d776914e756e5cc554e9d93eda (diff)
downloadglibc-ce982312e888ff1fd9b869240951805d281f7517.tar.gz
glibc-ce982312e888ff1fd9b869240951805d281f7517.tar.xz
glibc-ce982312e888ff1fd9b869240951805d281f7517.zip
[BZ #1460]
	* time/asctime.c (asctime_internal): New function, derived from
	asctime_r.  Takes additional parameter which is the buffer length.
	Use snprintf instead sprintf, if it overflows, fail.
	(asctime_r): Call asctime_internal with 26 as buffer length.
	(asctime): Call asctime_internal with length of internal buffer.
	* time/Makefile (tests): Add bug-asctime_r.
	* time/bug-asctime_r.c: New file.
Diffstat (limited to 'time/bug-asctime_r.c')
-rw-r--r--time/bug-asctime_r.c26
1 files changed, 26 insertions, 0 deletions
diff --git a/time/bug-asctime_r.c b/time/bug-asctime_r.c
new file mode 100644
index 0000000000..2579a6a3b0
--- /dev/null
+++ b/time/bug-asctime_r.c
@@ -0,0 +1,26 @@
+#include <errno.h>
+#include <limits.h>
+#include <stdio.h>
+#include <time.h>
+
+
+static int
+do_test (void)
+{
+  int result = 0;
+  time_t t = time (NULL);
+  struct tm *tp = localtime (&t);
+  tp->tm_year = 10000 - 1900;
+  char buf[1000];
+  errno = 0;
+  char *s = asctime_r (tp, buf);
+  if (s != NULL || errno != EOVERFLOW)
+    {
+      puts ("asctime_r did not fail correctly");
+      result = 1;
+    }
+  return result;
+}
+
+#define TEST_FUNCTION do_test ()
+#include "../test-skeleton.c"