about summary refs log tree commit diff
path: root/sysdeps
diff options
context:
space:
mode:
authorZack Weinberg <zackw@panix.com>2017-12-23 00:06:03 -0500
committerZack Weinberg <zackw@panix.com>2017-12-24 09:03:28 -0800
commit48a8f8328122ab8d06b7333cb87be46feeaf7cca (patch)
treee61a3b567c0c78787c06a38dfe0fce7ccb749f28 /sysdeps
parenta47ad79afa454192224214a3db2499de12baf93e (diff)
downloadglibc-48a8f8328122ab8d06b7333cb87be46feeaf7cca.tar.gz
glibc-48a8f8328122ab8d06b7333cb87be46feeaf7cca.tar.xz
glibc-48a8f8328122ab8d06b7333cb87be46feeaf7cca.zip
Deprecate external use of libio.h and _G_config.h.
libio.h was originally the header for a set of supported GNU
extensions, but they have not been maintained as such in many years,
they are now standing in the way of improvements to stdio, and we
don't think there are any remaining external users.  _G_config.h was
never intended for public use, but predates the bits convention.
Move both of these headers into the bits directory and provide stubs
at top level which issue deprecation warnings.

The contents of (bits/)libio.h and (bits/)_G_config.h are still
exposed to external software via stdio.h; changing that requires more
complex surgery than I have time to attempt right now.

	* libio/libio.h, libio/_G_config.h: New stub headers which issue a
	deprecation warning and then include <bits/libio.h>, <bits/_G_config.h>
	respectively.
	* libio/libio.h: Rename the original version of this file to
	libio/bits/libio.h.  Error out if not included by stdio.h or the
	stub libio.h.
	* include/libio.h: Move to include/bits.  Forward to libio/bits/libio.h.
	* sysdeps/generic/_G_config.h: Move to top-level bits/.  Error out
	if not included by bits/libio.h or the stub _G_config.h.
	* sysdeps/unix/sysv/linux/_G_config.h: Move to
	sysdeps/unix/sysv/linux/bits.  Error out if not included by
	bits/libio.h or the stub _G_config.h.
	* libio/stdio.h: Include bits/libio.h, not libio.h.
	* libio/Makefile: Install bits/libio.h and bits/_G_config.h as
	well as libio.h and _G_config.h.

	* csu/init.c, libio/fmemopen.c, libio/iolibio.h, libio/oldfmemopen.c
	* libio/strfile.h, stdio-common/vfscanf.c
	* sysdeps/pthread/flockfile.c, sysdeps/pthread/funlockfile.c
	Include stdio.h, not _G_config.h nor libio.h.
	* libio/iofgetpos.c: Also rename fgetpos64 out of the way.
	* libio/iofsetpos.c: Also rename fsetpos64 out of the way.

	* scripts/check-installed-headers.sh: Skip libio.h and _G_config.h.
Diffstat (limited to 'sysdeps')
-rw-r--r--sysdeps/generic/_G_config.h58
-rw-r--r--sysdeps/pthread/flockfile.c1
-rw-r--r--sysdeps/pthread/funlockfile.c1
-rw-r--r--sysdeps/unix/sysv/linux/bits/_G_config.h (renamed from sysdeps/unix/sysv/linux/_G_config.h)10
4 files changed, 7 insertions, 63 deletions
diff --git a/sysdeps/generic/_G_config.h b/sysdeps/generic/_G_config.h
deleted file mode 100644
index c49eed395b..0000000000
--- a/sysdeps/generic/_G_config.h
+++ /dev/null
@@ -1,58 +0,0 @@
-/* This file is needed by libio to define various configuration parameters.
-   These are always the same in the GNU C library.  */
-
-#ifndef _G_config_h
-#define _G_config_h 1
-
-/* Define types for libio in terms of the standard internal type names.  */
-
-#include <bits/types.h>
-#define __need_size_t
-#if defined _LIBC || defined _GLIBCPP_USE_WCHAR_T
-# define __need_wchar_t
-#endif
-#define __need_NULL
-#include <stddef.h>
-
-#include <bits/types/__mbstate_t.h>
-#if defined _LIBC || defined _GLIBCPP_USE_WCHAR_T
-# include <bits/types/wint_t.h>
-#endif
-
-typedef struct
-{
-  __off_t __pos;
-  __mbstate_t __state;
-} _G_fpos_t;
-typedef struct
-{
-  __off64_t __pos;
-  __mbstate_t __state;
-} _G_fpos64_t;
-#if defined _LIBC || defined _GLIBCPP_USE_WCHAR_T
-# include <gconv.h>
-typedef union
-{
-  struct __gconv_info __cd;
-  struct
-  {
-    struct __gconv_info __cd;
-    struct __gconv_step_data __data;
-  } __combined;
-} _G_iconv_t;
-#endif
-
-
-/* These library features are always available in the GNU C library.  */
-#define _G_va_list __gnuc_va_list
-
-#define _G_HAVE_MMAP 1
-
-#define _G_IO_IO_FILE_VERSION 0x20001
-
-/* This is defined by <bits/stat.h> if `st_blksize' exists.  */
-#define _G_HAVE_ST_BLKSIZE defined (_STATBUF_ST_BLKSIZE)
-
-#define _G_BUFSIZ 8192
-
-#endif	/* _G_config.h */
diff --git a/sysdeps/pthread/flockfile.c b/sysdeps/pthread/flockfile.c
index a8e6c28ed9..14c1be1d80 100644
--- a/sysdeps/pthread/flockfile.c
+++ b/sysdeps/pthread/flockfile.c
@@ -18,7 +18,6 @@
 
 #include <pthread.h>
 #include <stdio.h>
-#include <libio.h>
 #include <stdio-lock.h>
 
 
diff --git a/sysdeps/pthread/funlockfile.c b/sysdeps/pthread/funlockfile.c
index 2389ad4fbf..9f5463448f 100644
--- a/sysdeps/pthread/funlockfile.c
+++ b/sysdeps/pthread/funlockfile.c
@@ -18,7 +18,6 @@
 
 #include <pthread.h>
 #include <stdio.h>
-#include <libio.h>
 #include <stdio-lock.h>
 
 
diff --git a/sysdeps/unix/sysv/linux/_G_config.h b/sysdeps/unix/sysv/linux/bits/_G_config.h
index 3bc6cfd595..9994869098 100644
--- a/sysdeps/unix/sysv/linux/_G_config.h
+++ b/sysdeps/unix/sysv/linux/bits/_G_config.h
@@ -1,8 +1,12 @@
 /* This file is needed by libio to define various configuration parameters.
    These are always the same in the GNU C library.  */
 
-#ifndef _G_config_h
-#define _G_config_h 1
+#ifndef _BITS_G_CONFIG_H
+#define _BITS_G_CONFIG_H 1
+
+#if !defined _BITS_LIBIO_H && !defined _G_CONFIG_H
+# error "Never include <bits/_G_config.h> directly; use <stdio.h> instead."
+#endif
 
 /* Define types for libio in terms of the standard internal type names.  */
 
@@ -56,4 +60,4 @@ typedef union
 
 #define _G_BUFSIZ 8192
 
-#endif	/* _G_config.h */
+#endif	/* bits/_G_config.h */